From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 106258] AMD Xorg start failes with non-4K page sizes Date: Tue, 19 Jun 2018 09:07:47 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2075266688==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 575F56E4E5 for ; Tue, 19 Jun 2018 09:07:47 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2075266688== Content-Type: multipart/alternative; boundary="15293992671.eC4BB.13663" Content-Transfer-Encoding: 7bit --15293992671.eC4BB.13663 Date: Tue, 19 Jun 2018 09:07:47 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D106258 --- Comment #30 from Michel D=C3=A4nzer --- I suspect there's an issue in amdgpu_vm_bo_split_mapping, e.g. this code lo= oks suspicious: if (pages_addr) { uint64_t count; max_entries =3D min(max_entries, 16ull * 1024ull); for (count =3D 1; count < max_entries; ++count) { uint64_t idx =3D pfn + count; if (pages_addr[idx] !=3D (pages_addr[idx - 1] + PAGE_SIZE)) break; } count is compared to max_entries, which is a number of GPU pages, but is al= so added to pfn, which is a number of CPU pages. --=20 You are receiving this mail because: You are the assignee for the bug.= --15293992671.eC4BB.13663 Date: Tue, 19 Jun 2018 09:07:47 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 30 on bug 10625= 8 from Michel D=C3=A4nzer 
I suspect there's an issue in amdgpu_vm_bo_split_mapping, e.g.=
 this code looks
suspicious:

                if (pages_addr) {
                        uint64_t count;

                        max_entries =3D min(max_entries, 16ull * 1024ull);
                        for (count =3D 1; count < max_entries; ++count) {
                                uint64_t idx =3D pfn + count;

                                if (pages_addr[idx] !=3D
                                    (pages_addr[idx - 1] + PAGE_SIZE))
                                        break;
                        }

count is compared to max_entries, which is a number of GPU pages, but is al=
so
added to pfn, which is a number of CPU pages.

You are receiving this mail because:
  • You are the assignee for the bug.
= --15293992671.eC4BB.13663-- --===============2075266688== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2075266688==--