From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 106928] When starting a match Rocket League crashes on "Go" Date: Fri, 29 Jun 2018 20:54:57 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1829419416==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 889876F1B2 for ; Fri, 29 Jun 2018 20:54:57 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1829419416== Content-Type: multipart/alternative; boundary="15303056972.6013c3AB6.23291" Content-Transfer-Encoding: 7bit --15303056972.6013c3AB6.23291 Date: Fri, 29 Jun 2018 20:54:57 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D106928 --- Comment #17 from Roland Scheidegger --- (In reply to ubizjak from comment #15) > (In reply to Dave Airlie from comment #14) > > I think Roland's first patch is correct, just call fold_alu_op2 if we g= et > > back 2 sources from fold_assoc. return true is for when we've finished = all > > folding on that instruction, so I don't think that's correct without ca= lling > > fold_alu_op2 >=20 > LGTM then (it also fixes the failure for me), but can we please drop the > "else" from the patch, it is really confusing. Sure that can be done. (I was actually also wondering if the test for n.src.size() < 3 at the beginning of the function is actually necessary, ar= e we really supposed to have already fewer sources when this is called? But I couldn't quite answer that. This code is a bit confusing to me.) --=20 You are receiving this mail because: You are the assignee for the bug.= --15303056972.6013c3AB6.23291 Date: Fri, 29 Jun 2018 20:54:57 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 17 on bug 10692= 8 from Roland Scheidegger 
(In reply to ubizjak from comment #15)
> (In reply to Dave Airlie from comment #14)
> > I think Roland's first patch is correct, just call fold_alu_op2 i=
f we get
> > back 2 sources from fold_assoc. return true is for when we've fin=
ished all
> > folding on that instruction, so I don't think that's correct with=
out calling
> > fold_alu_op2
>=20
> LGTM then (it also fixes the failure for me), but can we please drop t=
he
> "else" from the patch, it is really confusing.

Sure that can be done. (I was actually also wondering if the test for
n.src.size() < 3 at the beginning of the function is actually necessary,=
 are we
really supposed to have already fewer sources when this is called? But I
couldn't quite answer that. This code is a bit confusing to me.)

You are receiving this mail because:
  • You are the assignee for the bug.
= --15303056972.6013c3AB6.23291-- --===============1829419416== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1829419416==--