From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 106928] When starting a match Rocket League crashes on "Go" Date: Fri, 07 Sep 2018 17:36:24 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1720372932==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id BC0E96E0C3 for ; Fri, 7 Sep 2018 17:36:23 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1720372932== Content-Type: multipart/alternative; boundary="15363417830.7e9e.19453" Content-Transfer-Encoding: 7bit --15363417830.7e9e.19453 Date: Fri, 7 Sep 2018 17:36:23 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D106928 Andr=C3=A9s G=C3=B3mez Garc=C3=ADa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agomez@igalia.com, | |sroland@vmware.com --- Comment #21 from Andr=C3=A9s G=C3=B3mez Garc=C3=ADa = --- Roland, is this fixed by? commit 817efd89685efc6b5866e09cbdad01c4ff21c737 Author: Roland Scheidegger Date: Wed Jul 4 04:44:17 2018 +0200 r600/sb: fix crash in fold_alu_op3 fold_assoc() called from fold_alu_op3() can lower the number of src to = 2, which then leads to an invalid access to n.src[2]->gvalue(). This didn't seem to have caused much harm in the past, but on Fedora 28 it will crash (presumably because -D_GLIBCXX_ASSERTIONS is used, althou= gh with libstdc++ 4.8.5 this didn't do anything, -D_GLIBCXX_DEBUG was needed to show the issue). An alternative fix would be to instead call fold_alu_op2() from within fold_assoc() when the number of src is reduced and return always TRUE from fold_assoc() in this case, with the only actual difference being the return value from fold_alu_op3() then. I'm not sure what the return value actually should be in this case (or whether it even can make a difference). https://bugs.freedesktop.org/show_bug.cgi?id=3D106928 Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Dave Airlie --=20 You are receiving this mail because: You are the assignee for the bug.= --15363417830.7e9e.19453 Date: Fri, 7 Sep 2018 17:36:23 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated Andr=C3=A9s G=C3=B3mez Garc=C3=ADa= changed bug 10692= 8
What Removed Added
CC   agomez@igalia.com, sroland@vmware.com

Comme= nt # 21 on bug 10692= 8 from Andr=C3=A9s G=C3=B3mez Garc=C3= =ADa
Roland, is this fixed by?

commit 817efd89685efc6b5866e09cbdad01c4ff21c737
Author: Roland Scheidegger <sr=
oland@vmware.com>
Date:   Wed Jul 4 04:44:17 2018 +0200

    r600/sb: fix crash in fold_alu_op3

    fold_assoc() called from fold_alu_op3() can lower the number of src to =
2,
    which then leads to an invalid access to n.src[2]->gvalue().
    This didn't seem to have caused much harm in the past, but on Fedora 28
    it will crash (presumably because -D_GLIBCXX_ASSERTIONS is used, althou=
gh
    with libstdc++ 4.8.5 this didn't do anything, -D_GLIBCXX_DEBUG was
    needed to show the issue).

    An alternative fix would be to instead call fold_alu_op2() from within
    fold_assoc() when the number of src is reduced and return always TRUE
    from fold_assoc() in this case, with the only actual difference being
    the return value from fold_alu_op3() then. I'm not sure what the return
    value actually should be in this case (or whether it even can make a
    difference).

    https://bugs.freedesktop.org/show_bug.=
cgi?id=3D106928
    Cc: mesa-stabl=
e@lists.freedesktop.org
    Reviewed-by: Dave Airlie <=
airlied@redhat.com>


You are receiving this mail because:
  • You are the assignee for the bug.
= --15363417830.7e9e.19453-- --===============1720372932== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1720372932==--