From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 107065] "BUG: unable to handle kernel paging request at 0000000000002000" in amdgpu_vm_cpu_set_ptes at amdgpu_vm.c:921 Date: Mon, 02 Jul 2018 11:03:45 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1665043927==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 46BB76E3BB for ; Mon, 2 Jul 2018 11:03:45 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1665043927== Content-Type: multipart/alternative; boundary="15305294251.8Aafb.18558" Content-Transfer-Encoding: 7bit --15305294251.8Aafb.18558 Date: Mon, 2 Jul 2018 11:03:45 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D107065 --- Comment #11 from Christian K=C3=B6nig --- (In reply to Andrey Grodzovsky from comment #10) > Created attachment 140418 [details] [review] > drm/amdgpu: Verify root PD is mapped into kernel address space. >=20 > dwagner, please try this patch. Fixes the issue for me and I observed no > suspend/resume issues. >=20 > Christian, please take a look at the patch, problem was that in > amdgpu_vm_update_directories the parent BO didn't have a kernel mapping a= nd > so later inside amdgpu_vm_cpu_set_ptes=20 > pe +=3D (unsigned long)amdgpu_bo_kptr(bo); would equal to 00000000000020= 00 > since=20 > parent amdgpu_bo_kptr woudld return NULL. The parent was the root PD.=20 >=20 > This was still working in 67b8d5c Linus Torvalds 7 weeks ago Linux > 4.17-rc5 (tag: v4.17-rc5) but I wasn't able to exactly pinpoint which > change broke it. I am not sure my fix is the right one so please advise. No idea when that broke either, CPU based updates is not something we usual= ly test. Anyway it's a good catch, but I would rather add that to amdgpu_vm_bo_base_init() (with the appropriate checks). That would also allow us to remove the duplicated code from amdgpu_vm_alloc_levels(). --=20 You are receiving this mail because: You are the assignee for the bug.= --15305294251.8Aafb.18558 Date: Mon, 2 Jul 2018 11:03:45 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 11 on bug 10706= 5 from Christian K=C3= =B6nig 
(In reply to Andrey Grodzovsky from comment #10)
> Created attachment 140418 [details] [review=
] [review]
> drm/amdgpu: Verify root PD is mapped into kernel address space.
>=20
> dwagner, please try this patch. Fixes the issue for me and I observed =
no
> suspend/resume issues.
>=20
> Christian, please take a look at the patch, problem was that in
> amdgpu_vm_update_directories the parent BO didn't have a kernel mappin=
g and
> so later inside amdgpu_vm_cpu_set_ptes=20
> pe +=3D (unsigned long)amdgpu_bo_kptr(bo); would equal to  00000000000=
02000
> since=20
> parent amdgpu_bo_kptr woudld return NULL. The parent was the root PD.=
=20
>=20
> This was still working in 67b8d5c Linus Torvalds      7 weeks ago    L=
inux
> 4.17-rc5   (tag: v4.17-rc5) but I wasn't able to exactly pinpoint which
> change broke it. I am not sure my fix is the right one so please advis=
e.

No idea when that broke either, CPU based updates is not something we usual=
ly
test.

Anyway it's a good catch, but I would rather add that to
amdgpu_vm_bo_base_init() (with the appropriate checks).

That would also allow us to remove the duplicated code from
amdgpu_vm_alloc_levels().

You are receiving this mail because:
  • You are the assignee for the bug.
= --15305294251.8Aafb.18558-- --===============1665043927== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1665043927==--