From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 107296] WARNING: CPU: 0 PID: 370 at drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:1355 dcn_bw_update_from_pplib+0x16b/0x280 [amdgpu] Date: Sat, 13 Jul 2019 18:30:40 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1609811963==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id B30A789CE0 for ; Sat, 13 Jul 2019 18:30:40 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1609811963== Content-Type: multipart/alternative; boundary="15630426402.aeE7.28276" Content-Transfer-Encoding: 7bit --15630426402.aeE7.28276 Date: Sat, 13 Jul 2019 18:30:40 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D107296 Paul Menzel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paulepanter@users.sourcefor | |ge.net --- Comment #16 from Paul Menzel --- Could some AMD developer please comment, on how to fix this? Tables(?) containing =E2=80=9C0 kHz=E2=80=9D are apparently shipped by vendors, so wh= at to do? ``` static bool verify_clock_values(struct dm_pp_clock_levels_with_voltage *clk= s) { int i; if (clks->num_levels =3D=3D 0) return false; for (i =3D 0; i < clks->num_levels; i++) /* Ensure that the result is sane */ if (clks->data[i].clocks_in_khz =3D=3D 0) return false; return true; } ``` Should commit 00893681a0ff4 (drm/amd/display: Reject PPLib clock values if = they are invalid) [1] be reverted? Andrew, Tony, Harry? > drm/amd/display: Reject PPLib clock values if they are invalid > > We should be sticking with the default clock values if the values > obtained from PPLib are bogus. > > Signed-off-by: Andrew Jiang > Reviewed-by: Tony Cheng > Acked-by: Harry Wentland > Signed-off-by: Alex Deucher PS: AMDGPU=E2=80=99s commit messages are too terse, and should be more elab= orate. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?= id=3D00893681a0ff41cacecabc3dafe0987593a3d5c5 --=20 You are receiving this mail because: You are the assignee for the bug.= --15630426402.aeE7.28276 Date: Sat, 13 Jul 2019 18:30:40 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated Paul Menzel changed bug 10729= 6
What Removed Added
CC   paulepanter@users.sourceforge.net

Comme= nt # 16 on bug 10729= 6 from Paul Menzel
Could some AMD developer please comment, on how to fix this? T=
ables(?)
containing =E2=80=9C0 kHz=E2=80=9D are apparently shipped by vendors, so wh=
at to do?

```
static bool verify_clock_values(struct dm_pp_clock_levels_with_voltage *clk=
s)
{
        int i;

        if (clks->num_levels =3D=3D 0)
                return false;

        for (i =3D 0; i < clks->num_levels; i++)
                /* Ensure that the result is sane */
                if (clks->data[i].clocks_in_khz =3D=3D 0)
                        return false;

        return true;
}
```

Should commit 00893681a0ff4 (drm/amd/display: Reject PPLib clock values if =
they
are invalid) [1] be reverted? Andrew, Tony, Harry?

> drm/amd/display: Reject PPLib clock values if th=
ey are invalid
>
> We should be sticking with the default clock val=
ues if the values
> obtained from PPLib are bogus.
>
> Signed-off-by: Andrew Jiang <Andrew.Jiang@amd.com>
> Reviewed-by: Tony Cheng <=
Tony.Cheng@amd.com>
> Acked-by: Harry Wentland <harry.wentland@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

PS: AMDGPU=E2=80=99s commit messages are too terse, and should be more elab=
orate.

[1]:
https://git.kerne=
l.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3D00893681a0ff=
41cacecabc3dafe0987593a3d5c5


You are receiving this mail because:
  • You are the assignee for the bug.
= --15630426402.aeE7.28276-- --===============1609811963== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1609811963==--