From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 107296] WARNING: CPU: 0 PID: 370 at drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:1355 dcn_bw_update_from_pplib+0x16b/0x280 [amdgpu] Date: Mon, 23 Jul 2018 14:29:35 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0188564457==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id CF5E56E0D8 for ; Mon, 23 Jul 2018 14:29:35 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0188564457== Content-Type: multipart/alternative; boundary="15323561750.Bbe551a17.7654" Content-Transfer-Encoding: 7bit --15323561750.Bbe551a17.7654 Date: Mon, 23 Jul 2018 14:29:35 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D107296 --- Comment #1 from Paul Menzel --- In today=E2=80=99s drm-tip this is: [ 20.149515] WARNING: CPU: 0 PID: 347 at drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:1372 dcn_bw_update_from_pplib+0x16b/0x280 [amdgpu] It looks like this is `BREAK_TO_DEBUGGER()` [1], which is defined as `#defi= ne BREAK_TO_DEBUGGER() ASSERT(0)`. ``` /* TODO: This is not the proper way to obtain fabric_and_dram_bandwidth, should be min(fclk, memclk) */ res =3D dm_pp_get_clock_levels_by_type_with_voltage( ctx, DM_PP_CLOCK_TYPE_FCLK, &fclks); if (res) res =3D verify_clock_values(&fclks); if (res) { ASSERT(fclks.num_levels >=3D 3); dc->dcn_soc->fabric_and_dram_bandwidth_vmin0p65 =3D 32 * (fclks.data[0].clocks_in_khz / 1000.0) / 1000.0; dc->dcn_soc->fabric_and_dram_bandwidth_vmid0p72 =3D dc->dcn_soc->number_of_channels * (fclks.data[fclks.num_levels - (fclks.num_levels > 2 ? 3 : 2)].clocks_in_khz / 1000.0) * ddr4_dram_factor_single_Channel / 1000.0; dc->dcn_soc->fabric_and_dram_bandwidth_vnom0p8 =3D dc->dcn_soc->number_of_channels * (fclks.data[fclks.num_levels - 2].clocks_in= _khz / 1000.0) * ddr4_dram_factor_single_Channel / 1000.0; dc->dcn_soc->fabric_and_dram_bandwidth_vmax0p9 =3D dc->dcn_soc->number_of_channels * (fclks.data[fclks.num_levels - 1].clocks_in= _khz / 1000.0) * ddr4_dram_factor_single_Channel / 1000.0; } else BREAK_TO_DEBUGGER(); ``` So, either `dm_pp_get_clock_levels_by_type_with_voltage()` or `verify_clock_values(&fclks)` returns 0. [1]: https://cgit.freedesktop.org/drm-tip/tree/drivers/gpu/drm/amd/display/dc/ca= lcs/dcn_calcs.c#n1372 --=20 You are receiving this mail because: You are the assignee for the bug.= --15323561750.Bbe551a17.7654 Date: Mon, 23 Jul 2018 14:29:35 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 1 on bug 10729= 6 from Paul Menzel
In today=E2=80=99s drm-tip this is:

    [   20.149515] WARNING: CPU: 0 PID: 347 at
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:1372
dcn_bw_update_from_pplib+0x16b/0x280 [amdgpu]

It looks like this is `BREAK_TO_DEBUGGER()` [1], which is defined as `#defi=
ne
BREAK_TO_DEBUGGER() ASSERT(0)`.

```
        /* TODO: This is not the proper way to obtain
fabric_and_dram_bandwidth, should be min(fclk, memclk) */
        res =3D dm_pp_get_clock_levels_by_type_with_voltage(
                        ctx, DM_PP_CLOCK_TYPE_FCLK, &fclks);

        if (res)
                res =3D verify_clock_values(&fclks);

        if (res) {
                ASSERT(fclks.num_levels >=3D 3);
                dc->dcn_soc->fabric_and_dram_bandwidth_vmin0p65 =3D 3=
2 *
(fclks.data[0].clocks_in_khz / 1000.0) / 1000.0;
                dc->dcn_soc->fabric_and_dram_bandwidth_vmid0p72 =3D
dc->dcn_soc->number_of_channels *
                                (fclks.data[fclks.num_levels -
(fclks.num_levels > 2 ? 3 : 2)].clocks_in_khz / 1000.0)
                                * ddr4_dram_factor_single_Channel / 1000.0;
                dc->dcn_soc->fabric_and_dram_bandwidth_vnom0p8 =3D
dc->dcn_soc->number_of_channels *
                                (fclks.data[fclks.num_levels - 2].clocks_in=
_khz
/ 1000.0)
                                * ddr4_dram_factor_single_Channel / 1000.0;
                dc->dcn_soc->fabric_and_dram_bandwidth_vmax0p9 =3D
dc->dcn_soc->number_of_channels *
                                (fclks.data[fclks.num_levels - 1].clocks_in=
_khz
/ 1000.0)
                                * ddr4_dram_factor_single_Channel / 1000.0;
        } else
                BREAK_TO_DEBUGGER();
```

So, either `dm_pp_get_clock_levels_by_type_with_voltage()` or
`verify_clock_values(&fclks)` returns 0.

[1]:
https://cgit.freedesktop.org/drm-tip/tree=
/drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c#n1372


You are receiving this mail because:
  • You are the assignee for the bug.
= --15323561750.Bbe551a17.7654-- --===============0188564457== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0188564457==--