From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 107384] random tab crashes in firefox nightly Date: Sat, 28 Jul 2018 23:16:35 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1661471536==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 9BBBA6E0AA for ; Sat, 28 Jul 2018 23:16:35 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1661471536== Content-Type: multipart/alternative; boundary="15328197950.a1bd4F4.4528" Content-Transfer-Encoding: 7bit --15328197950.a1bd4F4.4528 Date: Sat, 28 Jul 2018 23:16:35 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D107384 --- Comment #7 from Christoph Haag --- (In reply to Chris Wilson from comment #5) > Sigh. >=20 > diff --git a/src/loader/loader.c b/src/loader/loader.c > index 43275484cc..87b7281f78 100644 > --- a/src/loader/loader.c > +++ b/src/loader/loader.c > @@ -274,7 +274,7 @@ int loader_get_user_preferred_fd(int default_fd, bool > *different_device) > static int > drm_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id) > { > - drmDevicePtr device; > + drmDevicePtr device =3D NULL; > int ret; >=20=20 > if (drmGetDevice2(fd, 0, &device) =3D=3D 0) { Thanks, looks like this is my issue too. diff --git a/src/loader/loader.c b/src/loader/loader.c index 43275484cc2..02a1f97684f 100644 --- a/src/loader/loader.c +++ b/src/loader/loader.c @@ -167,7 +167,7 @@ static bool drm_device_matches_tag(drmDevicePtr device, const char *prime_tag) static char *drm_get_id_path_tag_for_fd(int fd) { - drmDevicePtr device; + drmDevicePtr device =3D NULL; char *tag; if (drmGetDevice2(fd, 0, &device) !=3D 0) @@ -274,7 +274,7 @@ int loader_get_user_preferred_fd(int default_fd, bool *different_device) static int drm_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id) { - drmDevicePtr device; + drmDevicePtr device =3D NULL; int ret; if (drmGetDevice2(fd, 0, &device) =3D=3D 0) { --=20 You are receiving this mail because: You are the assignee for the bug.= --15328197950.a1bd4F4.4528 Date: Sat, 28 Jul 2018 23:16:35 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 7 on bug 10738= 4 from Christoph Haag
(In reply to Chris Wilson from comment #5)
> Sigh.
>=20
> diff --git a/src/loader/loader.c b/src/loader/loader.c
> index 43275484cc..87b7281f78 100644
> --- a/src/loader/loader.c
> +++ b/src/loader/loader.c
> @@ -274,7 +274,7 @@ int loader_get_user_preferred_fd(i=
nt default_fd, bool
> *different_device)
>  static int
>  drm_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id)
>  {
> -   drmDevicePtr device;
> +   drmDevicePtr device =3D NULL;
>     int ret;
>=20=20
>     if (drmGetDevice2(fd, 0, &device) =3D=3D 0) {

Thanks, looks like this is my issue too.

diff --git a/src/loader/loader.c b/src/loader/loader.c
index 43275484cc2..02a1f97684f 100644
--- a/src/loader/loader.c
+++ b/src/loader/loader.c
@@ -167,7 +167,7 @@ static bool drm_device_matches_tag(drmD=
evicePtr device,
const char *prime_tag)

 static char *drm_get_id_path_tag_for_fd(int fd)
 {
-   drmDevicePtr device;
+   drmDevicePtr device =3D NULL;
    char *tag;

    if (drmGetDevice2(fd, 0, &device) !=3D 0)
@@ -274,7 +274,7 @@ int loader_get_user_preferred_fd(int de=
fault_fd, bool
*different_device)
 static int
 drm_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id)
 {
-   drmDevicePtr device;
+   drmDevicePtr device =3D NULL;
    int ret;

    if (drmGetDevice2(fd, 0, &device) =3D=3D 0) {


You are receiving this mail because:
  • You are the assignee for the bug.
= --15328197950.a1bd4F4.4528-- --===============1661471536== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1661471536==--