[Bug 109135] R9 390 hangs at boot with DPM/DC enabled for kernels 4.19.x and above, says KMS not supported - bugzilla-daemon

From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 109135] R9 390 hangs at boot with DPM/DC enabled for kernels 4.19.x and above, says KMS not supported
Date: Wed, 16 Jan 2019 18:58:15 +0000	[thread overview]
Message-ID: <bug-109135-502-Ub7s2VAGL9@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-109135-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1098 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=109135

--- Comment #23 from Alex Deucher <alexdeucher@gmail.com> ---
(In reply to iive from comment #22)
> 
> It is code refactoring. It doesn't remove, add or modify any functionality.
> It just changes how some functions are called. (1 function pointer and
> switch/case, instead of 3 function pointers.)
> I honestly could not spot what might be wrong with it.

this changed:
@@ -1751,10 +1751,10 @@ void amdgpu_dpm_enable_uvd(struct amdgpu_device *adev,
bool enable)

 void amdgpu_dpm_enable_vce(struct amdgpu_device *adev, bool enable)
 {
-       if (adev->powerplay.pp_funcs->powergate_vce) {
+       if (adev->powerplay.pp_funcs->set_powergating_by_smu) {

CI asic never had a powergate_vce callback before, so that code was never
called for vce previously, at least for the old dpm implementation.  For the
new on, it actually had a callback for vce powergating, but perhaps there was a
bug in that code around the time this code was changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2084 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
