From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109366] NULL pointer at pcie_capability_read_dword with Radeon SI vfio passthrough Date: Tue, 15 Jan 2019 15:39:07 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1790794551==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id CF46C6ED65 for ; Tue, 15 Jan 2019 15:39:07 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1790794551== Content-Type: multipart/alternative; boundary="15475667470.27Cfd61.31994" Content-Transfer-Encoding: 7bit --15475667470.27Cfd61.31994 Date: Tue, 15 Jan 2019 15:39:07 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109366 Bug ID: 109366 Summary: NULL pointer at pcie_capability_read_dword with Radeon SI vfio passthrough Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel@lists.freedesktop.org Reporter: ryandbair@gmail.com Created attachment 143131 --> https://bugs.freedesktop.org/attachment.cgi?id=3D143131&action=3Dedit dmesg output My guest is seeing the attached bug and call trace during boot. Kernel 4.20.2-200, also an issue on 4.19 series. 4.18 is similar with the older dr= m_ prefixed version of the function. --=20 You are receiving this mail because: You are the assignee for the bug.= --15475667470.27Cfd61.31994 Date: Tue, 15 Jan 2019 15:39:07 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 109366
Summary NULL pointer at pcie_capability_read_dword with Radeon SI vfi= o passthrough
Product DRI
Version unspecified
Hardware x86-64 (AMD64)
OS Linux (All)
Status NEW
Severity normal
Priority medium
Component DRM/AMDgpu
Assignee dri-devel@lists.freedesktop.org
Reporter ryandbair@gmail.com

Created attachment 143131 =
[details]
dmesg output

My guest is seeing the attached bug and call trace during boot. Kernel
4.20.2-200, also an issue on 4.19 series. 4.18 is similar with the older dr=
m_
prefixed version of the function.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15475667470.27Cfd61.31994-- --===============1790794551== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1790794551==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109366] NULL pointer at pcie_capability_read_dword with Radeon SI vfio passthrough Date: Tue, 15 Jan 2019 16:22:20 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1378169936==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C15B89D46 for ; Tue, 15 Jan 2019 16:22:20 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1378169936== Content-Type: multipart/alternative; boundary="15475693401.B53e26.14786" Content-Transfer-Encoding: 7bit --15475693401.B53e26.14786 Date: Tue, 15 Jan 2019 16:22:20 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109366 --- Comment #1 from Alex Williamson --- Use a Q35 VM configuration with the assigned GPU downstream of an emulated = PCIe root port as a workaround. The driver assumes this configuration, presumab= ly it's the only one that exists on bare metal, and reads from the upstream de= vice without checking that it is actually present. --=20 You are receiving this mail because: You are the assignee for the bug.= --15475693401.B53e26.14786 Date: Tue, 15 Jan 2019 16:22:20 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 1 on bug 10936= 6 from Alex Williamson
Use a Q35 VM configuration with the assigned GPU downstream of=
 an emulated PCIe
root port as a workaround.  The driver assumes this configuration, presumab=
ly
it's the only one that exists on bare metal, and reads from the upstream de=
vice
without checking that it is actually present.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15475693401.B53e26.14786-- --===============1378169936== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1378169936==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109366] NULL pointer at pcie_capability_read_dword with Radeon SI vfio passthrough Date: Tue, 15 Jan 2019 16:49:57 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0460901787==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id CB08F6E6CD for ; Tue, 15 Jan 2019 16:49:56 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0460901787== Content-Type: multipart/alternative; boundary="15475709960.5624f6.24670" Content-Transfer-Encoding: 7bit --15475709960.5624f6.24670 Date: Tue, 15 Jan 2019 16:49:56 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109366 Alex Deucher changed: What |Removed |Added ---------------------------------------------------------------------------- Component|DRM/AMDgpu |DRM/Radeon --=20 You are receiving this mail because: You are the assignee for the bug.= --15475709960.5624f6.24670 Date: Tue, 15 Jan 2019 16:49:56 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated = Alex Deucher changed bug 10936= 6
What Removed Added
Component DRM/AMDgpu DRM/Radeon


You are receiving this mail because:
  • You are the assignee for the bug.
= --15475709960.5624f6.24670-- --===============0460901787== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0460901787==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109366] NULL pointer at pcie_capability_read_dword with Radeon SI vfio passthrough Date: Tue, 15 Jan 2019 17:16:12 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2004096723==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A7906EDC6 for ; Tue, 15 Jan 2019 17:16:12 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2004096723== Content-Type: multipart/alternative; boundary="15475725720.6F279fC6.2574" Content-Transfer-Encoding: 7bit --15475725720.6F279fC6.2574 Date: Tue, 15 Jan 2019 17:16:12 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109366 --- Comment #2 from Alex Deucher --- Created attachment 143133 --> https://bugs.freedesktop.org/attachment.cgi?id=3D143133&action=3Dedit possible fix Does this patch fix it? dGPUs are always add in cards, so they always plug into an upstream port on bare metal. The driver needs to query the upstream port to determine what pcie gen speeds and lanes are available on the platf= orm so that the driver can properly adjust them at runtime to save power. --=20 You are receiving this mail because: You are the assignee for the bug.= --15475725720.6F279fC6.2574 Date: Tue, 15 Jan 2019 17:16:12 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 2 on bug 10936= 6 from Alex Deucher
Created attachment 143133 =
[details] [review]
possible fix

Does this patch fix it?  dGPUs are always add in cards, so they always plug
into an upstream port on bare metal.  The driver needs to query the upstream
port to determine what pcie gen speeds and lanes are available on the platf=
orm
so that the driver can properly adjust them at runtime to save power.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15475725720.6F279fC6.2574-- --===============2004096723== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2004096723==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109366] NULL pointer at pcie_capability_read_dword with Radeon SI vfio passthrough Date: Thu, 17 Jan 2019 14:12:53 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0563413174==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F79D6E39E for ; Thu, 17 Jan 2019 14:12:53 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0563413174== Content-Type: multipart/alternative; boundary="15477343730.1AD686Fc.28340" Content-Transfer-Encoding: 7bit --15477343730.1AD686Fc.28340 Date: Thu, 17 Jan 2019 14:12:53 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109366 --- Comment #3 from Ryan Bair --- Thank you both for the responses.=20 I can confirm using the Q35 machine type does not see this issue.=20 I'm rebuilding a kernel today to test the patch and will report back. --=20 You are receiving this mail because: You are the assignee for the bug.= --15477343730.1AD686Fc.28340 Date: Thu, 17 Jan 2019 14:12:53 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 3 on bug 10936= 6 from Ryan Bair
Thank you both for the responses.=20

I can confirm using the Q35 machine type does not see this issue.=20

I'm rebuilding a kernel today to test the patch and will report back.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15477343730.1AD686Fc.28340-- --===============0563413174== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0563413174==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109366] NULL pointer at pcie_capability_read_dword with Radeon SI vfio passthrough Date: Thu, 17 Jan 2019 14:51:47 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0362211585==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 9103F6F4B0 for ; Thu, 17 Jan 2019 14:51:47 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0362211585== Content-Type: multipart/alternative; boundary="15477367070.B70AB1Ca.8728" Content-Transfer-Encoding: 7bit --15477367070.B70AB1Ca.8728 Date: Thu, 17 Jan 2019 14:51:47 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109366 --- Comment #4 from Ryan Bair --- I can confirm the attached patch does fix the issue for i440FX. --=20 You are receiving this mail because: You are the assignee for the bug.= --15477367070.B70AB1Ca.8728 Date: Thu, 17 Jan 2019 14:51:47 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 4 on bug 10936= 6 from Ryan Bair
I can confirm the attached patch does fix the issue for i440FX=
.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15477367070.B70AB1Ca.8728-- --===============0362211585== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0362211585==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109366] NULL pointer at pcie_capability_read_dword with Radeon SI vfio passthrough Date: Tue, 19 Nov 2019 09:34:52 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0034261531==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id BEE706F44A for ; Tue, 19 Nov 2019 09:34:53 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0034261531== Content-Type: multipart/alternative; boundary="15741560921.038EEb8ac.9463" Content-Transfer-Encoding: 7bit --15741560921.038EEb8ac.9463 Date: Tue, 19 Nov 2019 09:34:52 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109366 Martin Peres changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #5 from Martin Peres --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this = link to our GitLab instance: https://gitlab.freedesktop.org/drm/amd/issues/861. --=20 You are receiving this mail because: You are the assignee for the bug.= --15741560921.038EEb8ac.9463 Date: Tue, 19 Nov 2019 09:34:52 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated <= span class=3D"fn">Martin Peres changed bug 10936= 6
What Removed Added
Status NEW RESOLVED
Resolution --- MOVED

Commen= t # 5 on bug 10936= 6 from Martin Peres
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this =
link
to our GitLab instance: https://gitlab.freedesktop.org/drm/amd/issues/861.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15741560921.038EEb8ac.9463-- --===============0034261531== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0034261531==--