[Buildroot] [Bug 14676] New: BRCMFMAC SDIO firmware doesn't copy to target

[Buildroot] [Bug 14676] New: BRCMFMAC SDIO firmware doesn't copy to target

[bugzilla]

https://bugs.busybox.net/show_bug.cgi?id=14676

            Bug ID: 14676
           Summary: BRCMFMAC SDIO firmware doesn't copy to target
           Product: buildroot
           Version: 2022.02
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: major
          Priority: P5
         Component: Other
          Assignee: unassigned@buildroot.uclibc.org
          Reporter: dmanlfc@gmail.com
                CC: buildroot@uclibc.org
  Target Milestone: ---

package BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI doesn't copy the firmware to the
target directory.

My workaround:

config BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI
        bool "brcmfmac-sdio-firmware-rpi"
        depends on BR2_arm || BR2_aarch64
        select BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT        # batocera - BR
fix
        select BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI      # batocera - BR
fix
        help
          Raspberry Broadcom Bluetooth and Wifi firmware.

Alternatively remove the ifeq ($(BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT),y)
& ifeq ($(BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI),y) conditionals from the
makefile.

Dan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [Bug 14676] BRCMFMAC SDIO firmware doesn't copy to target

[bugzilla]

https://bugs.busybox.net/show_bug.cgi?id=14676

--- Comment #1 from Fabrice Fontaine <fontaine.fabrice@gmail.com> ---
Hi,

Thanks for your bug report, however this is not a bug but an expected behavior.

With your proposal, the user won't be able to select if we wants to install
bluetooth firmware, wifi firmware or both firmwares. Moreover, the Wifi
firmware can't always be installed as it conflicts with linux-firmware Broadcom
BRCM bcm43xx.

So, I would advise to update the batocera defconfigs (e.g.
https://github.com/batocera-linux/batocera.linux/tree/master/configs) with:

BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI=y 
BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT=y
BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI=y

Best Regards,

Fabrice

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [Bug 14676] BRCMFMAC SDIO firmware doesn't copy to target

[bugzilla]

https://bugs.busybox.net/show_bug.cgi?id=14676

--- Comment #2 from Daniel Martin <dmanlfc@gmail.com> ---
Thanks Fabrice.
Yeah that makes sense - we don't use linux-firmware.
Tested. Please close.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [Bug 14676] BRCMFMAC SDIO firmware doesn't copy to target

[bugzilla]

https://bugs.busybox.net/show_bug.cgi?id=14676

Yann E. MORIN <yann.morin.1998@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yann.morin.1998@free.fr

--- Comment #3 from Yann E. MORIN <yann.morin.1998@free.fr> ---
Daniel, All,

As Fabrice explained, the goal is for a user to be able to choose either
firmware to install. However, when that the package does nothing by default
is indeed not very nice; it might be good to ensure that at least one of
the firmwares is installed, with something like (elided for brevity):

    config BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI
        bool "brcmfmac-sdio-firmware-rpi"
        select BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_WIFI \
               if !BR2_PACKAGE_BRCMFMAC_SDIO_FIRMWARE_RPI_BT

Care to send a proper patch to the list, please?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [Bug 14676] BRCMFMAC SDIO firmware doesn't copy to target

[bugzilla]

https://bugs.busybox.net/show_bug.cgi?id=14676

--- Comment #4 from Peter Seiderer <ps.report@gmx.net> ---
(In reply to Yann E. MORIN from comment #3)

As Fabrice said the user 'wants to install bluetooth firmware, wifi firmware or
both firmwares', the user should select which one he would like to install...

Why select one by default? Why handle differently as e.g. linux-firmware
options?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot