All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linux-scsi@vger.kernel.org
Subject: [Bug 191381] New: LIO ignores XCOPY source and destination descriptor IDs
Date: Wed, 28 Dec 2016 17:10:29 +0000	[thread overview]
Message-ID: <bug-191381-11613@https.bugzilla.kernel.org/> (raw)

https://bugzilla.kernel.org/show_bug.cgi?id=191381

            Bug ID: 191381
           Summary: LIO ignores XCOPY source and destination descriptor
                    IDs
           Product: IO/Storage
           Version: 2.5
    Kernel Version: 4.9.0
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: SCSI
          Assignee: linux-scsi@vger.kernel.org
          Reporter: ddiss.dev@gmail.com
        Regression: No

The EXTENDED COPY SCSI command (XCOPY) is used extensively by VMware ESX
initiators, to offload to the iSCSI target, the process of copying data between
a source and destination LU region.
XCOPY is also supported by other initiators, such as ddpt
(http://sg.danny.cz/sg/ddpt.html), libiscsi, etc.

The XCOPY specification in SPC-4 (revision 37) states that the XCOPY source and
destination device(s) should be derived from the copy source and copy
destination descriptor (CSCD) IDs in the XCOPY segment descriptor. The CSCD IDs
are generally (for block -> block copies), indexes into the corresponding CSCD
list, i.e.

=================================
XCOPY Header    
=================================
CSCD List
- entry 0
  + LU ID
- entry 2
  + LU ID
=================================
Segment Descriptor List
- segment 0
  + src CSCD ID = (CSCD entry 0)
  + dest CSCD ID = (CSCD entry 1)
  + len
  + src lba
  + dest lba
=================================

Currently LIO completely ignores the src and dest CSCD IDs in the Segment
Descriptor List, and instead assumes that the first entry in the CSCD list
corresponds to the source, and the second to the destination.

This assumption appears to stand true for XCOPY requests from ESXi initiators.
However, deviation from the spec may break other initiators - it causes a
number of libiscsi tests to fail.

-- 
You are receiving this mail because:
You are the assignee for the bug.

             reply	other threads:[~2016-12-28 17:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-28 17:10 bugzilla-daemon [this message]
2017-01-02  1:20 ` [Bug 191381] LIO ignores XCOPY source and destination descriptor IDs bugzilla-daemon
2017-01-13 10:42 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-191381-11613@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.