All of lore.kernel.org
 help / color / mirror / Atom feed
* [Bug 198123] New: Console is the wrong color at boot with radeon 6670
@ 2017-12-10 16:53 bugzilla-daemon
  2017-12-11  3:56 ` [Bug 198123] " bugzilla-daemon
                   ` (52 more replies)
  0 siblings, 53 replies; 62+ messages in thread
From: bugzilla-daemon @ 2017-12-10 16:53 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

            Bug ID: 198123
           Summary: Console is the wrong color at boot with radeon 6670
           Product: Drivers
           Version: 2.5
    Kernel Version: 4.14.3
          Hardware: Intel
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Video(DRI - non Intel)
          Assignee: drivers_video-dri@kernel-bugs.osdl.org
          Reporter: dpirate@metalpunks.info
        Regression: Yes

After upgrading to kernel 4.14.3, at boot the console screen has a white
background with light gray characters that are barely readable. After X starts,
the problem disappears. But if you don't start X, it stays that way. Rolling
back to 4.13.16 fixes the problem. Same problem with 4.14.4.

$lspci
00:00.0 Host bridge: Advanced Micro Devices, Inc. [AMD] RS880 Host Bridge
00:02.0 PCI bridge: Advanced Micro Devices, Inc. [AMD] RS780 PCI to PCI bridge
(ext gfx port 0)
00:06.0 PCI bridge: Advanced Micro Devices, Inc. [AMD] RS780 PCI to PCI bridge
(PCIE port 2)
00:07.0 PCI bridge: Advanced Micro Devices, Inc. [AMD] RS780/RS880 PCI to PCI
bridge (PCIE port 3)
00:11.0 SATA controller: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 SATA Controller [AHCI mode] (rev 40)
00:12.0 USB controller: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB OHCI0 Controller
00:12.2 USB controller: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB EHCI Controller
00:13.0 USB controller: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB OHCI0 Controller
00:13.2 USB controller: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB EHCI Controller
00:14.0 SMBus: Advanced Micro Devices, Inc. [AMD/ATI] SBx00 SMBus Controller
(rev 41)
00:14.2 Audio device: Advanced Micro Devices, Inc. [AMD/ATI] SBx00 Azalia
(Intel HDA) (rev 40)
00:14.3 ISA bridge: Advanced Micro Devices, Inc. [AMD/ATI] SB7x0/SB8x0/SB9x0
LPC host controller (rev 40)
00:14.4 PCI bridge: Advanced Micro Devices, Inc. [AMD/ATI] SBx00 PCI to PCI
Bridge (rev 40)
00:14.5 USB controller: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB OHCI2 Controller
00:16.0 USB controller: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB OHCI0 Controller
00:16.2 USB controller: Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB EHCI Controller
00:18.0 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor
HyperTransport Configuration
00:18.1 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor
Address Map
00:18.2 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor
DRAM Controller
00:18.3 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor
Miscellaneous Control
00:18.4 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor
Link Control
01:00.0 USB controller: Fresco Logic FL1000G USB 3.0 Host Controller (rev 01)
02:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Turks
XT [Radeon HD 6670/7670]
02:00.1 Audio device: Advanced Micro Devices, Inc. [AMD/ATI] Turks HDMI Audio
[Radeon HD 6500/6600 / 6700M Series]
03:00.0 Ethernet controller: Intel Corporation 82572EI Gigabit Ethernet
Controller (Copper) (rev 06)

The Radeon is a 6670.

$ cat /proc/cpuinfo
processor : 0
vendor_id : AuthenticAMD
cpu family : 16
model : 6
model name : AMD Athlon(tm) II X2 240e Processor
stepping : 2
microcode : 0x10000c7
cpu MHz : 800.000
cache size : 1024 KB
physical id : 0
siblings : 2
core id : 0
cpu cores : 2
apicid : 0
initial apicid : 0
fpu : yes
fpu_exception : yes
cpuid level : 5
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36
clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm
3dnowext 3dnow constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid pni
monitor cx16 popcnt lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a
misalignsse 3dnowprefetch osvw ibs skinit wdt hw_pstate vmmcall npt lbrv
svm_lock nrip_save
bugs : tlb_mmatch apic_c1e fxsave_leak sysret_ss_attrs null_seg amd_e400
bogomips : 5612.22
TLB size : 1024 4K pages
clflush size : 64
cache_alignment : 64
address sizes : 48 bits physical, 48 bits virtual
power management: ts ttp tm stc 100mhzsteps hwpstate

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
@ 2017-12-11  3:56 ` bugzilla-daemon
  2017-12-11 23:31 ` bugzilla-daemon
                   ` (51 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2017-12-11  3:56 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

Alex Deucher (alexdeucher@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexdeucher@gmail.com

--- Comment #1 from Alex Deucher (alexdeucher@gmail.com) ---
Can you bisect?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
  2017-12-11  3:56 ` [Bug 198123] " bugzilla-daemon
@ 2017-12-11 23:31 ` bugzilla-daemon
  2017-12-12 23:11 ` bugzilla-daemon
                   ` (50 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2017-12-11 23:31 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #2 from Deposite Pirate (dpirate@metalpunks.info) ---
(In reply to Alex Deucher from comment #1)
> Can you bisect?

Hi,

I'm working on it. I haven't compiled a kernel in a few years so I had to set
up all this stuff. This PC is quite slow, so it might take me a few days before
I find the commit with the problem.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
  2017-12-11  3:56 ` [Bug 198123] " bugzilla-daemon
  2017-12-11 23:31 ` bugzilla-daemon
@ 2017-12-12 23:11 ` bugzilla-daemon
  2017-12-12 23:26 ` bugzilla-daemon
                   ` (49 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2017-12-12 23:11 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #3 from Deposite Pirate (dpirate@metalpunks.info) ---
Ok, I found the commit:

commit 2040c47361646d18b9832fd930d2a025da002a57 (HEAD -> master)
Merge: 3154b133711f 37899a525491
Author: Dave Airlie <airlied@redhat.com>
Date:   Fri Aug 18 05:30:53 2017 +1000

    Merge branch 'drm-next-4.14' of git://people.freedesktop.org/~agd5f/linux
into drm-next

    More features for 4.14.  Nothing too major here.  I have a few more
additional
    patches for large page support in vega10 among other things, but they
require
    some resevation object patches from drm-misc-next, so I'll send that
request
    once you've pulled the latest drm-misc-next.  Highlights:
    - Fixes for ACP audio on stoney
    - SR-IOV fixes for vega10
    - various powerplay fixes
    - lots of code clean up

    * 'drm-next-4.14' of git://people.freedesktop.org/~agd5f/linux: (62
commits)
      drm/amdgpu/gfx7: fix function name
      drm/amd/amdgpu: Disabling Power Gating for Stoney platform
      drm/amd/amdgpu: Added a quirk for Stoney platform
      drm/amdgpu: jt_size was wrongly counted twice
      drm/amdgpu: fix missing endian-safe guard
      drm/amdgpu: ignore digest_size when loading sdma fw for raven
      drm/amdgpu: Uninitialized variable in amdgpu_ttm_backend_bind()
      drm/amd/powerplay: fix coding style in hwmgr.c
      drm/amd/powerplay: refine dmesg info under powerplay.
      drm/amdgpu: don't finish the ring if not initialized
      drm/radeon: Fix preferred typo
      drm/amdgpu: Fix preferred typo
      drm/radeon: Fix stolen typo
      drm/amdgpu: Fix stolen typo
      drm/amd/powerplay: fix coccinelle warnings in vega10_hwmgr.c
      drm/amdgpu: set gfx_v9_0_ip_funcs as static
      drm/radeon: switch to drm_*{get,put} helpers
      drm/amdgpu: switch to drm_*{get,put} helpers
      drm/amd/powerplay: add CZ profile support
      drm/amd/powerplay: fix PSI not enabled by kmd

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (2 preceding siblings ...)
  2017-12-12 23:11 ` bugzilla-daemon
@ 2017-12-12 23:26 ` bugzilla-daemon
  2017-12-12 23:33 ` bugzilla-daemon
                   ` (48 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2017-12-12 23:26 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

Felix Schwarz (felix.schwarz@oss.schwarz.eu) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |felix.schwarz@oss.schwarz.e
                   |                            |u

--- Comment #4 from Felix Schwarz (felix.schwarz@oss.schwarz.eu) ---
Unfortunately a merge commit is almost never the right bisection result. Did
you use git for bisecting? Can you share your bisect log? Probably you need to
go on, marking commit 2040c473 as "bad" and git bisect will give you more
commits to try.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (3 preceding siblings ...)
  2017-12-12 23:26 ` bugzilla-daemon
@ 2017-12-12 23:33 ` bugzilla-daemon
  2017-12-12 23:48 ` bugzilla-daemon
                   ` (47 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2017-12-12 23:33 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #5 from Deposite Pirate (dpirate@metalpunks.info) ---
I just cloned linux-stable, did git log, searched for "radeon" and built the
revision before this commit, tested it and then I built the revision with this
commit and tested it. Is there another linux repository I need to clone where
this commit is broken into smaller pieces? I don't have bisect log.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (4 preceding siblings ...)
  2017-12-12 23:33 ` bugzilla-daemon
@ 2017-12-12 23:48 ` bugzilla-daemon
  2017-12-13  0:59 ` bugzilla-daemon
                   ` (46 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2017-12-12 23:48 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #6 from Felix Schwarz (felix.schwarz@oss.schwarz.eu) ---
Ideally you use Linus' git repo:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/

As you mentioned in your first post you experienced problems when upgrading
from 4.13.16 -> 4.14.3 so most likely something changed in the main development
period of 4.14 for you. The merge commit 2040c473 you found supports that
theory.

Now you need to start actually bisecting. Just google for "git bisect". There
is a lot of blog posts, tutorials etc for it. (Maybe
https://stackoverflow.com/a/4714297/138526 helps you)

As a start you can mark the merge commit and its predecessor as bad/good and
git will take you from there. You will need to compile quite a few kernels and
test them (way more than 2, usually 10-20 kernels).

A common mistake is to mark a non-bootable or otherwise broken version as
"bad". Only mark kernels as "bad" if they clearly have the problem you
described in your report. If you can't test a specific version, use "git bisect
skip". Use "good" if you are sure that a version is ok.

Oh, btw: I recommend testing the most recent 4.15 rc (or even git master) to
check the problem is still present. If it is fixed in a the current development
version probably the easiest way for you is to ride the leading edge. Of course
you can bisect anyway, maybe the patch can be backported to 4.14.

Happy compiling.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (5 preceding siblings ...)
  2017-12-12 23:48 ` bugzilla-daemon
@ 2017-12-13  0:59 ` bugzilla-daemon
  2017-12-16  1:41 ` bugzilla-daemon
                   ` (45 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2017-12-13  0:59 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #7 from Deposite Pirate (dpirate@metalpunks.info) ---
Thanks for the explanation. I think I understand how this works now. I was
afraid I would not be able to use the Arch PKGBUILD for the kernel together
with git bisect. But it turns out I can, which makes things way simpler for me.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (6 preceding siblings ...)
  2017-12-13  0:59 ` bugzilla-daemon
@ 2017-12-16  1:41 ` bugzilla-daemon
  2017-12-18 11:37   ` Michel Dänzer
  2017-12-28  9:35 ` bugzilla-daemon
                   ` (44 subsequent siblings)
  52 siblings, 1 reply; 62+ messages in thread
From: bugzilla-daemon @ 2017-12-16  1:41 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #8 from Deposite Pirate (dpirate@metalpunks.info) ---
Ok, I went through all the git bisect process. Here are the results:

git bisect start
# bad: [a638349bf6c29433b938141f99225b160551ff48] Merge branch 'for-4.15-fixes'
of git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu
git bisect bad a638349bf6c29433b938141f99225b160551ff48
# good: [47b4a457e4cc816b3fdd2ee55c65fda8ea6de051] alarmtimer: Fix unavailable
wake-up source in sysfs
git bisect good 47b4a457e4cc816b3fdd2ee55c65fda8ea6de051
# bad: [2040c47361646d18b9832fd930d2a025da002a57] Merge branch 'drm-next-4.14'
of git://people.freedesktop.org/~agd5f/linux into drm-next
git bisect bad 2040c47361646d18b9832fd930d2a025da002a57
# good: [5771a8c08880cdca3bfb4a3fc6d309d6bba20877] Linux v4.13-rc1
git bisect good 5771a8c08880cdca3bfb4a3fc6d309d6bba20877
# bad: [37899a5254917e17418bbb23086d55e38faaa659] drm/amdgpu/gfx7: fix function
name
git bisect bad 37899a5254917e17418bbb23086d55e38faaa659
# good: [520eccdfe187591a51ea9ab4c1a024ae4d0f68d9] Linux 4.13-rc2
git bisect good 520eccdfe187591a51ea9ab4c1a024ae4d0f68d9
# bad: [9a61c54b9bff88e692ac7b1245546539ac5274a1] drm/rockchip: vop: group vop
registers
git bisect bad 9a61c54b9bff88e692ac7b1245546539ac5274a1
# bad: [8572636e45167adbdb997fe5c43122bf77fd2291] drm/nouveau: Handle
drm_atomic_helper_swap_state failure
git bisect bad 8572636e45167adbdb997fe5c43122bf77fd2291
# good: [05ccf211efbb6c8b5da2b5fda4f9399a7bc0db2e] drm: ttm: virtio-gpu:
dma-buf: Constify ttm_place structures.
git bisect good 05ccf211efbb6c8b5da2b5fda4f9399a7bc0db2e
# bad: [30ea752146e147c5a1f0367aa5303929f7bfd697] drm/imx: Use atomic iterator
macros
git bisect bad 30ea752146e147c5a1f0367aa5303929f7bfd697
# bad: [dd2adf743bc47ac14999bb375fed390af6524f29] drm/bridge: analogix-anx78xx:
clean up drm_bridge_add call
git bisect bad dd2adf743bc47ac14999bb375fed390af6524f29
# good: [bdac4a052a47920eeae22441ab608612dc0ef4e5] drm/fb-helper: Push locking
in fb_is_bound
git bisect good bdac4a052a47920eeae22441ab608612dc0ef4e5
# good: [6b7dc6e9f82615836b389cb5f806914048b132cd] drm/fb-helper: Split dpms
handling into legacy and atomic paths
git bisect good 6b7dc6e9f82615836b389cb5f806914048b132cd
# bad: [a3562a0e471df02234f74ab4e0625042f44a76e9] drm/fb-helper: keep the
.gamma_store updated in drm_fb_helper_setcmap
git bisect bad a3562a0e471df02234f74ab4e0625042f44a76e9
# bad: [b8e2b0199cc377617dc238f5106352c06dcd3fa2] drm/fb-helper: factor out
pseudo-palette
git bisect bad b8e2b0199cc377617dc238f5106352c06dcd3fa2
# first bad commit: [b8e2b0199cc377617dc238f5106352c06dcd3fa2] drm/fb-helper:
factor out pseudo-palette

b8e2b0199cc377617dc238f5106352c06dcd3fa2 is the first bad commit
commit b8e2b0199cc377617dc238f5106352c06dcd3fa2
Author: Peter Rosin <peda@axentia.se>
Date:   Tue Jul 4 12:36:57 2017 +0200

    drm/fb-helper: factor out pseudo-palette

    The pseudo-palette has nothing to do with the crtc, so move it
    out of the crtc loop and update the palette once, then break out
    early.

    Signed-off-by: Peter Rosin <peda@axenita.se>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Link:
http://patchwork.freedesktop.org/patch/msgid/1499164632-5582-2-git-send-email-peda@axentia.se

:040000 040000 a8c2650554e199fee994ac63c2700c73ba2ecffe
7f72ed414efadd77ef1d718e7477475c4ba1127d M      drivers

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* Re: [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-16  1:41 ` bugzilla-daemon
@ 2017-12-18 11:37   ` Michel Dänzer
  2017-12-18 13:50     ` Peter Rosin
  0 siblings, 1 reply; 62+ messages in thread
From: Michel Dänzer @ 2017-12-18 11:37 UTC (permalink / raw)
  To: dpirate, Peter Rosin; +Cc: dri-devel


Following up by e-mail, since I can't find Peter Rosin in the kernel
bugzilla.


On 2017-12-16 02:41 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=198123
> 
> --- Comment #8 from Deposite Pirate (dpirate@metalpunks.info) ---
> Ok, I went through all the git bisect process. Here are the results:
> 
> [...]
> 
> b8e2b0199cc377617dc238f5106352c06dcd3fa2 is the first bad commit
> commit b8e2b0199cc377617dc238f5106352c06dcd3fa2
> Author: Peter Rosin <peda@axentia.se>
> Date:   Tue Jul 4 12:36:57 2017 +0200
> 
>     drm/fb-helper: factor out pseudo-palette
> 
>     The pseudo-palette has nothing to do with the crtc, so move it
>     out of the crtc loop and update the palette once, then break out
>     early.
> 
>     Signed-off-by: Peter Rosin <peda@axenita.se>
>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>     Link:
> http://patchwork.freedesktop.org/patch/msgid/1499164632-5582-2-git-send-email-peda@axentia.se
> 
> :040000 040000 a8c2650554e199fee994ac63c2700c73ba2ecffe
> 7f72ed414efadd77ef1d718e7477475c4ba1127d M      drivers

My guess would be this is because fb_helper->funcs->gamma_set is no
longer called from drm_fb_helper_setcmap in the FB_VISUAL_TRUECOLOR case
(was previously called via setcolreg).

Peter, how is the hardware CLUT intended to be initialized in that case
with this change?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* Re: [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-18 11:37   ` Michel Dänzer
@ 2017-12-18 13:50     ` Peter Rosin
  2017-12-19 10:48       ` Michel Dänzer
  0 siblings, 1 reply; 62+ messages in thread
From: Peter Rosin @ 2017-12-18 13:50 UTC (permalink / raw)
  To: Michel Dänzer, dpirate; +Cc: dri-devel

On 2017-12-18 12:37, Michel Dänzer wrote:
> 
> Following up by e-mail, since I can't find Peter Rosin in the kernel
> bugzilla.
> 
> 
> On 2017-12-16 02:41 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
>> https://bugzilla.kernel.org/show_bug.cgi?id=198123
>>
>> --- Comment #8 from Deposite Pirate (dpirate@metalpunks.info) ---
>> Ok, I went through all the git bisect process. Here are the results:
>>
>> [...]
>>
>> b8e2b0199cc377617dc238f5106352c06dcd3fa2 is the first bad commit
>> commit b8e2b0199cc377617dc238f5106352c06dcd3fa2
>> Author: Peter Rosin <peda@axentia.se>
>> Date:   Tue Jul 4 12:36:57 2017 +0200
>>
>>     drm/fb-helper: factor out pseudo-palette
>>
>>     The pseudo-palette has nothing to do with the crtc, so move it
>>     out of the crtc loop and update the palette once, then break out
>>     early.
>>
>>     Signed-off-by: Peter Rosin <peda@axenita.se>
>>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>     Link:
>> http://patchwork.freedesktop.org/patch/msgid/1499164632-5582-2-git-send-email-peda@axentia.se
>>
>> :040000 040000 a8c2650554e199fee994ac63c2700c73ba2ecffe
>> 7f72ed414efadd77ef1d718e7477475c4ba1127d M      drivers
> 
> My guess would be this is because fb_helper->funcs->gamma_set is no
> longer called from drm_fb_helper_setcmap in the FB_VISUAL_TRUECOLOR case
> (was previously called via setcolreg).

No, that's not right, fb_helper->funcs->gamma_set() wasn't called for the
FB_VISUAL_TRUECOLOR case before the commit either.

However, crtc_funcs->load_lut() was called, but that operation is now
gone in a later cleanup. However#2, that ->load_lut() did not use anything
that was provided in the call to drm_fb_helper_setcmap, since the load_lut
implementations generally didn't look at the pseudo_palette variable. So,
the now-missing ->load_lut() call probably just reloaded the clut?

> Peter, how is the hardware CLUT intended to be initialized in that case
> with this change?

I thought that truecolor visuals didn't have any hardware clut. Seems
like an easy enough mistake to make, and I still don't get it...

I don't know what the correct behavior is since I don't get what is
going on with that, but I assume it should be fairly easy to rearrange
things so that a write to the hw clut is triggered.

Are we sure that FB_VISUAL_TRUECOLOR is involved at all? Why? Or is that
just a red herring?

Cheers,
Peter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* Re: [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-18 13:50     ` Peter Rosin
@ 2017-12-19 10:48       ` Michel Dänzer
  2017-12-22 15:34         ` Michel Dänzer
  2018-01-07 19:14         ` Deposite Pirate
  0 siblings, 2 replies; 62+ messages in thread
From: Michel Dänzer @ 2017-12-19 10:48 UTC (permalink / raw)
  To: Peter Rosin, dpirate; +Cc: dri-devel

On 2017-12-18 02:50 PM, Peter Rosin wrote:
> On 2017-12-18 12:37, Michel Dänzer wrote:
>>
>> Following up by e-mail, since I can't find Peter Rosin in the kernel
>> bugzilla.
>>
>>
>> On 2017-12-16 02:41 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=198123
>>>
>>> --- Comment #8 from Deposite Pirate (dpirate@metalpunks.info) ---
>>> Ok, I went through all the git bisect process. Here are the results:
>>>
>>> [...]
>>>
>>> b8e2b0199cc377617dc238f5106352c06dcd3fa2 is the first bad commit
>>> commit b8e2b0199cc377617dc238f5106352c06dcd3fa2
>>> Author: Peter Rosin <peda@axentia.se>
>>> Date:   Tue Jul 4 12:36:57 2017 +0200
>>>
>>>     drm/fb-helper: factor out pseudo-palette
>>>
>>>     The pseudo-palette has nothing to do with the crtc, so move it
>>>     out of the crtc loop and update the palette once, then break out
>>>     early.
>>>
>>>     Signed-off-by: Peter Rosin <peda@axenita.se>
>>>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>>     Link:
>>> http://patchwork.freedesktop.org/patch/msgid/1499164632-5582-2-git-send-email-peda@axentia.se
>>>
>>> :040000 040000 a8c2650554e199fee994ac63c2700c73ba2ecffe
>>> 7f72ed414efadd77ef1d718e7477475c4ba1127d M      drivers
>>
>> My guess would be this is because fb_helper->funcs->gamma_set is no
>> longer called from drm_fb_helper_setcmap in the FB_VISUAL_TRUECOLOR case
>> (was previously called via setcolreg).
> 
> No, that's not right, fb_helper->funcs->gamma_set() wasn't called for the
> FB_VISUAL_TRUECOLOR case before the commit either.
> 
> However, crtc_funcs->load_lut() was called, but that operation is now
> gone in a later cleanup. However#2, that ->load_lut() did not use anything
> that was provided in the call to drm_fb_helper_setcmap, since the load_lut
> implementations generally didn't look at the pseudo_palette variable. So,
> the now-missing ->load_lut() call probably just reloaded the clut?

Makes sense.


>> Peter, how is the hardware CLUT intended to be initialized in that case
>> with this change?
> 
> I thought that truecolor visuals didn't have any hardware clut.

Maybe not as far as fbdev is concerned, but I don't know that there's
even a way to disable the CLUT in the KMS API.


> Are we sure that FB_VISUAL_TRUECOLOR is involved at all? Why? Or is that
> just a red herring?

FB_VISUAL_TRUECOLOR seems to be the default used by fbcon, so I assume
it's used in this case as well, but it can be checked with fbcon -i.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* Re: [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-19 10:48       ` Michel Dänzer
@ 2017-12-22 15:34         ` Michel Dänzer
  2018-01-07 19:14         ` Deposite Pirate
  1 sibling, 0 replies; 62+ messages in thread
From: Michel Dänzer @ 2017-12-22 15:34 UTC (permalink / raw)
  To: dpirate; +Cc: Peter Rosin, dri-devel

[-- Attachment #1: Type: text/plain, Size: 2280 bytes --]

On 2017-12-19 11:48 AM, Michel Dänzer wrote:
> On 2017-12-18 02:50 PM, Peter Rosin wrote:
>> On 2017-12-18 12:37, Michel Dänzer wrote:
>>>
>>> Following up by e-mail, since I can't find Peter Rosin in the kernel
>>> bugzilla.
>>>
>>>
>>> On 2017-12-16 02:41 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
>>>> https://bugzilla.kernel.org/show_bug.cgi?id=198123
>>>>
>>>> --- Comment #8 from Deposite Pirate (dpirate@metalpunks.info) ---
>>>> Ok, I went through all the git bisect process. Here are the results:
>>>>
>>>> [...]
>>>>
>>>> b8e2b0199cc377617dc238f5106352c06dcd3fa2 is the first bad commit
>>>> commit b8e2b0199cc377617dc238f5106352c06dcd3fa2
>>>> Author: Peter Rosin <peda@axentia.se>
>>>> Date:   Tue Jul 4 12:36:57 2017 +0200
>>>>
>>>>     drm/fb-helper: factor out pseudo-palette
>>>>
>>>>     The pseudo-palette has nothing to do with the crtc, so move it
>>>>     out of the crtc loop and update the palette once, then break out
>>>>     early.
>>>>
>>>>     Signed-off-by: Peter Rosin <peda@axenita.se>
>>>>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>>>     Link:
>>>> http://patchwork.freedesktop.org/patch/msgid/1499164632-5582-2-git-send-email-peda@axentia.se
>>>>
>>>> :040000 040000 a8c2650554e199fee994ac63c2700c73ba2ecffe
>>>> 7f72ed414efadd77ef1d718e7477475c4ba1127d M      drivers
>>>
>>> My guess would be this is because fb_helper->funcs->gamma_set is no
>>> longer called from drm_fb_helper_setcmap in the FB_VISUAL_TRUECOLOR case
>>> (was previously called via setcolreg).
>>
>> No, that's not right, fb_helper->funcs->gamma_set() wasn't called for the
>> FB_VISUAL_TRUECOLOR case before the commit either.
>>
>> However, crtc_funcs->load_lut() was called, but that operation is now
>> gone in a later cleanup. However#2, that ->load_lut() did not use anything
>> that was provided in the call to drm_fb_helper_setcmap, since the load_lut
>> implementations generally didn't look at the pseudo_palette variable. So,
>> the now-missing ->load_lut() call probably just reloaded the clut?
> 
> Makes sense.

"Deposite Pirate", do the attached (only compile tested) patches work?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-drm-radeon-Call-radeon_crtc_load_lut-from-radeon_crt.patch --]
[-- Type: text/x-patch; name="0001-drm-radeon-Call-radeon_crtc_load_lut-from-radeon_crt.patch", Size: 1126 bytes --]

From f683369b876b5198b0099d66ad83997455d9040f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michel=20D=C3=A4nzer?= <michel.daenzer@amd.com>
Date: Fri, 22 Dec 2017 16:27:09 +0100
Subject: [PATCH 1/2] drm/radeon: Call radeon_crtc_load_lut from
 radeon_crtc_init
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Cc: stable@vger.kernel.org
Fixes: b8e2b0199cc3 "drm/fb-helper: factor out pseudo-palette"
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
 drivers/gpu/drm/radeon/radeon_display.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index ddfe91efa61e..d403be4afd24 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -707,6 +707,8 @@ static void radeon_crtc_init(struct drm_device *dev, int index)
 		radeon_atombios_init_crtc(dev, radeon_crtc);
 	else
 		radeon_legacy_init_crtc(dev, radeon_crtc);
+
+	radeon_crtc_load_lut(&radeon_crtc->base);
 }
 
 static const char *encoder_names[38] = {
-- 
2.15.1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-drm-radeon-Remove-unused-lut_r-g-b-arrays.patch --]
[-- Type: text/x-patch; name="0002-drm-radeon-Remove-unused-lut_r-g-b-arrays.patch", Size: 1977 bytes --]

From e071d7293a30bf84677c15a30d91872b7439ce70 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michel=20D=C3=A4nzer?= <michel.daenzer@amd.com>
Date: Fri, 22 Dec 2017 16:31:54 +0100
Subject: [PATCH 2/2] drm/radeon: Remove unused lut_r/g/b arrays
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
 drivers/gpu/drm/radeon/radeon_display.c | 7 -------
 drivers/gpu/drm/radeon/radeon_mode.h    | 1 -
 2 files changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index d403be4afd24..0519c6162381 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -668,7 +668,6 @@ static void radeon_crtc_init(struct drm_device *dev, int index)
 {
 	struct radeon_device *rdev = dev->dev_private;
 	struct radeon_crtc *radeon_crtc;
-	int i;
 
 	radeon_crtc = kzalloc(sizeof(struct radeon_crtc) + (RADEONFB_CONN_LIMIT * sizeof(struct drm_connector *)), GFP_KERNEL);
 	if (radeon_crtc == NULL)
@@ -697,12 +696,6 @@ static void radeon_crtc_init(struct drm_device *dev, int index)
 	radeon_crtc->mode_set.num_connectors = 0;
 #endif
 
-	for (i = 0; i < 256; i++) {
-		radeon_crtc->lut_r[i] = i << 2;
-		radeon_crtc->lut_g[i] = i << 2;
-		radeon_crtc->lut_b[i] = i << 2;
-	}
-
 	if (rdev->is_atom_bios && (ASIC_IS_AVIVO(rdev) || radeon_r4xx_atom))
 		radeon_atombios_init_crtc(dev, radeon_crtc);
 	else
diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/drivers/gpu/drm/radeon/radeon_mode.h
index ca0a7ed28c9b..9b1fe25f624a 100644
--- a/drivers/gpu/drm/radeon/radeon_mode.h
+++ b/drivers/gpu/drm/radeon/radeon_mode.h
@@ -328,7 +328,6 @@ enum radeon_flip_status {
 struct radeon_crtc {
 	struct drm_crtc base;
 	int crtc_id;
-	u16 lut_r[256], lut_g[256], lut_b[256];
 	bool enabled;
 	bool can_tile;
 	bool cursor_out_of_bounds;
-- 
2.15.1


[-- Attachment #4: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (7 preceding siblings ...)
  2017-12-16  1:41 ` bugzilla-daemon
@ 2017-12-28  9:35 ` bugzilla-daemon
  2018-01-11 10:11 ` bugzilla-daemon
                   ` (43 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2017-12-28  9:35 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

Bill Fraser (bill.fraser@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bill.fraser@gmail.com

--- Comment #9 from Bill Fraser (bill.fraser@gmail.com) ---
I'm seeing a very similar problem with the 'ast' driver: a black-on-black text
console, with only red-colored text visible -- luckily I have a systemd unit
that fails on boot with a red message, which I can see scrolling up the screen
as it boots, but nothing else.

I've bisected it back to the same commit as Deposite Pirate above,
[b8e2b0199cc377617dc238f5106352c06dcd3fa2].

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* Re: [Bug 198123] Console is the wrong color at boot with radeon  6670
  2017-12-19 10:48       ` Michel Dänzer
  2017-12-22 15:34         ` Michel Dänzer
@ 2018-01-07 19:14         ` Deposite Pirate
  2018-01-10 12:15           ` Daniel Vetter
  1 sibling, 1 reply; 62+ messages in thread
From: Deposite Pirate @ 2018-01-07 19:14 UTC (permalink / raw)
  To: Michel Dänzer; +Cc: Peter Rosin, dri-devel

December 22, 2017 4:35 PM, "Michel Dänzer" <michel@daenzer.net> wrote:

> "Deposite Pirate", do the attached (only compile tested) patches work?

Hi,

Sorry for the delay. I was not at home for a while. So, I've compiled and booted a kernel with both
of these patches and
the issue is still present.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* Re: [Bug 198123] Console is the wrong color at boot with radeon 6670
  2018-01-07 19:14         ` Deposite Pirate
@ 2018-01-10 12:15           ` Daniel Vetter
  2018-01-11  8:57             ` Daniel Vetter
  2018-01-11  9:09             ` Michel Dänzer
  0 siblings, 2 replies; 62+ messages in thread
From: Daniel Vetter @ 2018-01-10 12:15 UTC (permalink / raw)
  To: Deposite Pirate; +Cc: Michel Dänzer, Peter Rosin, dri-devel

On Sun, Jan 07, 2018 at 07:14:41PM +0000, Deposite Pirate wrote:
> December 22, 2017 4:35 PM, "Michel Dänzer" <michel@daenzer.net> wrote:
> 
> > "Deposite Pirate", do the attached (only compile tested) patches work?
> 
> Hi,
> 
> Sorry for the delay. I was not at home for a while. So, I've compiled and booted a kernel with both
> of these patches and
> the issue is still present.

Below a revised version of Michel's first patch. This one should work I
hope.
-Daniel

diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index d22f4b6a8828..dc0abdf8be00 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -213,9 +213,6 @@ void radeon_crtc_load_lut(struct drm_crtc *crtc)
 	struct drm_device *dev = crtc->dev;
 	struct radeon_device *rdev = dev->dev_private;
 
-	if (!crtc->enabled)
-		return;
-
 	if (ASIC_IS_DCE5(rdev))
 		dce5_crtc_load_lut(crtc);
 	else if (ASIC_IS_DCE4(rdev))
@@ -702,6 +699,8 @@ static void radeon_crtc_init(struct drm_device *dev, int index)
 		radeon_atombios_init_crtc(dev, radeon_crtc);
 	else
 		radeon_legacy_init_crtc(dev, radeon_crtc);
+
+	radeon_crtc_load_lut(&radeon_crtc->base);
 }
 
 static const char *encoder_names[38] = {
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 62+ messages in thread

* Re: [Bug 198123] Console is the wrong color at boot with radeon 6670
  2018-01-10 12:15           ` Daniel Vetter
@ 2018-01-11  8:57             ` Daniel Vetter
  2018-01-11  9:09             ` Michel Dänzer
  1 sibling, 0 replies; 62+ messages in thread
From: Daniel Vetter @ 2018-01-11  8:57 UTC (permalink / raw)
  To: Deposite Pirate; +Cc: Michel Dänzer, Peter Rosin, dri-devel

On Wed, Jan 10, 2018 at 01:15:22PM +0100, Daniel Vetter wrote:
> On Sun, Jan 07, 2018 at 07:14:41PM +0000, Deposite Pirate wrote:
> > December 22, 2017 4:35 PM, "Michel Dänzer" <michel@daenzer.net> wrote:
> > 
> > > "Deposite Pirate", do the attached (only compile tested) patches work?
> > 
> > Hi,
> > 
> > Sorry for the delay. I was not at home for a while. So, I've compiled and booted a kernel with both
> > of these patches and
> > the issue is still present.
> 
> Below a revised version of Michel's first patch. This one should work I

Hi Deposite Pirate, can you pls test this version of Michel's first patch?

Thanks, Daniel

> hope.
> -Daniel
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index d22f4b6a8828..dc0abdf8be00 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -213,9 +213,6 @@ void radeon_crtc_load_lut(struct drm_crtc *crtc)
>  	struct drm_device *dev = crtc->dev;
>  	struct radeon_device *rdev = dev->dev_private;
>  
> -	if (!crtc->enabled)
> -		return;
> -
>  	if (ASIC_IS_DCE5(rdev))
>  		dce5_crtc_load_lut(crtc);
>  	else if (ASIC_IS_DCE4(rdev))
> @@ -702,6 +699,8 @@ static void radeon_crtc_init(struct drm_device *dev, int index)
>  		radeon_atombios_init_crtc(dev, radeon_crtc);
>  	else
>  		radeon_legacy_init_crtc(dev, radeon_crtc);
> +
> +	radeon_crtc_load_lut(&radeon_crtc->base);
>  }
>  
>  static const char *encoder_names[38] = {
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* Re: [Bug 198123] Console is the wrong color at boot with radeon 6670
  2018-01-10 12:15           ` Daniel Vetter
  2018-01-11  8:57             ` Daniel Vetter
@ 2018-01-11  9:09             ` Michel Dänzer
  1 sibling, 0 replies; 62+ messages in thread
From: Michel Dänzer @ 2018-01-11  9:09 UTC (permalink / raw)
  To: Daniel Vetter, Deposite Pirate; +Cc: Peter Rosin, dri-devel

On 2018-01-10 01:15 PM, Daniel Vetter wrote:
> On Sun, Jan 07, 2018 at 07:14:41PM +0000, Deposite Pirate wrote:
>> December 22, 2017 4:35 PM, "Michel Dänzer" <michel@daenzer.net> wrote:
>>
>>> "Deposite Pirate", do the attached (only compile tested) patches work?
>>
>> Hi,
>>
>> Sorry for the delay. I was not at home for a while. So, I've compiled and booted a kernel with both
>> of these patches and
>> the issue is still present.
> 
> Below a revised version of Michel's first patch. This one should work I
> hope.
> -Daniel
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index d22f4b6a8828..dc0abdf8be00 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -213,9 +213,6 @@ void radeon_crtc_load_lut(struct drm_crtc *crtc)
>  	struct drm_device *dev = crtc->dev;
>  	struct radeon_device *rdev = dev->dev_private;
>  
> -	if (!crtc->enabled)
> -		return;
> -
>  	if (ASIC_IS_DCE5(rdev))
>  		dce5_crtc_load_lut(crtc);
>  	else if (ASIC_IS_DCE4(rdev))

Good catch, thanks Daniel. FWIW though, I'd prefer this to be a separate
patch, in case it causes any regressions. But let's wait for test
results first.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (8 preceding siblings ...)
  2017-12-28  9:35 ` bugzilla-daemon
@ 2018-01-11 10:11 ` bugzilla-daemon
  2018-01-12  8:46 ` bugzilla-daemon
                   ` (42 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-11 10:11 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

Daniel Vetter (daniel@ffwll.ch) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel@ffwll.ch

--- Comment #10 from Daniel Vetter (daniel@ffwll.ch) ---
Created attachment 273531
  --> https://bugzilla.kernel.org/attachment.cgi?id=273531&action=edit
test patch on top of b8e2b0199cc377617dc238f5106352c06dcd3fa2

- is the red message correct, or maybe also inverted/funny?
- on top of b8e2b0199cc377617dc238f5106352c06dcd3fa2 please try the attached
diff

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (9 preceding siblings ...)
  2018-01-11 10:11 ` bugzilla-daemon
@ 2018-01-12  8:46 ` bugzilla-daemon
  2018-01-12  9:50 ` bugzilla-daemon
                   ` (41 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-12  8:46 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #11 from Bill Fraser (bill.fraser@gmail.com) ---
- The red color looks to be the right shade, but it's hard to say without any
other colors to reference it against.

- With that patch, loading the 'ast' driver results in screen corruption and
the kernel hard locks up, with not even any panic message on the serial
console. :(

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (10 preceding siblings ...)
  2018-01-12  8:46 ` bugzilla-daemon
@ 2018-01-12  9:50 ` bugzilla-daemon
  2018-01-12 21:12 ` bugzilla-daemon
                   ` (40 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-12  9:50 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #12 from Daniel Vetter (daniel@ffwll.ch) ---
Created attachment 273553
  --> https://bugzilla.kernel.org/attachment.cgi?id=273553&action=edit
fix of-by-one, or what looks like one

This is another theory that crossed my mind. Please test both this patch here
(on latest upstream) and the previous patch on the first bad commit, I'd like
to know the outcome of both experiments.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (11 preceding siblings ...)
  2018-01-12  9:50 ` bugzilla-daemon
@ 2018-01-12 21:12 ` bugzilla-daemon
  2018-01-13  6:50 ` bugzilla-daemon
                   ` (39 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-12 21:12 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

Daniel Vetter (daniel@ffwll.ch) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273531|0                           |1
        is obsolete|                            |
 Attachment #273553|0                           |1
        is obsolete|                            |

--- Comment #13 from Daniel Vetter (daniel@ffwll.ch) ---
Created attachment 273575
  --> https://bugzilla.kernel.org/attachment.cgi?id=273575&action=edit
test patch on top of b8e2b0199cc377617dc238f5106352c06dcd3fa2, v2

Sry my brain must have been offline, first test patch on top of b8e2b was crap,
and the 2nd patch is ... nonsense.

I hope this one has a bit better chances of giving us something to work with.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (12 preceding siblings ...)
  2018-01-12 21:12 ` bugzilla-daemon
@ 2018-01-13  6:50 ` bugzilla-daemon
  2018-01-13 13:34 ` bugzilla-daemon
                   ` (38 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-13  6:50 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #14 from Bill Fraser (bill.fraser@gmail.com) ---
(In reply to Daniel Vetter from comment #13)
> Created attachment 273575 [details]
> test patch on top of b8e2b0199cc377617dc238f5106352c06dcd3fa2, v2

That patch fixes it for me!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (13 preceding siblings ...)
  2018-01-13  6:50 ` bugzilla-daemon
@ 2018-01-13 13:34 ` bugzilla-daemon
  2018-01-14 18:32 ` bugzilla-daemon
                   ` (37 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-13 13:34 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #15 from Deposite Pirate (dpirate@metalpunks.info) ---
As for me, the latest patch on top of HEAD doesn't fix the issue. But maybe I
ought to have applied Michel Dänzer's first patch too?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (14 preceding siblings ...)
  2018-01-13 13:34 ` bugzilla-daemon
@ 2018-01-14 18:32 ` bugzilla-daemon
  2018-01-14 20:40 ` bugzilla-daemon
                   ` (36 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-14 18:32 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #16 from Daniel Vetter (daniel@ffwll.ch) ---
Deposte Pirate, the latest patch I attached (attachment 273575) doesn't even
apply on latest kernels, so I' not sure what exactly you tested. That latest
patch should be tested on top of b8e2b0199cc377617dc238f5106352c06dcd3fa2. Can
you pls link to the exact patch you tested and the git sha1 you applied it to?
Or if possible, upload your entire resulting git tree, with the patch
committed, to github or some place.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (15 preceding siblings ...)
  2018-01-14 18:32 ` bugzilla-daemon
@ 2018-01-14 20:40 ` bugzilla-daemon
  2018-01-16 16:54 ` bugzilla-daemon
                   ` (35 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-14 20:40 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #17 from Daniel Vetter (daniel@ffwll.ch) ---
Created attachment 273609
  --> https://bugzilla.kernel.org/attachment.cgi?id=273609&action=edit
ast patch to load the lut on modesets

This only patches ast, since I'm still not clear what exactly is going on on
the radeon driver. The code looks the same, but the reported test results are
different.

Bill Fraser, can you pls test this?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (16 preceding siblings ...)
  2018-01-14 20:40 ` bugzilla-daemon
@ 2018-01-16 16:54 ` bugzilla-daemon
  2018-01-17 13:48 ` bugzilla-daemon
                   ` (34 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-16 16:54 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #18 from Bill Fraser (bill.fraser@gmail.com) ---
Assuming that patch is meant to be applied directly to b8e2b019 without any
other patches, yep, that works for me.

I tried rebasing onto 4.15-rc8, and it did so without any merge conflicts, so
I'm going to try testing that as well next, and get back to you.

Thanks for looking at this, by the way!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (17 preceding siblings ...)
  2018-01-16 16:54 ` bugzilla-daemon
@ 2018-01-17 13:48 ` bugzilla-daemon
  2018-01-18  5:15 ` bugzilla-daemon
                   ` (33 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-17 13:48 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #19 from Daniel Vetter (daniel@ffwll.ch) ---
Yeah test result on latest -rc8 is needed, since maybe there's some other bug
somewhere ...

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (18 preceding siblings ...)
  2018-01-17 13:48 ` bugzilla-daemon
@ 2018-01-18  5:15 ` bugzilla-daemon
  2018-01-22  8:39 ` bugzilla-daemon
                   ` (32 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-18  5:15 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #20 from Bill Fraser (bill.fraser@gmail.com) ---
Rebased on top of -rc8 also works for me.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (19 preceding siblings ...)
  2018-01-18  5:15 ` bugzilla-daemon
@ 2018-01-22  8:39 ` bugzilla-daemon
  2018-01-22  8:40 ` bugzilla-daemon
                   ` (31 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-22  8:39 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

Paul Tobias (tobias.pal@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobias.pal@gmail.com

--- Comment #21 from Paul Tobias (tobias.pal@gmail.com) ---
I'm having the red console text problem with the ast driver too. It worked fine
with kernel 4.12.12, the problem appeared after upgrading the kernel to
4.14.14. 

The boot process starts with proper console text colours, but right after
kernel modesetting kicks in the white text changes to red. I've used the
"nomodeset" kernel parameter to work around the problem for a while. I'll
attach a picture which illustrates the problem.

I've bisected it to the same commit b8e2b0199cc377617dc238f5106352c06dcd3fa2 as
in comment #8.

Applying the patch from comment #13 on top of
b8e2b0199cc377617dc238f5106352c06dcd3fa2 fixes it for me.

And the patch from comment #17 on top of stable 4.14.14 fixes it too (without
the patch from comment #13).

Unfortunately I don't have a Radeon card, can't test with that.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (20 preceding siblings ...)
  2018-01-22  8:39 ` bugzilla-daemon
@ 2018-01-22  8:40 ` bugzilla-daemon
  2018-01-26  6:50 ` bugzilla-daemon
                   ` (30 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-22  8:40 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #22 from Paul Tobias (tobias.pal@gmail.com) ---
Created attachment 273783
  --> https://bugzilla.kernel.org/attachment.cgi?id=273783&action=edit
Red console text with kernel 4.14 and ast driver

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (21 preceding siblings ...)
  2018-01-22  8:40 ` bugzilla-daemon
@ 2018-01-26  6:50 ` bugzilla-daemon
  2018-01-26 17:54 ` bugzilla-daemon
                   ` (29 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-26  6:50 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #23 from Konstantin Khlebnikov (koct9i@gmail.com) ---
Patch from comment #17 helped for us too.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (22 preceding siblings ...)
  2018-01-26  6:50 ` bugzilla-daemon
@ 2018-01-26 17:54 ` bugzilla-daemon
  2018-01-28 22:55 ` bugzilla-daemon
                   ` (28 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-26 17:54 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #24 from Michel Dänzer (michel@daenzer.net) ---
The radeon driver already calls load_lut when the CRTC dpms hook is called with
DRM_MODE_DPMS_ON. Does the ast patch call load_lut even when DPMS is already
on? If so, I wonder if it doesn't just paper over the real issue, which is that
something changes the LUT but then doesn't call load_lut.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (23 preceding siblings ...)
  2018-01-26 17:54 ` bugzilla-daemon
@ 2018-01-28 22:55 ` bugzilla-daemon
  2018-01-31 10:36 ` bugzilla-daemon
                   ` (27 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-28 22:55 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #25 from Deposite Pirate (dpirate@metalpunks.info) ---
I've recompiled attachment 273575 [details] on top of
b8e2b0199cc377617dc238f5106352c06dcd3fa2 and it doesn't fix the problem either.
Earlier I had compiled this same patch on top of some revision of 4.15rc and it
did apply cleanly.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (24 preceding siblings ...)
  2018-01-28 22:55 ` bugzilla-daemon
@ 2018-01-31 10:36 ` bugzilla-daemon
  2018-01-31 10:44 ` bugzilla-daemon
                   ` (26 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-31 10:36 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #26 from Daniel Vetter (daniel@ffwll.ch) ---
Re #commment 24: crtc_commit is for modesets, the legacy helpers do _not_ call
the DPMS functions in that case. radeon does what every reasonable legacy kms
driver did and calls the dpms function from the prepare/commit hooks, but ast
didn't do that. Hence why my patch fixed ast (but a similar patch for radeon
doesn't make sense).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (25 preceding siblings ...)
  2018-01-31 10:36 ` bugzilla-daemon
@ 2018-01-31 10:44 ` bugzilla-daemon
  2018-01-31 11:14 ` bugzilla-daemon
                   ` (25 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-31 10:44 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #27 from Daniel Vetter (daniel@ffwll.ch) ---
Ok I've reviewed all the drivers where Peter Rosin's patch series removed the
load_lut hook:
- ast: fixed with my patch
- mga200g: already has a callchain like crtc_commit -> dpms -> load_lut, so
works correctly already
- cirrus: same bug as ast, I'm typing a patch for that now
- radeon: head-scratcher, I still have no idea what's going on
- amdgpu: should work, but might have the same bug as radeon due to heritage

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (26 preceding siblings ...)
  2018-01-31 10:44 ` bugzilla-daemon
@ 2018-01-31 11:14 ` bugzilla-daemon
  2018-02-01 15:39 ` bugzilla-daemon
                   ` (24 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-01-31 11:14 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #28 from Daniel Vetter (daniel@ffwll.ch) ---
Created attachment 273941
  --> https://bugzilla.kernel.org/attachment.cgi?id=273941&action=edit
test patch for deposite pirate

Should apply on any recent-ish kernel. Please apply, boot, and grab the
complete dmesg (from kernel loading up to latest message), there should be
plenty of backtraces all around.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (27 preceding siblings ...)
  2018-01-31 11:14 ` bugzilla-daemon
@ 2018-02-01 15:39 ` bugzilla-daemon
  2018-02-19  8:20 ` bugzilla-daemon
                   ` (23 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-02-01 15:39 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #29 from Deposite Pirate (dpirate@metalpunks.info) ---
Created attachment 273963
  --> https://bugzilla.kernel.org/attachment.cgi?id=273963&action=edit
dmesg output

Here's the dmesg output with the patch applied On top of v4.15 (compiling HEAD
fails)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (28 preceding siblings ...)
  2018-02-01 15:39 ` bugzilla-daemon
@ 2018-02-19  8:20 ` bugzilla-daemon
  2018-02-19  8:35 ` bugzilla-daemon
                   ` (22 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-02-19  8:20 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #30 from Daniel Vetter (daniel@ffwll.ch) ---
There was not a single backtrace in that attachement. Was this only up to
fbcon, or did you start X too? Where the colors correct afterwards?

It's also strange that it fails to compile on HEAD, that shouldn't happen (and
would indicate some other leftovers or something).

I'll attach another test patch, that time around please make sure you boot
until X (or whatever ends up fixing your colors).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (29 preceding siblings ...)
  2018-02-19  8:20 ` bugzilla-daemon
@ 2018-02-19  8:35 ` bugzilla-daemon
  2018-02-19 15:19 ` bugzilla-daemon
                   ` (21 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-02-19  8:35 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #31 from Daniel Vetter (daniel@ffwll.ch) ---
Created attachment 274229
  --> https://bugzilla.kernel.org/attachment.cgi?id=274229&action=edit
another test patch for Deposite Pirate

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (30 preceding siblings ...)
  2018-02-19  8:35 ` bugzilla-daemon
@ 2018-02-19 15:19 ` bugzilla-daemon
  2018-02-26  2:57 ` bugzilla-daemon
                   ` (20 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-02-19 15:19 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #32 from Deposite Pirate (dpirate@metalpunks.info) ---
Hi,

Yeah, I wasn't sure because I never enabled backtraces before. But it didn't
seem to me that there were many backtraces either. Though I did double check
the patch was applied.

I have X automatically started by systemd/lightdm at boot but the booting
process is slow enough that I can see the wrong colors while the kernel prints
it's stuff for a few seconds. And yes the colors are correct after X starts
when I switch back to consoles with CTRL+ALT+F?.

The failure to compile on HEAD of back then had nothing to do with the patch. I
don't remember exactly where it failed to compile but it was a completely
unrelated source file. It's not like regressions even with stable kernel
releases happen rarely. Right now, I have another Athlon 64 system with an
onboard GeForce card that won't even start X because it can't find
/dev/card/dri0 with kernel 4.15.4 and another more recent AMD A8-something
ThinkPad that OOPSes at boot because of something related to SATA with 4.15.2.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (31 preceding siblings ...)
  2018-02-19 15:19 ` bugzilla-daemon
@ 2018-02-26  2:57 ` bugzilla-daemon
  2018-02-26  2:59 ` bugzilla-daemon
                   ` (19 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-02-26  2:57 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #33 from Deposite Pirate (dpirate@metalpunks.info) ---
Created attachment 274465
  --> https://bugzilla.kernel.org/attachment.cgi?id=274465&action=edit
dmesg log 2

Applied on top of 4.15.6.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (32 preceding siblings ...)
  2018-02-26  2:57 ` bugzilla-daemon
@ 2018-02-26  2:59 ` bugzilla-daemon
  2018-03-13 18:53 ` bugzilla-daemon
                   ` (18 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-02-26  2:59 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #34 from Deposite Pirate (dpirate@metalpunks.info) ---
Ok, I've had some time to apply the new patch. The tracing works and with this
patch applied on top of 4.15.6 the issue has vanished for some reason.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (33 preceding siblings ...)
  2018-02-26  2:59 ` bugzilla-daemon
@ 2018-03-13 18:53 ` bugzilla-daemon
  2018-03-14  9:10 ` bugzilla-daemon
                   ` (17 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-13 18:53 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

shibe@tuta.io changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shibe@tuta.io

--- Comment #35 from shibe@tuta.io ---
Has the cause of this issue been identified/confirmed?

On boot I have grey console background instead of black.

Linux 4.15.8-1-ARCH x86_64

1002:6758 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI]
Turks XT [Radeon HD 6670/7670]

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (34 preceding siblings ...)
  2018-03-13 18:53 ` bugzilla-daemon
@ 2018-03-14  9:10 ` bugzilla-daemon
  2018-03-14 23:48 ` bugzilla-daemon
                   ` (16 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-14  9:10 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #36 from Michel Dänzer (michel@daenzer.net) ---
(In reply to shibe from comment #35)
> Has the cause of this issue been identified/confirmed?

Not yet, unfortunately.

> On boot I have grey console background instead of black.

Can you try the latest test patch attached here, and attach the dmesg output
from running with it?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (35 preceding siblings ...)
  2018-03-14  9:10 ` bugzilla-daemon
@ 2018-03-14 23:48 ` bugzilla-daemon
  2018-03-15  9:20 ` bugzilla-daemon
                   ` (15 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-14 23:48 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #37 from shibe@tuta.io ---
(In reply to Michel Dänzer from comment #36)
> Can you try the latest test patch attached here, and attach the dmesg output
> from running with it?

With the patch, the background is always black. I guess, there is a race, and
the patch affects the outcome.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (36 preceding siblings ...)
  2018-03-14 23:48 ` bugzilla-daemon
@ 2018-03-15  9:20 ` bugzilla-daemon
  2018-03-15 22:18 ` bugzilla-daemon
                   ` (14 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-15  9:20 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #38 from Deposite Pirate (dpirate@metalpunks.info) ---
That's what I think as well.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (37 preceding siblings ...)
  2018-03-15  9:20 ` bugzilla-daemon
@ 2018-03-15 22:18 ` bugzilla-daemon
  2018-03-16  9:29 ` bugzilla-daemon
                   ` (13 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-15 22:18 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #39 from shibe@tuta.io ---
I booted the stock kernel with nosmp few times. One time - gray, other times -
black. I wonder if the initialization code could be preempted and the race
still occurs on a single CPU. Otherwise, it may be a race with GPU. Maybe need
to wait for a previous command to complete.

What to try next?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (38 preceding siblings ...)
  2018-03-15 22:18 ` bugzilla-daemon
@ 2018-03-16  9:29 ` bugzilla-daemon
  2018-03-16 19:20 ` bugzilla-daemon
                   ` (12 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-16  9:29 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

Michel Dänzer (michel@daenzer.net) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |harry.wentland@amd.com

--- Comment #40 from Michel Dänzer (michel@daenzer.net) ---
(In reply to shibe from comment #39)
> Otherwise, it may be a race with GPU.

Yeah, things are pointing to something like that.

Harry, does anything jump out in dce5_crtc_load_lut, or can you think of
anything else that might affect this, possibly specific to DCE5 or Turks?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (39 preceding siblings ...)
  2018-03-16  9:29 ` bugzilla-daemon
@ 2018-03-16 19:20 ` bugzilla-daemon
  2018-03-17 18:57 ` bugzilla-daemon
                   ` (11 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-16 19:20 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #41 from Alex Deucher (alexdeucher@gmail.com) ---
Maybe something will jump out if we look at the register differences?  You can
use radeonreg (https://cgit.freedesktop.org/~airlied/radeontool/) to dump the
display registers. e.g., radeonreg regs dce5 > working.out.  And then diff the
working and non-working cases.  At least if we can narrow down the register(s),
we can trace that back to the code.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (40 preceding siblings ...)
  2018-03-16 19:20 ` bugzilla-daemon
@ 2018-03-17 18:57 ` bugzilla-daemon
  2018-03-18 14:33 ` bugzilla-daemon
                   ` (10 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-17 18:57 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #42 from shibe@tuta.io ---
Some values from register dumps. All kernel modules are the same.

Black background:

000069FC        00000002

Grey background:

000003D8        00000000

000064C8        7F007F00

000069FC        00000000

00006BBC        00000001

00006BCC        00000000

00006D54        00000001

Other values are either different between dumps of the same case or common to
both cases.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (41 preceding siblings ...)
  2018-03-17 18:57 ` bugzilla-daemon
@ 2018-03-18 14:33 ` bugzilla-daemon
  2018-03-19  9:40 ` bugzilla-daemon
                   ` (9 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-18 14:33 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #43 from Alex Deucher (alexdeucher@gmail.com) ---
Please attach the full dump for each case.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (42 preceding siblings ...)
  2018-03-18 14:33 ` bugzilla-daemon
@ 2018-03-19  9:40 ` bugzilla-daemon
  2018-03-19  9:43 ` bugzilla-daemon
                   ` (8 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-19  9:40 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #44 from shibe@tuta.io ---
Created attachment 274813
  --> https://bugzilla.kernel.org/attachment.cgi?id=274813&action=edit
radeonreg black background

Linux 4.15.10-1-ARCH SMP PREEMPT x86_64

I made 8 dumps from different boots and selected one that has the most bits in
common with other dumps. The console background is black on all these boots.
The kernel, modules, and the command line are the same.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (43 preceding siblings ...)
  2018-03-19  9:40 ` bugzilla-daemon
@ 2018-03-19  9:43 ` bugzilla-daemon
  2018-03-19 13:55 ` bugzilla-daemon
                   ` (7 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-19  9:43 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #45 from shibe@tuta.io ---
Created attachment 274815
  --> https://bugzilla.kernel.org/attachment.cgi?id=274815&action=edit
radeonreg grey background

Linux 4.15.10-1-ARCH SMP PREEMPT x86_64

I made 11 dumps from different boots and selected one that has the most bits in
common with other dumps. The console background is light grey on most of these
boots, but there were a couple of dark grey. The kernel, modules, and the
command line are the same as for the black dumps.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (44 preceding siblings ...)
  2018-03-19  9:43 ` bugzilla-daemon
@ 2018-03-19 13:55 ` bugzilla-daemon
  2018-03-20  4:37 ` bugzilla-daemon
                   ` (6 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-19 13:55 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #46 from Harry Wentland (harry.wentland@amd.com) ---
Michel, nobody jumps out to me in dce5_crtc_load_lut but I have only cursory
familiary with those registers.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (45 preceding siblings ...)
  2018-03-19 13:55 ` bugzilla-daemon
@ 2018-03-20  4:37 ` bugzilla-daemon
  2018-03-20  6:03 ` bugzilla-daemon
                   ` (5 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-20  4:37 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #47 from shibe@tuta.io ---
I analysed individual bits in register dumps. Some bits are set in all 8 dumps
with black background and unset in most of dumps with grey background.

The value at 0x69F0 is 0x00401004 in all black dumps, vary in grey dumps.

The value at 0x69FC is 0x00000002 in all black dumps, 0x00000000 in all grey
dumps.

Other registers, least significant bit first:

6BB0  0 + ? ? ? ? ? ?  ? ? ? 0 0 0 0 0  0 0 0 0 0 0 0 0  0 0 0 0 0 0 0 0
6E98  ? ? + ? ? ? ? ?  ? 1 0 0 0 0 0 0  0 0 0 0 0 0 0 0  0 0 0 0 0 0 0 0
6E9C  ? ? + ? ? ? ? ?  ? 1 0 0 0 0 0 0  ? ? ? ? ? ? ? ?  ? ? ? 0 0 0 0 0

Legend:
0 always 0 in black dumps
1 always 1 in black dumps
? vary in black dumps
+ always 1 in black dumps, usually 0 in grey dumps

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (46 preceding siblings ...)
  2018-03-20  4:37 ` bugzilla-daemon
@ 2018-03-20  6:03 ` bugzilla-daemon
  2018-08-09  7:39 ` bugzilla-daemon
                   ` (4 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-03-20  6:03 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #48 from shibe@tuta.io ---
Turns out, I missed some interesting bits. Here, least significant bit first:

69E4  - - 0 0 - - - 0  0 0 0 0 0 0 0 0  0 0 0 0 0 0 0 0  0 0 0 0 0 0 0 0
69E8  0 0 0 0 0 0 - -  0 0 - - - 0 0 0  0 0 0 0 0 0 0 0  0 0 0 0 0 0 0 0
69EC  0 0 0 0 0 0 - -  - - - - - - 0 0  0 0 0 0 0 0 1 -  0 0 - - - 0 0 0
69F0  0 0 + - 0 0 - -  - 0 0 0 + - 0 0  - - - 0 0 0 + -  0 0 - - - 0 0 0
69FC  0 + 0 0 0 0 0 0  0 0 0 0 0 0 0 0  0 0 0 0 0 0 0 0  0 0 0 0 0 0 0 0
6E68  - 0 0 - 0 - 0 0  0 - - 0 0 - 0 -  0 0 0 - - 0 0 -  0 - 0 0 0 - 0 0

Legend:
0 always 0 in black dumps
1 always 1 in black dumps
+ always 1 in black dumps, usually 0 in grey dumps
- always 0 in black dumps, usually 1 in grey dumps

I've found that 0x69?? addresses are defined as constants with the prefix
"EVERGREEN_DC_LUT_". Why could these registers be messed up?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (47 preceding siblings ...)
  2018-03-20  6:03 ` bugzilla-daemon
@ 2018-08-09  7:39 ` bugzilla-daemon
  2018-09-05 13:59 ` bugzilla-daemon
                   ` (3 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-08-09  7:39 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

--- Comment #49 from Daniel Vetter (daniel@ffwll.ch) ---
Created attachment 277775
  --> https://bugzilla.kernel.org/attachment.cgi?id=277775&action=edit
insert huge sleep into lut load path

Maybe this helps in blowing up the race and perhaps shed some light here.
Please test and report what happens.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (48 preceding siblings ...)
  2018-08-09  7:39 ` bugzilla-daemon
@ 2018-09-05 13:59 ` bugzilla-daemon
  2018-11-26 18:21 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-09-05 13:59 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

Daniel Vetter (daniel@ffwll.ch) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (49 preceding siblings ...)
  2018-09-05 13:59 ` bugzilla-daemon
@ 2018-11-26 18:21 ` bugzilla-daemon
  2019-03-05  1:12 ` bugzilla-daemon
  2023-10-01 21:32 ` bugzilla-daemon
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2018-11-26 18:21 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

Peter Gazer (ttallink@googlemail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ttallink@googlemail.com

--- Comment #50 from Peter Gazer (ttallink@googlemail.com) ---
Simply adding a 10ms msleep call in radeon_crtc_load_lut completely fixes the
issue for me, so yes, race condition for sure (HD 6850 card).

Let me know if there's anything else I can try to nail down the actual issue,
I'd like to find a proper patch for this.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (50 preceding siblings ...)
  2018-11-26 18:21 ` bugzilla-daemon
@ 2019-03-05  1:12 ` bugzilla-daemon
  2023-10-01 21:32 ` bugzilla-daemon
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2019-03-05  1:12 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

crocket (crockabiscuit@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |crockabiscuit@gmail.com

--- Comment #51 from crocket (crockabiscuit@gmail.com) ---
https://bugzilla.kernel.org/show_bug.cgi?id=202739 might be a fix.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 62+ messages in thread

* [Bug 198123] Console is the wrong color at boot with radeon 6670
  2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
                   ` (51 preceding siblings ...)
  2019-03-05  1:12 ` bugzilla-daemon
@ 2023-10-01 21:32 ` bugzilla-daemon
  52 siblings, 0 replies; 62+ messages in thread
From: bugzilla-daemon @ 2023-10-01 21:32 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=198123

Roland Kletzing (devzero@web.de) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |devzero@web.de

--- Comment #52 from Roland Kletzing (devzero@web.de) ---
i have some similar broken console colour issue with rx300 s6 since kernel 6.1.
 not sure if it's related, but wanted to let you know.  

for most of the time, text is barely visible and contrast totally sucks, so i
always need to use nomodeset for boot as a workaround

and - same here:  after starting X and switching back to console, the problem
disappears

https://gitlab.freedesktop.org/drm/misc/-/issues/31

still busy with git bisecting

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

^ permalink raw reply	[flat|nested] 62+ messages in thread

end of thread, other threads:[~2023-10-01 21:32 UTC | newest]

Thread overview: 62+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-10 16:53 [Bug 198123] New: Console is the wrong color at boot with radeon 6670 bugzilla-daemon
2017-12-11  3:56 ` [Bug 198123] " bugzilla-daemon
2017-12-11 23:31 ` bugzilla-daemon
2017-12-12 23:11 ` bugzilla-daemon
2017-12-12 23:26 ` bugzilla-daemon
2017-12-12 23:33 ` bugzilla-daemon
2017-12-12 23:48 ` bugzilla-daemon
2017-12-13  0:59 ` bugzilla-daemon
2017-12-16  1:41 ` bugzilla-daemon
2017-12-18 11:37   ` Michel Dänzer
2017-12-18 13:50     ` Peter Rosin
2017-12-19 10:48       ` Michel Dänzer
2017-12-22 15:34         ` Michel Dänzer
2018-01-07 19:14         ` Deposite Pirate
2018-01-10 12:15           ` Daniel Vetter
2018-01-11  8:57             ` Daniel Vetter
2018-01-11  9:09             ` Michel Dänzer
2017-12-28  9:35 ` bugzilla-daemon
2018-01-11 10:11 ` bugzilla-daemon
2018-01-12  8:46 ` bugzilla-daemon
2018-01-12  9:50 ` bugzilla-daemon
2018-01-12 21:12 ` bugzilla-daemon
2018-01-13  6:50 ` bugzilla-daemon
2018-01-13 13:34 ` bugzilla-daemon
2018-01-14 18:32 ` bugzilla-daemon
2018-01-14 20:40 ` bugzilla-daemon
2018-01-16 16:54 ` bugzilla-daemon
2018-01-17 13:48 ` bugzilla-daemon
2018-01-18  5:15 ` bugzilla-daemon
2018-01-22  8:39 ` bugzilla-daemon
2018-01-22  8:40 ` bugzilla-daemon
2018-01-26  6:50 ` bugzilla-daemon
2018-01-26 17:54 ` bugzilla-daemon
2018-01-28 22:55 ` bugzilla-daemon
2018-01-31 10:36 ` bugzilla-daemon
2018-01-31 10:44 ` bugzilla-daemon
2018-01-31 11:14 ` bugzilla-daemon
2018-02-01 15:39 ` bugzilla-daemon
2018-02-19  8:20 ` bugzilla-daemon
2018-02-19  8:35 ` bugzilla-daemon
2018-02-19 15:19 ` bugzilla-daemon
2018-02-26  2:57 ` bugzilla-daemon
2018-02-26  2:59 ` bugzilla-daemon
2018-03-13 18:53 ` bugzilla-daemon
2018-03-14  9:10 ` bugzilla-daemon
2018-03-14 23:48 ` bugzilla-daemon
2018-03-15  9:20 ` bugzilla-daemon
2018-03-15 22:18 ` bugzilla-daemon
2018-03-16  9:29 ` bugzilla-daemon
2018-03-16 19:20 ` bugzilla-daemon
2018-03-17 18:57 ` bugzilla-daemon
2018-03-18 14:33 ` bugzilla-daemon
2018-03-19  9:40 ` bugzilla-daemon
2018-03-19  9:43 ` bugzilla-daemon
2018-03-19 13:55 ` bugzilla-daemon
2018-03-20  4:37 ` bugzilla-daemon
2018-03-20  6:03 ` bugzilla-daemon
2018-08-09  7:39 ` bugzilla-daemon
2018-09-05 13:59 ` bugzilla-daemon
2018-11-26 18:21 ` bugzilla-daemon
2019-03-05  1:12 ` bugzilla-daemon
2023-10-01 21:32 ` bugzilla-daemon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.