All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linux-f2fs-devel@lists.sourceforge.net
Subject: [Bug 200871] F2FS experiences data loss (entry is completely lost) when an I/O failure occurs.
Date: Tue, 16 Oct 2018 01:48:46 +0000	[thread overview]
Message-ID: <bug-200871-202145-gTbdXbAbx6@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-200871-202145@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=200871

--- Comment #17 from Chao Yu (chao@kernel.org) ---
(In reply to Stathis Maneas from comment #16)
> I am sorry for the delay! I can definitely help by adding the aforementioned
> statements!
> 
> After adding them and observing the output of dmesg, I can observe that only
> the second statement gets actually invoked:
> [ 1026.438986] f2fs_wait_on_node_pages_writeback, eio:0
> 
> Therefore, this indicates that the following condition is not true under the
> specified workload:
> if (unlikely(bio->bi_status)) { ... }
> 
> I tried moving the first print statement at the beginning of the following
> for loop,
> bio_for_each_segment_all(bvec, bio, i) { ... }
> 
> but still, I am not observing any errors for the segment (block) of interest:
> [   76.603891] f2fs_write_end_io, ino:1, idx:4, eio:0, type:7
> [   76.603893] f2fs_write_end_io, is_dummy:0 bio_status:0

Sorry for the delay.

Oh, so I guess that you trigger the error injection but didn't set
bio->bi_status to nonzero value, result in fs can not be aware of that.

I think we'd better to double check all your test steps and injection codes.

> 
> Is there something else we can try?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

      parent reply	other threads:[~2018-10-16  1:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-200871-202145@https.bugzilla.kernel.org/>
2018-08-23 15:26 ` [Bug 200871] F2FS experiences data loss (entry is completely lost) when an I/O failure occurs bugzilla-daemon
2018-08-26  9:09 ` bugzilla-daemon
2018-08-26 23:43 ` bugzilla-daemon
2018-08-31  7:19 ` bugzilla-daemon
2018-09-05 21:22 ` bugzilla-daemon
2018-09-05 21:23 ` bugzilla-daemon
2018-09-05 21:23 ` bugzilla-daemon
2018-09-05 21:40 ` bugzilla-daemon
2018-09-05 21:42 ` bugzilla-daemon
2018-09-21  1:50   ` Sotirios-Efstathios Maneas
2018-09-21  2:18 ` bugzilla-daemon
2018-09-21  8:50 ` bugzilla-daemon
2018-09-23  4:16 ` bugzilla-daemon
2018-09-26  8:48 ` bugzilla-daemon
2018-09-26  9:13 ` bugzilla-daemon
2018-09-26  9:45 ` bugzilla-daemon
2018-09-29  1:58 ` bugzilla-daemon
2018-10-07  1:50 ` bugzilla-daemon
2018-10-16  1:48 ` bugzilla-daemon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-200871-202145-gTbdXbAbx6@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.