All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [Bug 204043] F2fs kernel BUG at fs/f2fs/data.c:317!
Date: Fri, 05 Jul 2019 03:55:55 +0000	[thread overview]
Message-ID: <bug-204043-202145-wC26EASfaU@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-204043-202145@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=204043

Chao Yu (chao@kernel.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |chao@kernel.org

--- Comment #1 from Chao Yu (chao@kernel.org) ---
Could you help to add below diff to check debug info?

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index bc5cea27b512..333285cb14c5 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -241,7 +241,7 @@ static inline void __submit_bio(struct f2fs_sb_info *sbi,
                                struct bio *bio, enum page_type type)
 {
        if (!is_read_io(bio_op(bio))) {
-               unsigned int start;
+               unsigned int start, ofs;

                if (type != DATA && type != NODE)
                        goto submit_io;
@@ -256,7 +256,7 @@ static inline void __submit_bio(struct f2fs_sb_info *sbi,
                        goto submit_io;

                /* fill dummy pages */
-               for (; start < F2FS_IO_SIZE(sbi); start++) {
+               for (ofs = start; ofs < F2FS_IO_SIZE(sbi); ofs++) {
                        struct page *page =
                                mempool_alloc(sbi->write_io_dummy,
                                              GFP_NOIO | __GFP_NOFAIL);
@@ -266,8 +266,16 @@ static inline void __submit_bio(struct f2fs_sb_info *sbi,
                        SetPagePrivate(page);
                        set_page_private(page, (unsigned
long)DUMMY_WRITTEN_PAGE);
                        lock_page(page);
-                       if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE)
-                               f2fs_bug_on(sbi, 1);
+                       if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE)
{
+                               printk("ofs:%u, start:%u, io_size:%u, "
+                                       "size:%u, vcnt:%u, max_vecs:%u",
+                                       ofs, start, F2FS_IO_SIZE(sbi),
+                                       bio->bi_iter.bi_size,
+                                       bio->bi_vcnt,
+                                       bio->bi_max_vecs);
+                               WARN_ON(1);
+                               break;
+                       }
                }
                /*
                 * In the NODE case, we lose next block address chain. So, we

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2019-07-05  3:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-01  8:44 [f2fs-dev] [Bug 204043] New: F2fs kernel BUG at fs/f2fs/data.c:317! bugzilla-daemon
2019-07-05  3:55 ` bugzilla-daemon [this message]
2019-07-08  6:57 ` [f2fs-dev] [Bug 204043] " bugzilla-daemon
2019-07-11 10:41 ` bugzilla-daemon
2019-07-16  9:06 ` bugzilla-daemon
2019-07-17  1:36 ` bugzilla-daemon
2019-07-17  2:01 ` bugzilla-daemon
2019-07-22  3:10 ` bugzilla-daemon
2019-07-22  3:46 ` bugzilla-daemon
2019-07-22  6:18 ` bugzilla-daemon
2019-07-30  2:11 ` bugzilla-daemon
2019-07-30  2:34 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-204043-202145-wC26EASfaU@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.