[Bug 206393] New: amdgpu: garbled screen after resume

[Bug 206393] New: amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

            Bug ID: 206393
           Summary: amdgpu: garbled screen after resume
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.5.1-arch1, 5.5-arch1
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Video(DRI - non Intel)
          Assignee: drivers_video-dri@kernel-bugs.osdl.org
          Reporter: bjo@nord-west.org
        Regression: No

Created attachment 287081
  --> https://bugzilla.kernel.org/attachment.cgi?id=287081&action=edit
garbled screen

On a Thinkpad A275 with a Radeon R5/R6/R7 (verbose lspci attached) the screen
is garbled after resume. First a black screen appears and then more and more
white pixels appear from the border to the middle of the screen.

Restarting the X-session via SSH does not help, the VTs are also inaccessible.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 206393] amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

--- Comment #1 from Bjoern Franke (bjo@nord-west.org) ---
Created attachment 287083
  --> https://bugzilla.kernel.org/attachment.cgi?id=287083&action=edit
dmesg

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 206393] amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

--- Comment #2 from Bjoern Franke (bjo@nord-west.org) ---
Created attachment 287085
  --> https://bugzilla.kernel.org/attachment.cgi?id=287085&action=edit
lspci

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 206393] amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

Alex Deucher (alexdeucher@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexdeucher@gmail.com

--- Comment #3 from Alex Deucher (alexdeucher@gmail.com) ---
Is this a regression?  If so, can you bisect?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 206393] amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

--- Comment #4 from Bjoern Franke (bjo@nord-west.org) ---
It's a regression, it did not appear with 5.4.15. The error message "[   
1.549880] [drm:dm_helpers_parse_edid_caps [amdgpu]] *ERROR* Couldn't read SADs:
-2" at the beginning also does not appear with 5.4.15.

I will try to bisect it (my last bisecting is 8 years ago).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 206393] amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

--- Comment #5 from Bjoern Franke (bjo@nord-west.org) ---
Bisected to
1ea8751bd28d1ec2b36a56ec6bc1ac28903d09b4 is the first bad commit
commit 1ea8751bd28d1ec2b36a56ec6bc1ac28903d09b4
Author: Noah Abradjian <noah.abradjian@amd.com>
Date:   Fri Sep 27 16:30:57 2019 -0400

    drm/amd/display: Make clk mgr the only dto update point

    [Why]

    * Clk Mgr DTO update point did not cover all needed updates, as it included
a
      check for plane_state which does not exist yet when the updater is called
on
      driver startup
    * This resulted in another update path in the pipe programming sequence,
based
      on a dppclk update flag
    * However, this alternate path allowed for stray DTO updates, some of which
would
      occur in the wrong order during dppclk lowering and cause underflow

    [How]

    * Remove plane_state check and use of plane_res.dpp->inst, getting rid
      of sequence dependencies (this results in extra dto programming for
unused
      pipes but that doesn't cause issues and is a small cost)
    * Allow DTOs to be updated even if global clock is equal, to account for
      edge case exposed by diags tests
    * Remove update_dpp_dto call in pipe programming sequence (leave update to
      dppclk_control there, as that update is necessary and shouldn't occur in
clk
      mgr)
    * Remove call to optimize_bandwidth when committing state, as it is not
needed
      and resulted in sporadic underflows even with other fixes in place

    Signed-off-by: Noah Abradjian <noah.abradjian@amd.com>
    Reviewed-by: Jun Lei <Jun.Lei@amd.com>
    Acked-by: Leo Li <sunpeng.li@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

 .../gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c   | 14 +++++++++-----
 drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c  |  3 ++-
 drivers/gpu/drm/amd/display/dc/core/dc.c                   |  4 ----
 drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c         |  8 +-------
 4 files changed, 12 insertions(+), 17 deletions(-)

In contrast to #205915 it's not "fixable" via setting
dpm_force_performance_level to high or low.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 206393] amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

Bjoern Franke (bjo@nord-west.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Regression|No                          |Yes

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 206393] amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

--- Comment #6 from Alex Deucher (alexdeucher@gmail.com) ---
See also:
https://bugzilla.kernel.org/show_bug.cgi?id=205915
https://bugzilla.kernel.org/show_bug.cgi?id=206393
https://bugzilla.kernel.org/show_bug.cgi?id=206575

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 206393] amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

Alexander Jones (acjones8@hawaii.edu) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acjones8@hawaii.edu

--- Comment #7 from Alexander Jones (acjones8@hawaii.edu) ---
I can also confirm this bug, I'm suffering the exact same problem with my
ThinkPad A275. My glitchy screen looks like this: https://imgur.com/tKAxlI7

I'm also not able to restart X or switch VT, but I can confirm that the user
applications still run, as I've heard Kmail issue a notification while the
screen was glitchy. Other functions of the laptop, like the fan speed and
keyboard illumination, still work perfectly after waking up and function like
normal (if I press the shortcut to light the keyboard up, it changes intensity
properly). Switching back to an older version of the kernel, 5.4.10 in my case,
fixes the problem as well.

Curiously enough, I checked my dmesg for the SAD message after suspending with
the older kernel, and it now reads this:

[    5.450379] [drm] SADs count is: -2, don't need to read it

So it seems to be related to reading whatever the SAD is.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 206393] amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

--- Comment #8 from Alex Deucher (alexdeucher@gmail.com) ---
The SAD message is harmless and unrelated.  The issue is with the patch in
comment 5.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 206393] amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

--- Comment #9 from Bjoern Franke (bjo@nord-west.org) ---
Issue seems to be fixed in 5.6.0-rc3, so it will be hopefully backported into
the 5.5 branch.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 206393] amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

--- Comment #10 from Alex Deucher (alexdeucher@gmail.com) ---
(In reply to Bjoern Franke from comment #9)
> Issue seems to be fixed in 5.6.0-rc3, so it will be hopefully backported
> into the 5.5 branch.

Can you identify what patch fixed it for you?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 206393] amdgpu: garbled screen after resume

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206393

--- Comment #11 from Bjoern Franke (bjo@nord-west.org) ---
(In reply to Alex Deucher from comment #10)
> (In reply to Bjoern Franke from comment #9)
> > Issue seems to be fixed in 5.6.0-rc3, so it will be hopefully backported
> > into the 5.5 branch.
> 
> Can you identify what patch fixed it for you?

Bisected to 5622b2d68d0a6e2fd960f2129704dc3c561608b2. Does this make sense to
you?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel