From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A61EDC433E4 for ; Mon, 27 Jul 2020 20:41:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E75720759 for ; Mon, 27 Jul 2020 20:41:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726782AbgG0UlW convert rfc822-to-8bit (ORCPT ); Mon, 27 Jul 2020 16:41:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:58650 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726711AbgG0UlW (ORCPT ); Mon, 27 Jul 2020 16:41:22 -0400 From: bugzilla-daemon@bugzilla.kernel.org To: linux-ext4@vger.kernel.org Subject: [Bug 207729] Mounting EXT4 with data_err=abort does not abort journal on data block write failure Date: Mon, 27 Jul 2020 20:41:21 +0000 X-Bugzilla-Reason: None X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: AssignedTo fs_ext4@kernel-bugs.osdl.org X-Bugzilla-Product: File System X-Bugzilla-Component: ext4 X-Bugzilla-Version: 2.5 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: rebello.anthony@gmail.com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: fs_ext4@kernel-bugs.osdl.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Bugzilla-URL: https://bugzilla.kernel.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org https://bugzilla.kernel.org/show_bug.cgi?id=207729 --- Comment #3 from Anthony Rebello (rebello.anthony@gmail.com) --- Hi Jan, Thank you for your reply. I've changed the workload to perform appends rather than in-place updates. Appending sufficient data will cause a new block to be allocated. On fsync, this newly allocated data block will be written out and in ordered mode, the journal entry will contain the block bitmap (with the bit set for the newly allocated block) and the inode table that maps the offset to this block. In this particular case, if `data_err=abort` is enabled, the journal should abort when it fails to write the newly allocated data block. However, that doesn't seem to be the case. I've attached an updated TGZ containing the append workload. The bitmap has the block set, the inode table still points to the block, but the block has not been overwritten with the intended data. It still contains it's old contents. -- You are receiving this mail because: You are watching the assignee of the bug.