All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [Bug 208565] There may be dead lock for cp_rwsem during checkpoint
Date: Thu, 16 Jul 2020 17:15:05 +0000	[thread overview]
Message-ID: <bug-208565-202145-dVHjH4iPCX@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-208565-202145@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=208565

Jaegeuk Kim (jaegeuk@kernel.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jaegeuk@kernel.org

--- Comment #1 from Jaegeuk Kim (jaegeuk@kernel.org) ---
Thank you for the report.

I think this is valid point that we need to fix.
I'm testing a RFC patch like this. Thanks.

--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1926,8 +1926,12 @@ int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
                                goto continue_unlock;
                        }

-                       /* flush inline_data, if it's async context. */
-                       if (do_balance && is_inline_node(page)) {
+                       /* flush inline_data/inode, if it's async context. */
+                       if (!do_balance)
+                               goto write_node;
+
+                       /* flush inline_data */
+                       if (is_inline_node(page)) {
                                clear_inline_node(page);
                                unlock_page(page);
                                flush_inline_data(sbi, ino_of_node(page));
@@ -1940,7 +1944,7 @@ int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
                                if (flush_dirty_inode(page))
                                        goto lock_node;
                        }
-
+write_node:
                        f2fs_wait_on_page_writeback(page, NODE, true, true);

                        if (!clear_page_dirty_for_io(page))

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2020-07-16 17:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 12:24 [f2fs-dev] [Bug 208565] New: There may be dead lock for cp_rwsem during checkpoint bugzilla-daemon
2020-07-16 17:15 ` bugzilla-daemon [this message]
2020-07-24  1:31   ` [f2fs-dev] [Bug 208565] " Chao Yu
2020-07-17  1:54 ` bugzilla-daemon
2020-07-17  2:02 ` bugzilla-daemon
2020-07-17  2:26 ` bugzilla-daemon
2020-07-17  6:16   ` [f2fs-dev] Fwd: " Chao Yu
2020-07-17  2:47 ` [f2fs-dev] " bugzilla-daemon
2020-07-23  7:11 ` bugzilla-daemon
2020-07-24  1:31 ` bugzilla-daemon
2020-07-24  3:21 ` bugzilla-daemon
2020-07-24  3:38   ` Chao Yu
2020-07-24  3:38 ` bugzilla-daemon
2020-07-24  3:56 ` bugzilla-daemon
2020-07-24  6:36 ` bugzilla-daemon
2020-07-24 17:25 ` bugzilla-daemon
2022-09-27  0:48 ` bugzilla-daemon
2022-09-27  0:49 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-208565-202145-dVHjH4iPCX@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.