Comment on attac=
hment 125642 [details] [review]=

backlight control w/ gpio check

Review of attachment 125642 [details] [review]:
-----------------------------------------------------------------

This looks much better already. There are still a few things:

the kernel uses tabs 8 character big. Don't use whitespaces. Other remaining
issues inlined.

With everything taking care off, you get my rb-by karolherbst@gmail.com

::: nouveau_backlight.c.orig
@@ +46,5 @@
> +{
> +        struct nouveau_drm *drm =3D bl_get_data(bd);
> +        struct nvif_object *device =3D &drm->device.object;
> +        int val =3D (nvif_rd32(device, NV30_PMC_BACKLIGHT) &
> +                                   NV30_PMC_BACKLIGHT_MASK) >> =
16;

indentation, either try to fit it in one line or break the nvif_rd32 command
like this:

nvif_rd32(arg1,
          arg2);

@@ +64,5 @@
> +        int level;
> +
> +        if (val =3D=3D 0)
> +                level =3D 0x00;
> +

remove empty line here

@@ +69,5 @@
> +        else
> +                level =3D val + NV30_BL_MIN_LEVEL - 1;
> +
> +        nvif_wr32(device, NV30_PMC_BACKLIGHT,
> +                 (level << 16) + 0x80000535);  /* workaround fo=
r disabled backlight after waking from suspend */

indentation same as above. Also beware the 80 character limit.

@@ +101,5 @@
> +                return 0;
> +
> +        memset(&props, 0, sizeof(struct backlight_properties));
> +        props.type =3D BACKLIGHT_RAW;
> +        props.max_brightness =3D NV30_BL_MAX_LEVEL - NV30_BL_MIN_LEVE=
L;  /* includes an additional 0x00 level (backlight off) */

80 character limit