[Bug 60034] New: rv790 etqw regression since r600g: add async for staging buffer upload v2

[Bug 60034] New: rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1219 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

          Priority: medium
            Bug ID: 60034
          Assignee: dri-devel@lists.freedesktop.org
           Summary: rv790 etqw regression since r600g: add async for
                    staging buffer upload v2
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: lists@andyfurniss.entadsl.com
          Hardware: x86 (IA32)
            Status: NEW
           Version: git
         Component: Drivers/Gallium/r600
           Product: Mesa

Card PCIE HD4890, drm fixes kernel.

Since -

commit 325422c49449acdd8df1eb2ca8ed81f7696c38cc
Author: Jerome Glisse <jglisse@redhat.com>
Date:   Mon Jan 7 17:45:59 2013 -0500

    r600g: add async for staging buffer upload v2

    v2: Add virtual address to dma src/dst offset for cayman


I can see some reflection rendering errors in etqw.

They are not visible on most maps but looking from high up on island where the
sky is reflected in the sea they are obvious from a cold boot, but far more
subtle after running repeatedly for bisect.

attached screenshots showing both cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2582 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 319 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #1 from Andy Furniss <lists@andyfurniss.entadsl.com> ---
Created attachment 73868
  --> https://bugs.freedesktop.org/attachment.cgi?id=73868&action=edit
worse case from cold boot

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1291 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 323 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #2 from Andy Furniss <lists@andyfurniss.entadsl.com> ---
Created attachment 73869
  --> https://bugs.freedesktop.org/attachment.cgi?id=73869&action=edit
best case after repeated runs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1303 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 424 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

Andy Furniss <lists@andyfurniss.entadsl.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73869|text/plain                  |image/png
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1109 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 382 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #3 from Andy Furniss <lists@andyfurniss.entadsl.com> ---
Comment on attachment 73868
  --> https://bugs.freedesktop.org/attachment.cgi?id=73868
worse case from cold boot

Ignore low fps on this compared to other screen - the card was on low.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1366 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 312 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #4 from Jerome Glisse <glisse@freedesktop.org> ---
Please update mesa again a bunch of fixes were push. Make sure you have up to :
e1598cb642334c809e6ec219d793e7bc85a213de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1137 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 388 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #5 from Andy Furniss <lists@andyfurniss.entadsl.com> ---
(In reply to comment #4)
> Please update mesa again a bunch of fixes were push. Make sure you have up
> to :
> e1598cb642334c809e6ec219d793e7bc85a213de

I am still seeing it on current head.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1295 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 385 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #6 from Jerome Glisse <glisse@freedesktop.org> ---
Can you capture a trace using https://github.com/apitrace/apitrace your
distribution might have package for it. Also try to make the trace as small as
possible by jumping directly to the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1261 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 848 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #7 from Andy Furniss <lists@andyfurniss.entadsl.com> ---
(In reply to comment #6)
> Can you capture a trace using https://github.com/apitrace/apitrace your
> distribution might have package for it. Also try to make the trace as small
> as possible by jumping directly to the issue.

Well I got one but it's 186 meg compressed.

That's as small as I can get it - made a demo where you can see the issue and
then loaded it directly from command line +exec a_script thus bypassing the 3D
menu screen and made the game quit after rendering just 5 frames (1 isn't any
better).

I guess the screen while the map is (slowly) loading is accounting for a lot of
the data.

Do you have somewhere I can upload 186 meg?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1806 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 424 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #8 from Andy Furniss <lists@andyfurniss.entadsl.com> ---
Created attachment 74016
  --> https://bugs.freedesktop.org/attachment.cgi?id=74016&action=edit
compressed text output from etqw apitrace dump

If it's just the output of apitrace dump that's needed then this is a lot
smaller.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1438 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 360 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #9 from Jerome Glisse <glisse@freedesktop.org> ---
No it's the trace that's needed. You can try on some of those free file hosting
otherwise you can dcc send it to me on irc (freenode glisse) and i will put it
somewhere

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1185 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 456 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #10 from Andy Furniss <lists@andyfurniss.entadsl.com> ---
(In reply to comment #9)
> No it's the trace that's needed. You can try on some of those free file
> hosting otherwise you can dcc send it to me on irc (freenode glisse) and i
> will put it somewhere

Here it is -

http://www.andyqos.ukfsn.org/etqw-trace.xz

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1421 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 357 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #11 from Jerome Glisse <glisse@freedesktop.org> ---
Created attachment 74200
  --> https://bugs.freedesktop.org/attachment.cgi?id=74200&action=edit
work around

Can you check that this work around fix the rendering ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1380 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 597 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #12 from Andy Furniss <lists@andyfurniss.entadsl.com> ---
(In reply to comment #11)
> Created attachment 74200 [details] [review]
> work around
> 
> Can you check that this work around fix the rendering ?

Yes, this fixes etqw for me.

I see someone else reported an issue with this commit and xonotic.

I haven't checked if xonotic was OK before, but I can see the issue and this
patch does not help it.

https://bugs.freedesktop.org/show_bug.cgi?id=60236

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1977 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 334 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #13 from Jerome Glisse <glisse@freedesktop.org> ---
Created attachment 74299
  --> https://bugs.freedesktop.org/attachment.cgi?id=74299&action=edit
Fix

Do this fix the etqw issue for you too ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1341 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 359 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #14 from Andy Furniss <lists@andyfurniss.entadsl.com> ---
(In reply to comment #13)
> Created attachment 74299 [details] [review]
> Fix
> 
> Do this fix the etqw issue for you too ?

Yes it fixes etqw, but not xonotic.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1513 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 238 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

--- Comment #15 from Jerome Glisse <glisse@freedesktop.org> ---
I attached fix for xonotic to the xonotic bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1064 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 60034] rv790 etqw regression since r600g: add async for staging buffer upload v2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 524 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=60034

Jerome Glisse <glisse@freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Jerome Glisse <glisse@freedesktop.org> ---
Fix pushed upstream closing this one

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2066 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel