From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 74868] r600g: Diablo III Crashes After a few minutes Date: Sat, 29 Mar 2014 20:44:24 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0171227293==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id D897289D40 for ; Sat, 29 Mar 2014 13:44:23 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0171227293== Content-Type: multipart/alternative; boundary="1396125863.fbA640.3004"; charset="us-ascii" --1396125863.fbA640.3004 Date: Sat, 29 Mar 2014 20:44:23 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=74868 --- Comment #17 from Nick Tenney --- (In reply to comment #14) > Created attachment 95909 [details] [review] > r600g: Don't leak bytecode on shader compile failure > > Does this patch help? Finally had a chance to test the patch. I compiled this morning with and without the patch and GALLIUM_HUD=fps,requested-VRAM,requested-GTT. It clearly leaked away without and the flow was stemmed with the proper error handling patch. Awesome! I see that the patch properly destroys the shader on error now, which is definitely an improvement. The error spamming to stdout is still occurring, so I'm not sure whether that should be another bug report/left open in this one with a new name or anything. -- You are receiving this mail because: You are the assignee for the bug. --1396125863.fbA640.3004 Date: Sat, 29 Mar 2014 20:44:23 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 17 on bug 74868 from 
(In reply to comment #14)
> Created attachment 95909 [details] [review] [review]
> r600g: Don't leak bytecode on shader compile failure
> 
> Does this patch help?

Finally had a chance to test the patch. I compiled this morning with and
without the patch and GALLIUM_HUD=fps,requested-VRAM,requested-GTT. It clearly
leaked away without and the flow was stemmed with the proper error handling
patch. Awesome!

I see that the patch properly destroys the shader on error now, which is
definitely an improvement. The error spamming to stdout is still occurring, so
I'm not sure whether that should be another bug report/left open in this one
with a new name or anything.

You are receiving this mail because:
  • You are the assignee for the bug.
--1396125863.fbA640.3004-- --===============0171227293== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0171227293==--