* [dpdk-dev] [Bug 774] Potential deadlock error due to the unrelased lock
@ 2021-08-04 16:55 bugzilla
0 siblings, 0 replies; only message in thread
From: bugzilla @ 2021-08-04 16:55 UTC (permalink / raw)
To: dev
https://bugs.dpdk.org/show_bug.cgi?id=774
Bug ID: 774
Summary: Potential deadlock error due to the unrelased lock
Product: DPDK
Version: 21.08
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: dg573847474@gmail.com
Target Milestone: ---
source:
dpdk/drivers/net/mlx5/mlx5_txpp.c
Hi, developers, thank you for your checking. The lock &sh->txpp.mutex may be
not released correctly the method returns at the branch !sh->txpp.refcnt ||
--sh->txpp.refcnt satisfies. The fix is to insert
pthread_mutex_lock(&sh->txpp.mutex); before returning.
void
mlx5_txpp_stop(struct rte_eth_dev *dev)
{
struct mlx5_priv *priv = dev->data->dev_private;
struct mlx5_dev_ctx_shared *sh = priv->sh;
int ret;
if (!priv->txpp_en) {
return;
}
priv->txpp_en = 0;
ret = pthread_mutex_lock(&sh->txpp.mutex); // the lock
MLX5_ASSERT(!ret);
RTE_SET_USED(ret);
MLX5_ASSERT(sh->txpp.refcnt);
if (!sh->txpp.refcnt || --sh->txpp.refcnt)
return; // return without releasing
mlx5_txpp_destroy(sh);
ret = pthread_mutex_unlock(&sh->txpp.mutex);
MLX5_ASSERT(!ret);
RTE_SET_USED(ret);
}
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-08-04 16:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-04 16:55 [dpdk-dev] [Bug 774] Potential deadlock error due to the unrelased lock bugzilla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.