From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 82671] New: [r600g-evergreen][compute]Empty kernel execution causes crash Date: Fri, 15 Aug 2014 17:57:43 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0129509649==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 226156E215 for ; Fri, 15 Aug 2014 10:57:43 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0129509649== Content-Type: multipart/alternative; boundary="1408125463.f5410D60.29867"; charset="us-ascii" --1408125463.f5410D60.29867 Date: Fri, 15 Aug 2014 17:57:42 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=82671 Priority: medium Bug ID: 82671 Assignee: dri-devel@lists.freedesktop.org Summary: [r600g-evergreen][compute]Empty kernel execution causes crash Severity: normal Classification: Unclassified OS: Linux (All) Reporter: damien.hilloulin@supelec.fr Hardware: All Status: NEW Version: git Component: Drivers/Gallium/r600 Product: Mesa Created attachment 104687 --> https://bugs.freedesktop.org/attachment.cgi?id=104687&action=edit Bug repro program source file I gave a shot to opencl support on my evergreen card (cedar) with mesa git. I noticed that with an empty kernel the program crash with: evergreen_state.c:1827:evergreen_emit_vertex_buffers: Assertion `rbuffer' failed. I made a little debugging and I think that this is du to a bug in evergreen_init_compute_state_functions from evergreen_compute.c . The two concerned lines are /* We always use at least one vertex buffer for parameters (id = 1)*/ ctx->cs_vertex_buffer_state.enabled_mask = ctx->cs_vertex_buffer_state.dirty_mask = 0x2; With an empty kernel there is in fact no vertex buffer used as far as I can see. By changing the two lines to ctx->cs_vertex_buffer_state.enabled_mask = ctx->cs_vertex_buffer_state.dirty_mask = 0x0; It doesn't crash for me anymore. However I am a total driver development noob so my interpretation (and therefore fix) can be wrong. You can find attacted the very small program to be able to cause the crash. -- You are receiving this mail because: You are the assignee for the bug. --1408125463.f5410D60.29867 Date: Fri, 15 Aug 2014 17:57:43 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"
Priority medium
Bug ID 82671
Assignee dri-devel@lists.freedesktop.org
Summary [r600g-evergreen][compute]Empty kernel execution causes crash
Severity normal
Classification Unclassified
OS Linux (All)
Reporter damien.hilloulin@supelec.fr
Hardware All
Status NEW
Version git
Component Drivers/Gallium/r600
Product Mesa

Created attachment 104687 [details]
Bug repro program source file

I gave a shot to opencl support on my evergreen card (cedar) with mesa git.
I noticed that with an empty kernel the program crash with:
evergreen_state.c:1827:evergreen_emit_vertex_buffers: Assertion `rbuffer'
failed.

I made a little debugging and I think that this is du to a bug in
evergreen_init_compute_state_functions from evergreen_compute.c .

The two concerned lines are

/* We always use at least one vertex buffer for parameters (id = 1)*/
ctx->cs_vertex_buffer_state.enabled_mask =
ctx->cs_vertex_buffer_state.dirty_mask = 0x2;

With an empty kernel there is in fact no vertex buffer used as far as I can
see.

By changing the two lines to
ctx->cs_vertex_buffer_state.enabled_mask =
ctx->cs_vertex_buffer_state.dirty_mask = 0x0;

It doesn't crash for me anymore.
However I am a total driver development noob so my interpretation (and
therefore fix) can be wrong.

You can find attacted the very small program to be able to cause the crash.


You are receiving this mail because:
  • You are the assignee for the bug.
--1408125463.f5410D60.29867-- --===============0129509649== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0129509649==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 82671] [r600g-evergreen][compute]Empty kernel execution causes crash Date: Tue, 19 Aug 2014 23:34:15 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0438910356==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 78D596E65E for ; Tue, 19 Aug 2014 16:34:15 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0438910356== Content-Type: multipart/alternative; boundary="1408491255.6da5FE0.18503"; charset="us-ascii" --1408491255.6da5FE0.18503 Date: Tue, 19 Aug 2014 23:34:15 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=82671 --- Comment #1 from Tom Stellard --- Created attachment 104927 --> https://bugs.freedesktop.org/attachment.cgi?id=104927&action=edit Fix Can you try this patch? -- You are receiving this mail because: You are the assignee for the bug. --1408491255.6da5FE0.18503 Date: Tue, 19 Aug 2014 23:34:15 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 1 on bug 82671 from
Created attachment 104927 [details] [review]
Fix

Can you try this patch?


You are receiving this mail because:
  • You are the assignee for the bug.
--1408491255.6da5FE0.18503-- --===============0438910356== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0438910356==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 82671] [r600g-evergreen][compute]Empty kernel execution causes crash Date: Wed, 20 Aug 2014 15:31:31 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0218677114==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 49B2F6E70C for ; Wed, 20 Aug 2014 08:31:31 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0218677114== Content-Type: multipart/alternative; boundary="1408548691.C2814E0.5603"; charset="us-ascii" --1408548691.C2814E0.5603 Date: Wed, 20 Aug 2014 15:31:31 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=82671 --- Comment #2 from Damien Hilloulin --- Fix the bug for me :) Thank you for giving a look at this bug! -- You are receiving this mail because: You are the assignee for the bug. --1408548691.C2814E0.5603 Date: Wed, 20 Aug 2014 15:31:31 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 2 on bug 82671 from
Fix the bug for me :)

Thank you for giving a look at this bug!


You are receiving this mail because:
  • You are the assignee for the bug.
--1408548691.C2814E0.5603-- --===============0218677114== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0218677114==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 82671] [r600g-evergreen][compute]Empty kernel execution causes crash Date: Thu, 21 Aug 2014 14:08:47 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1504603576==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 77B626E082 for ; Thu, 21 Aug 2014 07:08:47 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1504603576== Content-Type: multipart/alternative; boundary="1408630127.5baAE420.1930"; charset="us-ascii" --1408630127.5baAE420.1930 Date: Thu, 21 Aug 2014 14:08:47 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=82671 Tom Stellard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Tom Stellard --- Fixed in git commit commit bf7a60f41d897be4d9804ba7c46633e38501ffe7 -- You are receiving this mail because: You are the assignee for the bug. --1408630127.5baAE420.1930 Date: Thu, 21 Aug 2014 14:08:47 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" changed bug 82671
What Removed Added
Status NEW RESOLVED
Resolution --- FIXED

Comment # 3 on bug 82671 from
Fixed in git commit commit bf7a60f41d897be4d9804ba7c46633e38501ffe7


You are receiving this mail because:
  • You are the assignee for the bug.
--1408630127.5baAE420.1930-- --===============1504603576== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1504603576==--