From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org Subject: [Bug 90887] PhiMovesPass in register allocator broken Date: Fri, 21 Aug 2015 20:34:46 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1168861230==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org --===============1168861230== Content-Type: multipart/alternative; boundary="1440189286.7C7AbF72.31313"; charset="UTF-8" --1440189286.7C7AbF72.31313 Date: Fri, 21 Aug 2015 20:34:46 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=90887 --- Comment #30 from jr --- (In reply to Ilia Mirkin from comment #29) > Hmmmm... maybe it was one of my local patches? I'll try to figure out what > went wrong later tonight. > > I added logic to be clever about edge types... when splitting an edge, the > type should remain except a forward edge becomes a cross edge. (You can do > it out on paper...) Perhaps that upset things? It doesn't seem like codegen > is using those terms in the usual MST meanings :( I did take a look at the edge classification. Cannot say I fully understand the implications yet, but I'm wondering whether the logic in Graph::classifyDFS is correct. Shouldn't the condition for FORWARD edge whenn looping over incoming edges (the second loop) be reversed? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. --1440189286.7C7AbF72.31313 Date: Fri, 21 Aug 2015 20:34:46 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 30 on bug 90887 from 
(In reply to Ilia Mirkin from comment #29)
> Hmmmm... maybe it was one of my local patches? I'll try to figure out what
> went wrong later tonight.
> 
> I added logic to be clever about edge types... when splitting an edge, the
> type should remain except a forward edge becomes a cross edge. (You can do
> it out on paper...) Perhaps that upset things? It doesn't seem like codegen
> is using those terms in the usual MST meanings :(

I did take a look at the edge classification. Cannot say I fully understand the
implications yet, but I'm wondering whether the logic in Graph::classifyDFS is
correct. Shouldn't the condition for FORWARD edge whenn looping over incoming
edges (the second loop) be reversed?

You are receiving this mail because:
  • You are the QA Contact for the bug.
  • You are the assignee for the bug.
--1440189286.7C7AbF72.31313-- --===============1168861230== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTm91dmVhdSBt YWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUK --===============1168861230==--