From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org Subject: [Bug 90887] PhiMovesPass in register allocator broken Date: Sun, 28 Jun 2015 08:37:02 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1050034273==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org --===============1050034273== Content-Type: multipart/alternative; boundary="1435480622.aC133.27095"; charset="UTF-8" --1435480622.aC133.27095 Date: Sun, 28 Jun 2015 08:37:02 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=90887 --- Comment #18 from Ilia Mirkin --- (In reply to Ilia Mirkin from comment #17) > Created attachment 116761 [details] [review] > another attempt > > OK, I like this a bit better since it doesn't use any weird maps, and incurs > minimal costs in the common case. It unfortunately encodes the graph's > insertion strategy, but... meh. Ugh, actually this patch won't work. It needs to be phi->setSrc(j, tmp); but then I lose the "old" phi source. So perhaps the map approach is ~required :( -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. --1435480622.aC133.27095 Date: Sun, 28 Jun 2015 08:37:02 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 18 on bug 90887 from 
(In reply to Ilia Mirkin from comment #17)
> Created attachment 116761 [details] [review] [review]
> another attempt
> 
> OK, I like this a bit better since it doesn't use any weird maps, and incurs
> minimal costs in the common case. It unfortunately encodes the graph's
> insertion strategy, but... meh.

Ugh, actually this patch won't work. It needs to be

         phi->setSrc(j, tmp);

but then I lose the "old" phi source. So perhaps the map approach is ~required
:(

You are receiving this mail because:
  • You are the QA Contact for the bug.
  • You are the assignee for the bug.
--1435480622.aC133.27095-- --===============1050034273== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTm91dmVhdSBt YWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUK --===============1050034273==--