Commen=
t # 11
on bug 91808<=
/a>
from Dave Airlie
Created attachment 139029
References:
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0060630723=="
Return-path:
Received: from culpepper.freedesktop.org (culpepper.freedesktop.org
[IPv6:2610:10:20:722:a800:ff:fe98:4b55])
by gabe.freedesktop.org (Postfix) with ESMTP id 674166E34D
for ; Tue, 24 Apr 2018 06:34:11 +0000 (UTC)
In-Reply-To:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org
--===============0060630723==
Content-Type: multipart/alternative; boundary="15245516512.7c0Fc3.13028"
Content-Transfer-Encoding: 7bit
--15245516512.7c0Fc3.13028
Date: Tue, 24 Apr 2018 06:34:11 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
https://bugs.freedesktop.org/show_bug.cgi?id=3D91808
--- Comment #12 from Hamish Wilson ---
(In reply to Dave Airlie from comment #11)
> Created attachment 139029 [details] [review]
> attempted fix
I have tried applying the patch to my Mesa package using the Arch Build Sys=
tem,
but unfortunately it does not appear to have corrected the artifacts.
--=20
You are receiving this mail because:
You are the assignee for the bug.=
--15245516512.7c0Fc3.13028
Date: Tue, 24 Apr 2018 06:34:11 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
You are receiving this mail because:
- You are the assignee for the bug.
=
--15245516512.7c0Fc3.13028--
--===============0060630723==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==
--===============0060630723==--
From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@freedesktop.org
Subject: [Bug 91808] trine1 misrender r600g
Date: Fri, 27 Apr 2018 06:48:13 +0000
Message-ID:
References:
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1253490982=="
Return-path:
Received: from culpepper.freedesktop.org (culpepper.freedesktop.org
[IPv6:2610:10:20:722:a800:ff:fe98:4b55])
by gabe.freedesktop.org (Postfix) with ESMTP id 621FB6E3B9
for ; Fri, 27 Apr 2018 06:48:13 +0000 (UTC)
In-Reply-To:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org
--===============1253490982==
Content-Type: multipart/alternative; boundary="15248116931.0B5A0C7b7.3692"
Content-Transfer-Encoding: 7bit
--15248116931.0B5A0C7b7.3692
Date: Fri, 27 Apr 2018 06:48:13 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
https://bugs.freedesktop.org/show_bug.cgi?id=3D91808
--- Comment #13 from Dave Airlie ---
Just adding some things I've tried to fix this to no avail.
use RECIP_FF/CLAMPED instead of RECIP_IEEE
use RECIPSQRT_FF/CLAMPED instead of RECIPSQRT_IEEE
use MUL/MULADD/DOT4 instead of IEEE
Split constants into DOT4, rewrote DOT4 output to go via another register.
Disable scaled 16-bit float vertices, this change the misrendering to somet=
hing
worse for some reason.
I've noticed the broken drawing operations are the same vbo/ib with a diffe=
rent
set of constant values for VS constants 124-126, the first draw works and d=
raws
the inside gear, the second draw to draw the outside gear fails.
I considered then it might be constant caching or vertex caching since we u=
se
vfetch to fetch the consts, tried add more flushing between draws, tried us=
ing
uncached descriptor for constant buffer.
Nothing above has fixed it, merely logging it for my own sanity at this poi=
nt.
--=20
You are receiving this mail because:
You are the assignee for the bug.=
--15248116931.0B5A0C7b7.3692
Date: Fri, 27 Apr 2018 06:48:13 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
Commen=
t # 13
on bug 91808<=
/a>
from Dave Airlie
Just adding some things I've tried to fix this to no avail.
use RECIP_FF/CLAMPED instead of RECIP_IEEE
use RECIPSQRT_FF/CLAMPED instead of RECIPSQRT_IEEE
use MUL/MULADD/DOT4 instead of IEEE
Split constants into DOT4, rewrote DOT4 output to go via another register.
Disable scaled 16-bit float vertices, this change the misrendering to somet=
hing
worse for some reason.
I've noticed the broken drawing operations are the same vbo/ib with a diffe=
rent
set of constant values for VS constants 124-126, the first draw works and d=
raws
the inside gear, the second draw to draw the outside gear fails.
I considered then it might be constant caching or vertex caching since we u=
se
vfetch to fetch the consts, tried add more flushing between draws, tried us=
ing
uncached descriptor for constant buffer.
Nothing above has fixed it, merely logging it for my own sanity at this poi=
nt.
You are receiving this mail because:
- You are the assignee for the bug.
=
--15248116931.0B5A0C7b7.3692--
--===============1253490982==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==
--===============1253490982==--
From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@freedesktop.org
Subject: [Bug 91808] trine1 misrender r600g
Date: Wed, 09 May 2018 05:45:00 +0000
Message-ID:
References:
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0598978764=="
Return-path:
Received: from culpepper.freedesktop.org (culpepper.freedesktop.org
[IPv6:2610:10:20:722:a800:ff:fe98:4b55])
by gabe.freedesktop.org (Postfix) with ESMTP id 5CD416EC2A
for ; Wed, 9 May 2018 05:45:00 +0000 (UTC)
In-Reply-To:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org
--===============0598978764==
Content-Type: multipart/alternative; boundary="15258447001.Cf2aE47b.26642"
Content-Transfer-Encoding: 7bit
--15258447001.Cf2aE47b.26642
Date: Wed, 9 May 2018 05:45:00 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
https://bugs.freedesktop.org/show_bug.cgi?id=3D91808
Dave Airlie changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #139029|0 |1
is obsolete| |
--- Comment #14 from Dave Airlie ---
Created attachment 139438
--> https://bugs.freedesktop.org/attachment.cgi?id=3D139438&action=3Dedit
clamp constant buffer data
This looks a lot better to me!
--=20
You are receiving this mail because:
You are the assignee for the bug.=
--15258447001.Cf2aE47b.26642
Date: Wed, 9 May 2018 05:45:00 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
Dave Airlie
changed
bug 91808<=
/a>
| What |
Removed |
Added |
| Attachment #139029 is obsolete
|
|
1
|
You are receiving this mail because:
- You are the assignee for the bug.
=
--15258447001.Cf2aE47b.26642--
--===============0598978764==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==
--===============0598978764==--
From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@freedesktop.org
Subject: [Bug 91808] trine1 misrender r600g
Date: Wed, 09 May 2018 15:02:26 +0000
Message-ID:
References:
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0463228756=="
Return-path:
Received: from culpepper.freedesktop.org (culpepper.freedesktop.org
[IPv6:2610:10:20:722:a800:ff:fe98:4b55])
by gabe.freedesktop.org (Postfix) with ESMTP id C72916ED4A
for ; Wed, 9 May 2018 15:02:26 +0000 (UTC)
In-Reply-To:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org
--===============0463228756==
Content-Type: multipart/alternative; boundary="15258781462.A4dfD627D.6547"
Content-Transfer-Encoding: 7bit
--15258781462.A4dfD627D.6547
Date: Wed, 9 May 2018 15:02:26 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
https://bugs.freedesktop.org/show_bug.cgi?id=3D91808
--- Comment #15 from iive@yahoo.com ---
Looks perfect to me. The shadow flickering is also gone.
Tested with the real game on "lowest" and "very high" settings.
In addition, it also seems to fix the witcher1 trace too.
Can you give a long explanation what was the root of the problem.
I do see it is about the size of the constant buffer.
--=20
You are receiving this mail because:
You are the assignee for the bug.=
--15258781462.A4dfD627D.6547
Date: Wed, 9 May 2018 15:02:26 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
Commen=
t # 15
on bug 91808<=
/a>
from iive@yahoo.com
Looks perfect to me. The shadow flickering is also gone.
Tested with the real game on "lowest" and "very high" s=
ettings.
In addition, it also seems to fix the witcher1 trace too.
Can you give a long explanation what was the root of the problem.
I do see it is about the size of the constant buffer.
You are receiving this mail because:
- You are the assignee for the bug.
=
--15258781462.A4dfD627D.6547--
--===============0463228756==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==
--===============0463228756==--
From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@freedesktop.org
Subject: [Bug 91808] trine1 misrender r600g
Date: Thu, 10 May 2018 01:16:02 +0000
Message-ID:
References:
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1790578598=="
Return-path:
Received: from culpepper.freedesktop.org (culpepper.freedesktop.org
[IPv6:2610:10:20:722:a800:ff:fe98:4b55])
by gabe.freedesktop.org (Postfix) with ESMTP id 4B6D66EDE5
for ; Thu, 10 May 2018 01:16:02 +0000 (UTC)
In-Reply-To:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org
--===============1790578598==
Content-Type: multipart/alternative; boundary="15259149622.2EfF2fA.28211"
Content-Transfer-Encoding: 7bit
--15259149622.2EfF2fA.28211
Date: Thu, 10 May 2018 01:16:02 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
https://bugs.freedesktop.org/show_bug.cgi?id=3D91808
Dave Airlie changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #16 from Dave Airlie ---
The fix is pushed in master.
The code wasn't limiting the constant buffer sizing correctly so it was
accessing random values from other operations rather than limiting things to
the constants for this draw. So out of bounds accesses weren't returning
default values but random ones.
--=20
You are receiving this mail because:
You are the assignee for the bug.=
--15259149622.2EfF2fA.28211
Date: Thu, 10 May 2018 01:16:02 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
Dave Airlie
changed
bug 91808<=
/a>
| What |
Removed |
Added |
| Resolution |
---
|
FIXED
|
| Status |
NEW
|
RESOLVED
|
Commen=
t # 16
on bug 91808<=
/a>
from Dave Airlie
The fix is pushed in master.
The code wasn't limiting the constant buffer sizing correctly so it was
accessing random values from other operations rather than limiting things to
the constants for this draw. So out of bounds accesses weren't returning
default values but random ones.
You are receiving this mail because:
- You are the assignee for the bug.
=
--15259149622.2EfF2fA.28211--
--===============1790578598==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==
--===============1790578598==--
From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@freedesktop.org
Subject: [Bug 91808] trine1 misrender r600g
Date: Sun, 13 May 2018 07:12:11 +0000
Message-ID:
References:
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1211604939=="
Return-path:
Received: from culpepper.freedesktop.org (culpepper.freedesktop.org
[IPv6:2610:10:20:722:a800:ff:fe98:4b55])
by gabe.freedesktop.org (Postfix) with ESMTP id 2399A6E0DA
for ; Sun, 13 May 2018 07:12:12 +0000 (UTC)
In-Reply-To:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org
--===============1211604939==
Content-Type: multipart/alternative; boundary="15261955320.191d206f.26796"
Content-Transfer-Encoding: 7bit
--15261955320.191d206f.26796
Date: Sun, 13 May 2018 07:12:12 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
https://bugs.freedesktop.org/show_bug.cgi?id=3D91808
Roman Elshin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |roman.elshin@gmail.com
--- Comment #17 from Roman Elshin ---
*** Bug 99403 has been marked as a duplicate of this bug. ***
--=20
You are receiving this mail because:
You are the assignee for the bug.=
--15261955320.191d206f.26796
Date: Sun, 13 May 2018 07:12:12 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
Roman Elshin
changed
bug 91808<=
/a>
| What |
Removed |
Added |
| CC |
|
roman.elshin@gmail.com
|
You are receiving this mail because:
- You are the assignee for the bug.
=
--15261955320.191d206f.26796--
--===============1211604939==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==
--===============1211604939==--