From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 97305] Wrong values returned by GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT & GL_TEXTURE_BUFFER_OFFSET_ALIGNMENT randomly breaks stuff Date: Thu, 11 Aug 2016 22:50:41 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0882249638==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 131AD6EA16 for ; Thu, 11 Aug 2016 22:50:41 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0882249638== Content-Type: multipart/alternative; boundary="14709558410.71D5.9101"; charset="UTF-8" --14709558410.71D5.9101 Date: Thu, 11 Aug 2016 22:50:41 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D97305 --- Comment #11 from Ilia Mirkin --- (In reply to Marek Ol=C5=A1=C3=A1k from comment #10) > (In reply to Ilia Mirkin from comment #9) > > (In reply to Marek Ol=C5=A1=C3=A1k from comment #5) > > > Pre-GCN cards require an alignment of 256 bytes for uniform buffers. = GCN > > > cards only require 4 byte alignment there. > > >=20 > > > All other buffer binding points require 1, 2, or 4 bytes depending on= the > > > texel size. It's really min(texel_size, 4). > >=20 > > That means that you have to return max(texel_size) for the > > GL_TEXTURE_BUFFER_OFFSET_ALIGNMENT. You only get one cap, and a texture > > buffer can be any offset. >=20 > That's what we already do. You return 4. However that's not enough if I set the format to GL_RGBA32I. There's no provision in the spec to disallow someone feeding you a aligned-= to-4 buffer with GL_RGBA32I format if you return "4" as the value. Oh, unless I totally misunderstood what you were saying, and that situation should work. In which case, apologies for the noise. --=20 You are receiving this mail because: You are the assignee for the bug.= --14709558410.71D5.9101 Date: Thu, 11 Aug 2016 22:50:41 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 11 on bug 97305<= /a> from Ilia Mirkin 
(In reply to Marek Ol=C5=A1=C3=A1k from comment #10)
> (In reply to Ilia Mirkin from comment #9)
> > (In reply to Marek Ol=C5=A1=C3=A1k from comment #5)
> > > Pre-GCN cards require an alignment of 256 bytes for uniform =
buffers. GCN
> > > cards only require 4 byte alignment there.
> > >=20
> > > All other buffer binding points require 1, 2, or 4 bytes dep=
ending on the
> > > texel size. It's really min(texel_size, 4).
> >=20
> > That means that you have to return max(texel_size) for the
> > GL_TEXTURE_BUFFER_OFFSET_ALIGNMENT. You only get one cap, and a t=
exture
> > buffer can be any offset.
>=20
> That's what we already do.

You return 4. However that's not enough if I set the format to GL_RGBA32I.
There's no provision in the spec to disallow someone feeding you a aligned-=
to-4
buffer with GL_RGBA32I format if you return "4" as the value.

Oh, unless I totally misunderstood what you were saying, and that situation
should work. In which case, apologies for the noise.

You are receiving this mail because:
  • You are the assignee for the bug.
= --14709558410.71D5.9101-- --===============0882249638== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0882249638==--