From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 98005] VCE dual instance encoding inconsistent since st/va: enable dual instances encode by sync surface Date: Thu, 10 Nov 2016 23:35:44 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0810609759==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 06E576E83D for ; Thu, 10 Nov 2016 23:35:44 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0810609759== Content-Type: multipart/alternative; boundary="14788209430.fcEE3F.28933"; charset="UTF-8" --14788209430.fcEE3F.28933 Date: Thu, 10 Nov 2016 23:35:43 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D98005 --- Comment #7 from Andy Furniss --- (In reply to Boyuan Zhang from comment #6) > Hi Andy, >=20 > I just submitted 2 reviews for fixing the bit-rate issue. The 2 patches c= an > be found at > https://lists.freedesktop.org/archives/mesa-dev/2016-November/134944.html >=20 > 0001-st/va: force to submit two consecutive single jobs > 0002-st/va: fix gop size for rate control >=20 > Please give a try and let me know how it works. >=20 > Regards, > Boyuan Hi, I can't get those to apply to current mesa head. Checking patch src/gallium/state_trackers/va/picture.c... Hunk #1 succeeded at 413 (offset 1 line). Hunk #2 succeeded at 568 (offset 1 line). Checking patch src/gallium/state_trackers/va/surface.c... error: while searching for: if (context->decoder->entrypoint =3D=3D PIPE_VIDEO_ENTRYPOINT_ENCODE) { int frame_diff; if (context->desc.h264enc.frame_num_cnt > surf->frame_num_cnt) frame_diff =3D context->desc.h264enc.frame_num_cnt - surf->frame_num_cnt; else frame_diff =3D 0xFFFFFFFF - surf->frame_num_cnt + 1 + context->desc.h264enc.frame_num_cnt; if (frame_diff < 2) context->decoder->flush(context->decoder); context->decoder->get_feedback(context->decoder, surf->feedback, &(surf->coded_buf->coded_size)); } pipe_mutex_unlock(drv->mutex); error: patch failed: src/gallium/state_trackers/va/surface.c:119 error: src/gallium/state_trackers/va/surface.c: patch does not apply Checking patch src/gallium/state_trackers/va/va_private.h... Hunk #2 succeeded at 275 (offset 1 line). and Checking patch src/gallium/state_trackers/va/picture.c... Hunk #1 succeeded at 351 (offset 1 line). error: while searching for: context->desc.h264enc.not_referenced =3D false; context->desc.h264enc.is_idr =3D (h264->pic_fields.bits.idr_pic_flag =3D= =3D 1); context->desc.h264enc.pic_order_cnt =3D h264->CurrPic.TopFieldOrderCnt /= 2; if (context->desc.h264enc.is_idr) context->desc.h264enc.i_remain =3D 1; else context->desc.h264enc.i_remain =3D 0; context->desc.h264enc.p_remain =3D context->desc.h264enc.gop_size - context->desc.h264enc.gop_cnt - context->desc.h264enc.i_remain; error: patch failed: src/gallium/state_trackers/va/picture.c:390 error: src/gallium/state_trackers/va/picture.c: patch does not apply Checking patch src/gallium/state_trackers/va/va_private.h... --=20 You are receiving this mail because: You are the assignee for the bug.= --14788209430.fcEE3F.28933 Date: Thu, 10 Nov 2016 23:35:43 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comment= # 7 on bug 98005<= /a> from Andy Furniss
(In reply to Boyuan Zhang from comment #6)
> Hi Andy,
>=20
> I just submitted 2 reviews for fixing the bit-rate issue. The 2 patche=
s can
> be found at
> https://lists.freedesktop.org/archives/mesa-dev/2016-Novemb=
er/134944.html
>=20
> 0001-st/va: force to submit two consecutive single jobs
> 0002-st/va: fix gop size for rate control
>=20
> Please give a try and let me know how it works.
>=20
> Regards,
> Boyuan

Hi, I can't get those to apply to current mesa head.

Checking patch src/gallium/state_trackers/va/picture.c...
Hunk #1 succeeded at 413 (offset 1 line).
Hunk #2 succeeded at 568 (offset 1 line).
Checking patch src/gallium/state_trackers/va/surface.c...
error: while searching for:

   if (context->decoder->entrypoint =3D=3D PIPE_VIDEO_ENTRYPOINT_ENCO=
DE) {
      int frame_diff;
      if (context->desc.h264enc.frame_num_cnt > surf->frame_num_cn=
t)
         frame_diff =3D context->desc.h264enc.frame_num_cnt -
surf->frame_num_cnt;
      else
         frame_diff =3D 0xFFFFFFFF - surf->frame_num_cnt + 1 +
context->desc.h264enc.frame_num_cnt;
      if (frame_diff < 2)
         context->decoder->flush(context->decoder);
      context->decoder->get_feedback(context->decoder, surf->fe=
edback,
&(surf->coded_buf->coded_size));
   }
   pipe_mutex_unlock(drv->mutex);

error: patch failed: src/gallium/state_trackers/va/surface.c:119
error: src/gallium/state_trackers/va/surface.c: patch does not apply
Checking patch src/gallium/state_trackers/va/va_private.h...
Hunk #2 succeeded at 275 (offset 1 line).

and

Checking patch src/gallium/state_trackers/va/picture.c...
Hunk #1 succeeded at 351 (offset 1 line).
error: while searching for:
   context->desc.h264enc.not_referenced =3D false;
   context->desc.h264enc.is_idr =3D (h264->pic_fields.bits.idr_pic_fl=
ag =3D=3D 1);
   context->desc.h264enc.pic_order_cnt =3D h264->CurrPic.TopFieldOrde=
rCnt / 2;
   if (context->desc.h264enc.is_idr)
      context->desc.h264enc.i_remain =3D 1;
   else
      context->desc.h264enc.i_remain =3D 0;

   context->desc.h264enc.p_remain =3D context->desc.h264enc.gop_size -
context->desc.h264enc.gop_cnt - context->desc.h264enc.i_remain;


error: patch failed: src/gallium/state_trackers/va/picture.c:390
error: src/gallium/state_trackers/va/picture.c: patch does not apply
Checking patch src/gallium/state_trackers/va/va_private.h...


You are receiving this mail because:
  • You are the assignee for the bug.
= --14788209430.fcEE3F.28933-- --===============0810609759== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0810609759==--