All of lore.kernel.org
 help / color / mirror / Atom feed
* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground
@ 2016-11-17 16:37 bugzilla-daemon
  2016-11-17 16:44 ` bugzilla-daemon
                   ` (23 more replies)
  0 siblings, 24 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-17 16:37 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 2950 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

            Bug ID: 98761
           Summary: [regression][radeonsi][polaris]"radeonsi: set
                    IF_THRESHOLD to 3" breaks Wither2's ground
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: arek.rusi@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 128044
  --> https://bugs.freedesktop.org/attachment.cgi?id=128044&action=edit
ground looks weird

mesa/llvm git/trunk
kernel 4.8.x & drm-next-4.10-wip

this is happend on polaris(rx470)
verde works corectly (for radeon drv, amdgpu not tested yet)


bisected:
74e39de9324d2d2333cda6adca50ae2a3fc36de2 is the first bad commit
commit 74e39de9324d2d2333cda6adca50ae2a3fc36de2
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Fri Oct 28 23:08:50 2016 +0200

    radeonsi: set IF_THRESHOLD to 3

    Piglit regressions (radeonsi or LLVM bugs, they pass on softpipe):
    - glsl-1.10/execution/variable-indexing/vs-output-array-vec3-index-wr
    - glsl-1.10/execution/variable-indexing/vs-output-array-vec4-index-wr
    - glsl-110/execution/variable-indexing/vs-temp-array-mat2-index-col-row-wr
    - glsl-110/execution/variable-indexing/vs-temp-array-mat2-index-row-wr

    Totals:
    SGPRS: 1132185 -> 1168801 (3.23 %)
    VGPRS: 907856 -> 906204 (-0.18 %)
    Spilled SGPRs: 2011 -> 2425 (20.59 %)
    Spilled VGPRs: 368 -> 96 (-73.91 %)
    Scratch VGPRs: 1344 -> 1060 (-21.13 %) dwords per thread
    Code Size: 35916164 -> 35705372 (-0.59 %) bytes
    LDS: 767 -> 767 (0.00 %) blocks
    Max Waves: 194010 -> 194921 (0.47 %)
    Wait states: 0 -> 0 (0.00 %)

    Before:
     VGPR SPILLING APPS   Shaders SpillVGPR ScratchVGPR
     alien_isolation         2938        38        40
     bioshock-infinite       1769       245       732
     dirt-showdown            548        85        72
     f1-2015                  776         0       320
     ue4_lightroom_inter..     74         0       180

    After:
     VGPR SPILLING APPS   Shaders SpillVGPR ScratchVGPR
     alien_isolation         2938        38        40
     bioshock-infinite       1769         0       480
     dirt-showdown            548        58        40
     f1-2015                  776         0       320
     ue4_lightroom_inter..     74         0       180

    Bioshock and DiRT benefit.

    If I set IF_THRESHOLD=4, tesseract starts spilling VGPRs

    Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>

:040000 040000 2c773601e2956578e8da4a6031cb02837255b953
7d5f7c3faebe4a11631e70bde258d78fa7357008 M      src

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 4635 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
@ 2016-11-17 16:44 ` bugzilla-daemon
  2016-11-17 22:14 ` [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground bugzilla-daemon
                   ` (22 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-17 16:44 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 312 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #1 from Arek Ruśniak <arek.rusi@gmail.com> ---
Created attachment 128045
  --> https://bugs.freedesktop.org/attachment.cgi?id=128045&action=edit
ground looks good

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1318 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
  2016-11-17 16:44 ` bugzilla-daemon
@ 2016-11-17 22:14 ` bugzilla-daemon
  2016-11-17 22:15 ` bugzilla-daemon
                   ` (21 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-17 22:14 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 606 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

Nicolai Hähnle <nhaehnle@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[regression][radeonsi][pola |[regression][radeonsi][pola
                   |ris]"radeonsi: set          |ris]"radeonsi: set
                   |IF_THRESHOLD to 3" breaks   |IF_THRESHOLD to 3" breaks
                   |Wither2's ground            |Witcher2's ground

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1300 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
  2016-11-17 16:44 ` bugzilla-daemon
  2016-11-17 22:14 ` [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground bugzilla-daemon
@ 2016-11-17 22:15 ` bugzilla-daemon
  2016-11-18  9:45 ` bugzilla-daemon
                   ` (20 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-17 22:15 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 321 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #2 from Nicolai Hähnle <nhaehnle@gmail.com> ---
The patch at https://patchwork.freedesktop.org/patch/122101/ fixes a known
regression from that commit -- does it help here?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1266 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (2 preceding siblings ...)
  2016-11-17 22:15 ` bugzilla-daemon
@ 2016-11-18  9:45 ` bugzilla-daemon
  2016-11-18 17:53 ` bugzilla-daemon
                   ` (19 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-18  9:45 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 443 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #3 from Arek Ruśniak <arek.rusi@gmail.com> ---
Created attachment 128053
  --> https://bugs.freedesktop.org/attachment.cgi?id=128053&action=edit
problem in motion

unfortunately, doesn't help here. (mesa git-da2a511 + your patch/llvm 287325)
this is how looks like in game before and after.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1451 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (3 preceding siblings ...)
  2016-11-18  9:45 ` bugzilla-daemon
@ 2016-11-18 17:53 ` bugzilla-daemon
  2016-11-18 18:52 ` bugzilla-daemon
                   ` (18 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-18 17:53 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 353 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #4 from Marek Olšák <maraeo@gmail.com> ---
I can reproduce it, but I don't yet know how to find the bad shader.

apitrace doesn't work with this game and shaders aren't always loaded in the
same order.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1232 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (4 preceding siblings ...)
  2016-11-18 17:53 ` bugzilla-daemon
@ 2016-11-18 18:52 ` bugzilla-daemon
  2016-11-18 20:24 ` bugzilla-daemon
                   ` (17 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-18 18:52 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 281 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #5 from Marek Olšák <maraeo@gmail.com> ---
This is only reproducible on LLVM 4.0 trunk.

LLVM 3.9 renders doesn't have this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1160 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (5 preceding siblings ...)
  2016-11-18 18:52 ` bugzilla-daemon
@ 2016-11-18 20:24 ` bugzilla-daemon
  2016-11-18 21:17 ` bugzilla-daemon
                   ` (16 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-18 20:24 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 500 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #6 from Nicolai Hähnle <nhaehnle@gmail.com> ---
If Witcher 2 has scalar spills, I'd suggest trying LLVM trunk from before
r286766 (or perhaps with that commit reverted), as there's another known bug:
SGPR spills conflict with fragment shader input interpolation (because both use
M0), and it's possible that the Mesa commit simply exposed the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1383 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (6 preceding siblings ...)
  2016-11-18 20:24 ` bugzilla-daemon
@ 2016-11-18 21:17 ` bugzilla-daemon
  2016-11-18 21:19 ` bugzilla-daemon
                   ` (15 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-18 21:17 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 370 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #7 from Marek Olšák <maraeo@gmail.com> ---
Found the bad shader.

The good one has before v_interp:
s_mov_b32 m0, s11

The bad one has before v_interp:
s_mov_b32 m0, s19

I don't see any store instructions though.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1249 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (7 preceding siblings ...)
  2016-11-18 21:17 ` bugzilla-daemon
@ 2016-11-18 21:19 ` bugzilla-daemon
  2016-11-19  5:39 ` bugzilla-daemon
                   ` (14 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-18 21:19 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 307 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #8 from Marek Olšák <maraeo@gmail.com> ---
Scratch that. The bad one has this:

s_mov_b32 s19, s11
s_mov_b32 m0, s19

It looks like it's not an m0 issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1186 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (8 preceding siblings ...)
  2016-11-18 21:19 ` bugzilla-daemon
@ 2016-11-19  5:39 ` bugzilla-daemon
  2016-11-20 11:04 ` bugzilla-daemon
                   ` (13 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-19  5:39 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 509 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

Daniel Scharrer <daniel@constexpr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel@constexpr.org

--- Comment #9 from Daniel Scharrer <daniel@constexpr.org> ---
Found a possibly related bug in another game: #98776.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1992 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (9 preceding siblings ...)
  2016-11-19  5:39 ` bugzilla-daemon
@ 2016-11-20 11:04 ` bugzilla-daemon
  2016-11-21 23:52 ` bugzilla-daemon
                   ` (12 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-20 11:04 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 400 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #10 from Arek Ruśniak <arek.rusi@gmail.com> ---
Nicolai, I don't want to bisect llvm I really hate it but i've tried r286757 &
r286827 and problem is somewhere between. So you have right i believe. 

And still can't reproduce this on hd7770 (verde).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1287 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (10 preceding siblings ...)
  2016-11-20 11:04 ` bugzilla-daemon
@ 2016-11-21 23:52 ` bugzilla-daemon
  2016-11-22  0:36 ` bugzilla-daemon
                   ` (11 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-21 23:52 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 1010 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #11 from Marek Olšák <maraeo@gmail.com> ---
First bad commit:

commit 4404d0d6e354e80dd7f8f0a0e12d8ad809cf007e
Author: Matt Arsenault <Matthew.Arsenault@amd.com>
Date:   Sun Nov 13 18:20:54 2016 +0000

    AMDGPU: Implement SGPR spilling with scalar stores

    nThis avoids the nasty problems caused by using
    memory instructions that read the exec mask while
    spilling / restoring registers used for control flow
    masking, but only for VI when these were added.

    This always uses the scalar stores when enabled currently,
    but it may be better to still try to spill to a VGPR
    and use this on the fallback memory path.

    The cache also needs to be flushed before wave termination
    if a scalar store is used.

    git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@286766
91177308-0d34-0410-b5e6-96231b3b80d8

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2025 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (11 preceding siblings ...)
  2016-11-21 23:52 ` bugzilla-daemon
@ 2016-11-22  0:36 ` bugzilla-daemon
  2016-11-22  0:39 ` bugzilla-daemon
                   ` (10 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-22  0:36 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 319 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #12 from Marek Olšák <maraeo@gmail.com> ---
Created attachment 128128
  --> https://bugs.freedesktop.org/attachment.cgi?id=128128&action=edit
affected shader (good asm)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1343 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (12 preceding siblings ...)
  2016-11-22  0:36 ` bugzilla-daemon
@ 2016-11-22  0:39 ` bugzilla-daemon
  2016-11-22  0:42 ` bugzilla-daemon
                   ` (9 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-22  0:39 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 325 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #13 from Marek Olšák <maraeo@gmail.com> ---
Created attachment 128129
  --> https://bugs.freedesktop.org/attachment.cgi?id=128129&action=edit
affected shader (good->bad diff)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1370 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (13 preceding siblings ...)
  2016-11-22  0:39 ` bugzilla-daemon
@ 2016-11-22  0:42 ` bugzilla-daemon
  2016-11-22  0:43 ` bugzilla-daemon
                   ` (8 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-22  0:42 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 318 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #14 from Marek Olšák <maraeo@gmail.com> ---
Created attachment 128130
  --> https://bugs.freedesktop.org/attachment.cgi?id=128130&action=edit
affected shader (bad asm)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1340 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (14 preceding siblings ...)
  2016-11-22  0:42 ` bugzilla-daemon
@ 2016-11-22  0:43 ` bugzilla-daemon
  2016-11-22 12:54 ` bugzilla-daemon
                   ` (7 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-22  0:43 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 251 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #15 from Marek Olšák <maraeo@gmail.com> ---
It looks like m0 isn't restored for v_interp instructions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1131 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (15 preceding siblings ...)
  2016-11-22  0:43 ` bugzilla-daemon
@ 2016-11-22 12:54 ` bugzilla-daemon
  2016-11-22 22:37 ` bugzilla-daemon
                   ` (6 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-22 12:54 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 303 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #16 from Grazvydas Ignotas <notasas@gmail.com> ---
Possible duplicates: bug 98776 bug 98783 bug 98785
llvm bug: https://llvm.org/bugs/show_bug.cgi?id=31019

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1756 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (16 preceding siblings ...)
  2016-11-22 12:54 ` bugzilla-daemon
@ 2016-11-22 22:37 ` bugzilla-daemon
  2016-11-24  0:40 ` bugzilla-daemon
                   ` (5 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-22 22:37 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 512 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #17 from Arek Ruśniak <arek.rusi@gmail.com> ---
Marek, thanks for help with llvm. 
Grazvydas, with Talos I agree, even opengl is garbage now. Unigine-heaven has
similar problem since r286766 
Probably guilty is "AMDGPU: Implement SGPR spilling with scalar stores" for all
scenario but i never ever had any problem with Life is Strange (I've just
finished E01)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1405 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (17 preceding siblings ...)
  2016-11-22 22:37 ` bugzilla-daemon
@ 2016-11-24  0:40 ` bugzilla-daemon
  2016-11-24 19:57 ` bugzilla-daemon
                   ` (4 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-24  0:40 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 217 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #18 from Matt Arsenault <arsenm2@gmail.com> ---
Try after llvm r287844

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1099 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (18 preceding siblings ...)
  2016-11-24  0:40 ` bugzilla-daemon
@ 2016-11-24 19:57 ` bugzilla-daemon
  2016-11-24 20:53 ` bugzilla-daemon
                   ` (3 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-24 19:57 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 466 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #19 from Marek Olšák <maraeo@gmail.com> ---
Created attachment 128178
  --> https://bugs.freedesktop.org/attachment.cgi?id=128178&action=edit
still bad

(In reply to Matt Arsenault from comment #18)
> Try after llvm r287844

It's still pretty broken. See the attached asm. "s_mov vcc_hi, m0" looks
suspicious.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1537 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (19 preceding siblings ...)
  2016-11-24 19:57 ` bugzilla-daemon
@ 2016-11-24 20:53 ` bugzilla-daemon
  2016-11-24 20:58 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-24 20:53 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 651 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #20 from Matt Arsenault <arsenm2@gmail.com> ---
(In reply to Marek Olšák from comment #19)
> Created attachment 128178 [details]
> still bad
> 
> (In reply to Matt Arsenault from comment #18)
> > Try after llvm r287844
> 
> It's still pretty broken. See the attached asm. "s_mov vcc_hi, m0" looks
> suspicious.

s_mov vcc_hi, m0 is fine and expected. TableGen happens to sort VCC to the
beginning of the SReg_64 register class list, so the scavenger tends to find
VCC first if its available

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1851 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (20 preceding siblings ...)
  2016-11-24 20:53 ` bugzilla-daemon
@ 2016-11-24 20:58 ` bugzilla-daemon
  2016-11-24 23:20 ` bugzilla-daemon
  2017-01-02 20:21 ` bugzilla-daemon
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-24 20:58 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 294 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #21 from Matt Arsenault <arsenm2@gmail.com> ---
This is more concerning: s_buffer_store_dword exec_lo, s[84:87], m0

exec should never be spilled

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1176 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (21 preceding siblings ...)
  2016-11-24 20:58 ` bugzilla-daemon
@ 2016-11-24 23:20 ` bugzilla-daemon
  2017-01-02 20:21 ` bugzilla-daemon
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2016-11-24 23:20 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 668 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

--- Comment #22 from Arek Ruśniak <arek.rusi@gmail.com> ---
Created attachment 128180
  --> https://bugs.freedesktop.org/attachment.cgi?id=128180&action=edit
witcher2_r287854

so, it's resolved ground's problem for me, the movie is not looking perfect but
this is not problem of this bug report i think. 

Marek, Matt I don't know what do you talking about but maybe you are looking
for:
https://bugs.freedesktop.org/show_bug.cgi?id=98238 
there is big visual differences between mesa 12.0.4 vs 13.0 ...work in
progress:)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1827 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

* [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground
  2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
                   ` (22 preceding siblings ...)
  2016-11-24 23:20 ` bugzilla-daemon
@ 2017-01-02 20:21 ` bugzilla-daemon
  23 siblings, 0 replies; 25+ messages in thread
From: bugzilla-daemon @ 2017-01-02 20:21 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 582 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98761

Arek Ruśniak <arek.rusi@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #23 from Arek Ruśniak <arek.rusi@gmail.com> ---
Oops.. when Marek reverted "SGPR spilling..."-stuff, this one should be closed
aswell.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2241 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2017-01-02 20:21 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-17 16:37 [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Wither2's ground bugzilla-daemon
2016-11-17 16:44 ` bugzilla-daemon
2016-11-17 22:14 ` [Bug 98761] [regression][radeonsi][polaris]"radeonsi: set IF_THRESHOLD to 3" breaks Witcher2's ground bugzilla-daemon
2016-11-17 22:15 ` bugzilla-daemon
2016-11-18  9:45 ` bugzilla-daemon
2016-11-18 17:53 ` bugzilla-daemon
2016-11-18 18:52 ` bugzilla-daemon
2016-11-18 20:24 ` bugzilla-daemon
2016-11-18 21:17 ` bugzilla-daemon
2016-11-18 21:19 ` bugzilla-daemon
2016-11-19  5:39 ` bugzilla-daemon
2016-11-20 11:04 ` bugzilla-daemon
2016-11-21 23:52 ` bugzilla-daemon
2016-11-22  0:36 ` bugzilla-daemon
2016-11-22  0:39 ` bugzilla-daemon
2016-11-22  0:42 ` bugzilla-daemon
2016-11-22  0:43 ` bugzilla-daemon
2016-11-22 12:54 ` bugzilla-daemon
2016-11-22 22:37 ` bugzilla-daemon
2016-11-24  0:40 ` bugzilla-daemon
2016-11-24 19:57 ` bugzilla-daemon
2016-11-24 20:53 ` bugzilla-daemon
2016-11-24 20:58 ` bugzilla-daemon
2016-11-24 23:20 ` bugzilla-daemon
2017-01-02 20:21 ` bugzilla-daemon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.