From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754177AbdBGMMi (ORCPT ); Tue, 7 Feb 2017 07:12:38 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35133 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752624AbdBGMMf (ORCPT ); Tue, 7 Feb 2017 07:12:35 -0500 Subject: Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports. To: Bartlomiej Zolnierkiewicz References: <1486124625-23454-1-git-send-email-arvind.yadav.cs@gmail.com> <15170308.DWakhCLKvX@amdc3058> Cc: tomi.valkeinen@ti.com, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Arvind Yadav Message-ID: Date: Tue, 7 Feb 2017 17:41:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <15170308.DWakhCLKvX@amdc3058> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, In dss_init_ports, There is no need to add dss_uninit_ports before returning. Because it's already take care in dss_bind. dss_bind is handling dss_uninit_ports in error path. -Arvind On Monday 06 February 2017 08:58 PM, Bartlomiej Zolnierkiewicz wrote: > dpi_uninit_port() & sdi_uninit_port() skip not fully > initialized port From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arvind Yadav Date: Tue, 07 Feb 2017 12:23:37 +0000 Subject: Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports. Message-Id: List-Id: References: <1486124625-23454-1-git-send-email-arvind.yadav.cs@gmail.com> <15170308.DWakhCLKvX@amdc3058> In-Reply-To: <15170308.DWakhCLKvX@amdc3058> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bartlomiej Zolnierkiewicz Cc: tomi.valkeinen@ti.com, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Hi, In dss_init_ports, There is no need to add dss_uninit_ports before returning. Because it's already take care in dss_bind. dss_bind is handling dss_uninit_ports in error path. -Arvind On Monday 06 February 2017 08:58 PM, Bartlomiej Zolnierkiewicz wrote: > dpi_uninit_port() & sdi_uninit_port() skip not fully > initialized port