From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Piyush Malgujar <pmalgujar@marvell.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
adrian.hunter@intel.com, ulf.hansson@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
yamada.masahiro@socionext.com, devicetree@vger.kernel.org
Cc: jannadurai@marvell.com, cchavva@marvell.com,
Dhananjay Kangude <dkangude@cadence.com>
Subject: Re: [PATCH 1/5] drivers: mmc: sdhci-cadence: SD6 controller support
Date: Mon, 19 Dec 2022 16:41:45 +0100 [thread overview]
Message-ID: <c008733c-b47b-606e-f8e6-d5ea14e5befb@linaro.org> (raw)
In-Reply-To: <20221219142418.27949-2-pmalgujar@marvell.com>
On 19/12/2022 15:24, Piyush Malgujar wrote:
> From: Dhananjay Kangude <dkangude@cadence.com>
>
> This patch includes changes done to support SD6 controller:
Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> - Added SD6 related ops which are isolated from SD4
> - changes to support HS400, HS400ES emmc mode
> - Updated HS200 tuning values and support to read tune configuration
> from FDT.
> - Support to configure host side drive strength and slew
> and read it from device tree
>
(...)
>
> @@ -455,7 +1752,14 @@ static const struct of_device_id sdhci_cdns_match[] = {
> .compatible = "socionext,uniphier-sd4hc",
> .data = &sdhci_cdns_uniphier_pltfm_data,
> },
> - { .compatible = "cdns,sd4hc" },
> + {
> + .compatible = "cdns,sd4hc",
> + .data = &sdhci_cdns_sd4_of_data,
> + },
> + {
> + .compatible = "cdns,sd6hc",
> + .data = &sdhci_cdns_sd6_of_data,
> + },
Your bindings said something different - every sd4hc is compatible with
sd6hc.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-19 15:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 14:24 [PATCH 0/5] drivers: mmc: sdhci-cadence: SD6 controller support Piyush Malgujar
2022-12-19 14:24 ` [PATCH 1/5] " Piyush Malgujar
2022-12-19 15:41 ` Krzysztof Kozlowski [this message]
2023-01-11 8:19 ` Adrian Hunter
2022-12-19 14:24 ` [PATCH 2/5] drivers: mmc: sdhci-cadence: enable MMC_SDHCI_IO_ACCESSORS Piyush Malgujar
2023-01-01 1:30 ` kernel test robot
2023-01-11 8:23 ` Adrian Hunter
2023-01-12 14:12 ` Piyush Malgujar
2023-01-13 7:20 ` Adrian Hunter
2022-12-19 14:24 ` [PATCH 3/5] dt-bindings: mmc: sdhci-cadence: SD6 support Piyush Malgujar
2022-12-19 15:40 ` Krzysztof Kozlowski
2023-01-06 16:48 ` Piyush Malgujar
2023-01-07 13:25 ` Krzysztof Kozlowski
2023-01-18 16:02 ` Piyush Malgujar
2022-12-19 14:24 ` [PATCH 4/5] drivers: mmc: sdhci: Add option to configure sdhci timeout Piyush Malgujar
2023-01-11 8:08 ` Adrian Hunter
2023-01-12 13:44 ` Piyush Malgujar
2022-12-19 14:24 ` [PATCH 5/5] drivers: mmc: sdhci-cadence: Add debug option for sdhci-cadence driver Piyush Malgujar
2022-12-19 17:14 ` kernel test robot
2022-12-20 4:01 ` kernel test robot
2023-01-11 8:29 ` Adrian Hunter
2022-12-23 8:06 [PATCH 1/5] drivers: mmc: sdhci-cadence: SD6 controller support kernel test robot
2022-12-23 11:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c008733c-b47b-606e-f8e6-d5ea14e5befb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=cchavva@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=dkangude@cadence.com \
--cc=jannadurai@marvell.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pmalgujar@marvell.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.