All of lore.kernel.org
 help / color / mirror / Atom feed
From: Renato Lui Geh <renatogeh@gmail.com>
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
	knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
	stefan.popa@analog.com, alexandru.Ardelean@analog.com,
	giuliano.belinassi@usp.br, robh+dt@kernel.org,
	mark.rutland@arm.com
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com,
	devicetree@vger.kernel.org
Subject: [PATCH v5 07/11] staging: iio: ad7780: move regulator to after GPIO init
Date: Fri, 15 Mar 2019 23:14:59 -0300	[thread overview]
Message-ID: <c018f41a8f21c0b2b25fe264cb58ba4bd2239505.1552700652.git.renatogeh@gmail.com> (raw)
In-Reply-To: <cover.1552700652.git.renatogeh@gmail.com>

To maintain consistency between ad7780_probe and ad7780_remove orders,
regulator initialization has been moved to after GPIO initializations.

Signed-off-by: Renato Lui Geh <renatogeh@gmail.com>
---
 drivers/staging/iio/adc/ad7780.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
index 977b381c1260..568c5b4472ff 100644
--- a/drivers/staging/iio/adc/ad7780.c
+++ b/drivers/staging/iio/adc/ad7780.c
@@ -295,16 +295,6 @@ static int ad7780_probe(struct spi_device *spi)
 
 	ad_sd_init(&st->sd, indio_dev, spi, &ad7780_sigma_delta_info);
 
-	st->reg = devm_regulator_get(&spi->dev, "avdd");
-	if (IS_ERR(st->reg))
-		return PTR_ERR(st->reg);
-
-	ret = regulator_enable(st->reg);
-	if (ret) {
-		dev_err(&spi->dev, "Failed to enable specified AVdd supply\n");
-		return ret;
-	}
-
 	st->chip_info =
 		&ad7780_chip_info_tbl[spi_get_device_id(spi)->driver_data];
 
@@ -321,6 +311,16 @@ static int ad7780_probe(struct spi_device *spi)
 	if (ret)
 		goto error_cleanup_buffer_and_trigger;
 
+	st->reg = devm_regulator_get(&spi->dev, "avdd");
+	if (IS_ERR(st->reg))
+		return PTR_ERR(st->reg);
+
+	ret = regulator_enable(st->reg);
+	if (ret) {
+		dev_err(&spi->dev, "Failed to enable specified AVdd supply\n");
+		return ret;
+	}
+
 	ret = ad_sd_setup_buffer_and_trigger(indio_dev);
 	if (ret)
 		goto error_disable_reg;
-- 
2.21.0


  parent reply	other threads:[~2019-03-16  2:15 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-16  2:10 [PATCH v5 00/11] staging: iio: ad7780: move out of staging Renato Lui Geh
2019-03-16  2:12 ` [PATCH v5 01/11] staging: iio: ad7780: add gain & filter gpio support Renato Lui Geh
2019-03-16 17:46   ` Jonathan Cameron
2019-03-16 17:46     ` Jonathan Cameron
2019-03-24 11:06     ` Jonathan Cameron
2019-03-16  2:12 ` [PATCH v5 02/11] staging: iio: ad7780: add missing switch default case Renato Lui Geh
2019-03-16 17:48   ` Jonathan Cameron
2019-03-16  2:13 ` [PATCH v5 03/11] staging: iio: ad7780: add gain reading to ad778x Renato Lui Geh
2019-03-16 17:54   ` Jonathan Cameron
2019-03-16 17:54     ` Jonathan Cameron
2019-03-16  2:13 ` [PATCH v5 04/11] staging: iio: ad7780: add filter " Renato Lui Geh
2019-03-16 17:55   ` Jonathan Cameron
2019-03-16  2:14 ` [PATCH v5 05/11] staging: iio: ad7780: set pattern values and masks directly Renato Lui Geh
2019-03-16 17:57   ` Jonathan Cameron
2019-03-16  2:14 ` [PATCH v5 06/11] staging:iio:ad7780: add chip ID values and mask Renato Lui Geh
2019-03-16 18:00   ` Jonathan Cameron
2019-03-16  2:14 ` Renato Lui Geh [this message]
2019-03-16 18:02   ` [PATCH v5 07/11] staging: iio: ad7780: move regulator to after GPIO init Jonathan Cameron
2019-03-16  2:15 ` [PATCH v5 08/11] staging: iio: ad7780: add SPDX identifier Renato Lui Geh
2019-03-16 18:03   ` Jonathan Cameron
2019-03-16  2:15 ` [PATCH v5 09/11] staging: iio: ad7780: add new copyright holder Renato Lui Geh
2019-03-16 18:04   ` Jonathan Cameron
2019-03-16  2:15 ` [PATCH v5 10/11] staging: iio: ad7780: moving ad7780 out of staging Renato Lui Geh
2019-03-16 18:19   ` Jonathan Cameron
2019-03-16 18:19     ` Jonathan Cameron
2019-03-16 18:43     ` Renato Lui Geh
2019-03-16  2:16 ` [PATCH v5 11/11] staging: iio: ad7780: add device tree binding Renato Lui Geh
2019-03-16 18:21   ` Jonathan Cameron
2019-03-16 18:21     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c018f41a8f21c0b2b25fe264cb58ba4bd2239505.1552700652.git.renatogeh@gmail.com \
    --to=renatogeh@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=alexandru.Ardelean@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=giuliano.belinassi@usp.br \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=kernel-usp@googlegroups.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=stefan.popa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.