From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v3 03/11] drm/tilcdc: Fix tilcdc_crtc_create() return value handling Date: Thu, 24 Nov 2016 11:34:14 +0200 Message-ID: References: <02ad9fd133b379a324b4000fd2ebfd0e97ec2f99.1479832733.git.jsarha@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0057059709==" Return-path: Received: from lelnx193.ext.ti.com (lelnx193.ext.ti.com [198.47.27.77]) by gabe.freedesktop.org (Postfix) with ESMTPS id 586B66E0DF for ; Thu, 24 Nov 2016 09:34:22 +0000 (UTC) In-Reply-To: <02ad9fd133b379a324b4000fd2ebfd0e97ec2f99.1479832733.git.jsarha@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: khilman@baylibre.com, bgolaszewski@baylibre.com, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org --===============0057059709== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q02uhkhG0DFbG6FW9vQ2QVs365IqaLvqI" --Q02uhkhG0DFbG6FW9vQ2QVs365IqaLvqI Content-Type: multipart/mixed; boundary="cDL2FUvhkmb30DRswL920sOcJ5UApdJXE"; protected-headers="v1" From: Tomi Valkeinen To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: airlied@linux.ie, daniel@ffwll.ch, laurent.pinchart@ideasonboard.com, robdclark@gmail.com, bgolaszewski@baylibre.com, khilman@baylibre.com Message-ID: Subject: Re: [PATCH v3 03/11] drm/tilcdc: Fix tilcdc_crtc_create() return value handling References: <02ad9fd133b379a324b4000fd2ebfd0e97ec2f99.1479832733.git.jsarha@ti.com> In-Reply-To: <02ad9fd133b379a324b4000fd2ebfd0e97ec2f99.1479832733.git.jsarha@ti.com> --cDL2FUvhkmb30DRswL920sOcJ5UApdJXE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 22/11/16 18:54, Jyri Sarha wrote: > Failed tilcdc_crtc_create() error handling was broken, this patch > should fix it. >=20 > Signed-off-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 12 +++++++----- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 11 ++++------- > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 +- > 3 files changed, 12 insertions(+), 13 deletions(-) Instead of just checking the tilcdc_crtc_create() return value, you made all these changes? Maybe it's better this way, but I don't see why that is from the diff. Tomi --cDL2FUvhkmb30DRswL920sOcJ5UApdJXE-- --Q02uhkhG0DFbG6FW9vQ2QVs365IqaLvqI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYNrQWAAoJEPo9qoy8lh71EEAP/3nGtEYkzukwYyFXnKKfflWS /Cu87r0jRRKp9rBn8JAxB927rfhQS/vg3fH5rCpzFALILFhf0QzHGfPRFz32hxYi NjFKMTLryGJiLhgu4oOcOHFV+ezFYGWJhMQtsvDrfBNpjTbACaJmLOuBrMJ9cbsY tvezwJH2hkTR3cL406YSd/ApXbBRfimTycHwxjuWr2N/B3jBKyxnqNwu2SIsX5rQ Cj0dfGOG5zpx/uG3SKDdoRfvSgPO/VLjaZQ6ZtYQj63iQtgyR/dTPqRVV0IGYOoc oBJXNpRuRtNBikBthFSZcF6oi28ReYcIOlfuxR4T9B00qMcf3RtzOEHmQiFYliOD 3xqiQEwO1fMKFpUs33vvwmmArexqsB0BbDred5lLZK7s/y5jymx074wNW06Nmv5/ f1XfYOTXSs9Cu5xG9H5X7FxHm/Vz72SElVxI0MqMx6ln7uKCvZJJ2iggOzG+Vpuo 8lWVXHbW7bcs2XsdEOMRAj0GTotIqjqxw3cVOYcDoAFe9gKBWqmR2nm/jvuisAX0 2aVXEyi0NxblNVoDYozC6Ct+7jEetJs2/+jMUKqioDhF5v/1XnIG8oGtb7gT7fkR SQINR3VK6CUWj6SK8d7EvnnEigEMQWrcOcAnL0ug2yLmq8ZONHVOHY5DWHRJUxEk sraGzvR6C5vAajQoiao8 =1Qqt -----END PGP SIGNATURE----- --Q02uhkhG0DFbG6FW9vQ2QVs365IqaLvqI-- --===============0057059709== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0057059709==--