From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B62B7C433F5 for ; Wed, 6 Oct 2021 00:49:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7912B61108 for ; Wed, 6 Oct 2021 00:49:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237051AbhJFAu6 (ORCPT ); Tue, 5 Oct 2021 20:50:58 -0400 Received: from mga01.intel.com ([192.55.52.88]:56785 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230218AbhJFAuu (ORCPT ); Tue, 5 Oct 2021 20:50:50 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="249162348" X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="249162348" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 17:48:58 -0700 X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="477916976" Received: from rriesen-ivm.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.209.35.74]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 17:48:57 -0700 Subject: Re: [PATCH v8 09/11] x86/tdx: Add MSR support for TDX guest To: Josh Poimboeuf Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, Paolo Bonzini , David Hildenbrand , Andrea Arcangeli , Juergen Gross , Deep Shah , VMware Inc , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , linux-kernel@vger.kernel.org References: <20211005025205.1784480-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20211005025205.1784480-10-sathyanarayanan.kuppuswamy@linux.intel.com> <20211005232209.ozugpocq2cvx22li@treble> From: "Kuppuswamy, Sathyanarayanan" Message-ID: Date: Tue, 5 Oct 2021 17:48:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211005232209.ozugpocq2cvx22li@treble> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/5/21 4:22 PM, Josh Poimboeuf wrote: > This fails to build: > > arch/x86/kernel/tdx.c: In function ‘tdx_write_msr_safe’: > arch/x86/kernel/tdx.c:135:22: error: implicit declaration of function ‘tdx_is_context_switched_msr’ [-Werror=implicit-function-declaration] > 135 | WARN_ON_ONCE(tdx_is_context_switched_msr(msr)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > ./include/asm-generic/bug.h:104:32: note: in definition of macro ‘WARN_ON_ONCE’ > 104 | int __ret_warn_on = !!(condition); \ > | ^~~~~~~~~ Sorry, it looks like the removal is split across two patches. So I did not catch it in my compilation test. I will fix this and repost it. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer