From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5AB3C433E2 for ; Tue, 1 Sep 2020 17:03:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 717B7206FA for ; Tue, 1 Sep 2020 17:03:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NWggDpQN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 717B7206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD9gx-0002gN-J9 for qemu-devel@archiver.kernel.org; Tue, 01 Sep 2020 13:03:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD9gN-0002Dy-VL for qemu-devel@nongnu.org; Tue, 01 Sep 2020 13:02:56 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:37235 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kD9gM-0004WR-0M for qemu-devel@nongnu.org; Tue, 01 Sep 2020 13:02:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598979772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CbaKAiIo0ZD4AhA08YdKXa+ZQzyKJNkPAgbcXhXyctU=; b=NWggDpQNt5Yph3Cx1eBBk4qnJaOY/twR1MTRDchp1og8Fm8wdRmYTuWn+u4yiApDM0lZDj l13ae11OV5DI6BlyZkobh8s0DOJphfOVTll+eA+olM1hY8t0/VCSUKgyCAadIHydxDIYZG USnep2jRCRVIVgKWdcuD/m2r8xAQarY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-ds4jKvJFOKCpiTL6d9ScSg-1; Tue, 01 Sep 2020 13:02:51 -0400 X-MC-Unique: ds4jKvJFOKCpiTL6d9ScSg-1 Received: by mail-wr1-f71.google.com with SMTP id r16so333115wrm.18 for ; Tue, 01 Sep 2020 10:02:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CbaKAiIo0ZD4AhA08YdKXa+ZQzyKJNkPAgbcXhXyctU=; b=jNnBxSZsl9A2KUOZjSpcjUkt+U5NdDq/z2M2lwjWRpanWdmD7K05CFgft8jrE3x+8e xxJHelJXrua549RUTd605IVv7O6HhJBaqCZ5DnJwAC/vNaDoFMUnfglLdv8K+4iOMs0n dUaP1vYhWQ5E3cFPZxj6a2armxr8nSlPLmGbsHzAdgohtniZIU0LXtN4kidunzzt20RP 2n1tMQ+n3boabciIepnshN4u3Wcw9olEf8+PYfQq0NRxPm5d/MLm0UzuDR7Ntl04KTHV 9+PHLHf3tfqJht+iJFKzzn58b+z457BoSwjRfXiqkTMOnc89BG79gQ87/Amc+n/4j3cy nzlw== X-Gm-Message-State: AOAM533fV9owxuG1pYaVpQGUiOWFeJQ7cetU5QP9x8F3dWHc1SeTncJZ T5Pkit+adevD93XP4yM4+kG5DhCdCzAr/vH/XsWznljTAnNB5YhqeM1P1geFf2oTMwYsyH0nTlU qxv+0b26e8wpb/Tk= X-Received: by 2002:adf:e385:: with SMTP id e5mr2829884wrm.129.1598979769681; Tue, 01 Sep 2020 10:02:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEpbQwQ27wfZfSzioyCS0vxhg1vHir4ERF6+AxZWCPmR6/xlIYbEJMjYW7xx7GXG0VqwtKQA== X-Received: by 2002:adf:e385:: with SMTP id e5mr2829862wrm.129.1598979769462; Tue, 01 Sep 2020 10:02:49 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:7fbd:8007:1fa7:ed17? ([2001:b07:6468:f312:7fbd:8007:1fa7:ed17]) by smtp.gmail.com with ESMTPSA id h2sm3096605wrp.69.2020.09.01.10.02.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2020 10:02:48 -0700 (PDT) Subject: Re: [PATCH-for-5.2 0/4] hw/char/serial: Use the Clock API to feed the UART reference clock To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200806130340.17316-1-f4bug@amsat.org> From: Paolo Bonzini Message-ID: Date: Tue, 1 Sep 2020 19:02:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200806130340.17316-1-f4bug@amsat.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=205.139.110.61; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 10:16:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.13, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , Peter Maydell , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 06/08/20 15:03, Philippe Mathieu-Daudé wrote: > This series improve tracing of multiple UART device in the same > chipset, and allow to use the Clock API to feed each device with > an (updatable) input clock. > > Based-on: <20200730165900.7030-1-philmd@redhat.com> > "hw/char: Remove TYPE_SERIAL_IO" > > Philippe Mathieu-Daudé (4): > hw/char/serial: Replace commented DPRINTF() by trace event > hw/char/serial: Remove old DEBUG_SERIAL commented code > hw/char/serial: Let SerialState have an 'id' field > hw/char/serial: Use the Clock API to feed the UART reference clock > > include/hw/char/serial.h | 4 +++ > hw/char/serial.c | 55 +++++++++++++++++++++++----------------- > hw/char/trace-events | 5 ++-- > 3 files changed, 39 insertions(+), 25 deletions(-) > Acked-by: Paolo Bonzini Are you planning to deprecate the baudbase property, and instead setting up the clock already in serial_mm_init? Thanks, Paolo