All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: yhchuang@realtek.com, kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, briannorris@chromium.org,
	anbeltra@microsoft.com
Subject: Re: [PATCH] rtw88: set WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL, mac80211 supports it
Date: Thu, 13 Feb 2020 11:02:57 +0100	[thread overview]
Message-ID: <c02f6e1f-c345-0ca0-0a7b-0997926d3860@broadcom.com> (raw)
In-Reply-To: <3121eb67-f303-01e4-a006-a39947381175@broadcom.com>

On 2/13/2020 10:56 AM, Arend Van Spriel wrote:
> 
> 
> On 2/13/2020 6:08 AM, yhchuang@realtek.com wrote:
>> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>>
>> Set wiphy flag WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL, because mac80211
>> actually supports it. With the flag set, driver can accept ROC
>> event from wpa_supplicant or some other user space tools.
> 
> This does not seem right. mac80211 does set this flag itself when the 
> driver provides remain_on_channel callback. Does that mean you already 
> have that callback? This patch is either wrong or unnecessary.

Re-reading the commit message I guess it is ok to claim 
remain-on-channel support when using sw_scan. If this is true it seems 
better to extend the condition in ieee80211_alloc_hw_nm() for setting 
the flag.

Regards,
Arend

  reply	other threads:[~2020-02-13 10:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13  5:08 [PATCH] rtw88: set WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL, mac80211 supports it yhchuang
2020-02-13  9:56 ` Arend Van Spriel
2020-02-13 10:02   ` Arend Van Spriel [this message]
2020-02-18  8:01     ` Tony Chuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c02f6e1f-c345-0ca0-0a7b-0997926d3860@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=anbeltra@microsoft.com \
    --cc=briannorris@chromium.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.