From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F520C54E94 for ; Wed, 25 Jan 2023 09:25:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3118F10E747; Wed, 25 Jan 2023 09:25:17 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4495710E0DC for ; Wed, 25 Jan 2023 09:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674638712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MJl0EBn4HtiAr3IA7OgQLEz430pat4/3/h3H46oRT3g=; b=O+H7qImQw3n0kUBRnsTNA+l1Hq/rTQNS13RVoN+0vqDNYXE0xR+cIfGrlwlQdIpd5BQYBl va2LqhD7mdUX5HEyxWufgaeOStHyyj7iqWUJTFYso9UvxzBcaRARPvMVhA9Jpnb64ir497 Id1fDr3Zb36RBSH58iuZcpKoDWAAJ9o= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-76-xJWEnXxAP6mdwitUxv8nig-1; Wed, 25 Jan 2023 04:25:09 -0500 X-MC-Unique: xJWEnXxAP6mdwitUxv8nig-1 Received: by mail-wr1-f72.google.com with SMTP id bj7-20020a0560001e0700b002bfb3c6ec00so603510wrb.4 for ; Wed, 25 Jan 2023 01:25:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MJl0EBn4HtiAr3IA7OgQLEz430pat4/3/h3H46oRT3g=; b=HgLSRNc/nY/sbQAImscD5XSmmhqkJXv0DjS7wPe6PiInMsY66mYh4o372I+7Ri7iPi KKugM6K2AodSb2WLbBJRHdYiUs4LL+qk7MGxtWBkG3ODNZ0gWqn3V4gl9dJNw9bXY6xK tXWStx0E2xzNHkVTDtoXYPGNgA3g+kjsKqf38G0e6rYqYQ6V6rmak2ZEtqYJWkHTbMRO TtqC7DLqKYBoifswuB1D5GMFr03fWwbpBsjpPlza3FWD2X835TqxDqgfDD739qPMgPwU nmXmUSSQPEfcYWypoJfuEBQbcFf1V+In47G4nvogSj+Q8FL05dMzsm16BD0y6W+hdXKl oRww== X-Gm-Message-State: AFqh2koKcmP4R6InO6Zi3ZllvfL/6TXMuiLQeCAVb3ccNEpDzyMs0Ef8 0iPqyTgR2mut7TI/HEw+BAX73zhvwGrdtsAhEd4h3RjXrUt9OdBD43PDDDYep8x9DoPMon7EgEP IdShUjvzxSPfJhe6Q+ajcBNv6OR+k X-Received: by 2002:adf:a38d:0:b0:2bf:9527:ce62 with SMTP id l13-20020adfa38d000000b002bf9527ce62mr13001329wrb.60.1674638707871; Wed, 25 Jan 2023 01:25:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXvA3fpsEqb88MB1qU578so/hL+p+6J8snUbZz7AHyqAc1so8GvG1XEiL3HmPZITj9u0u/0ozg== X-Received: by 2002:adf:a38d:0:b0:2bf:9527:ce62 with SMTP id l13-20020adfa38d000000b002bf9527ce62mr13001312wrb.60.1674638707672; Wed, 25 Jan 2023 01:25:07 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id q8-20020adff788000000b002bfbda53b98sm534384wrp.35.2023.01.25.01.25.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 01:25:07 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 10:25:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup To: Thomas Zimmermann , airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org References: <20230124134010.30263-1-tzimmermann@suse.de> <20230124134010.30263-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20230124134010.30263-5-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 1/24/23 14:40, Thomas Zimmermann wrote: > Initialize the fb-helper structure immediately after its allocation > in drm_fbdev_generic_setup(). That will make it easier to fill it with > driver-specific values, such as the preferred BPP. > > Signed-off-by: Thomas Zimmermann > --- [...] > @@ -456,12 +454,12 @@ void drm_fbdev_generic_setup(struct drm_device *dev, > fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL); > if (!fb_helper) > return; Maybe add a new line here? > + drm_fb_helper_prepare(dev, fb_helper, &drm_fb_helper_generic_funcs); > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F383C54EED for ; Wed, 25 Jan 2023 09:25:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14D1210E74B; Wed, 25 Jan 2023 09:25:14 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EA4510E74E for ; Wed, 25 Jan 2023 09:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674638710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MJl0EBn4HtiAr3IA7OgQLEz430pat4/3/h3H46oRT3g=; b=KO/F8P4vq8StqgMN5WTrUy+yBRODcTmvXLkNdiWJbBvY+PrQxM152TJ52cTrRMGmJgp3hd Mq418D+5UWJW/g7TONCkcO1TCMq3/FrAUDBt9CPrkiXfrSZDdhtjHIFV6w17aWUi8qd2gu XGMkU581WKYiDI4LD9T4aRRWm3FgGkI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-627-72qoFCHLOPeDRD8u-QRFvg-1; Wed, 25 Jan 2023 04:25:09 -0500 X-MC-Unique: 72qoFCHLOPeDRD8u-QRFvg-1 Received: by mail-wr1-f70.google.com with SMTP id k11-20020adfe3cb000000b002be503e7f28so2740356wrm.2 for ; Wed, 25 Jan 2023 01:25:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MJl0EBn4HtiAr3IA7OgQLEz430pat4/3/h3H46oRT3g=; b=DYAsvnt/x/g43kxhJay4LH1egmbFyl9FXVzHTFJzXsyEHi0uA3jIMNf8lErHRhUS0W 5NbqsJi9yRZD/cxuv/LI9WxmgFXYy8iW1Uz0uAZi8l/yb5bHfMqtuEtIBuin0qzPVYi/ 7QWBHds0mz04Va36lWZPEfSdQdBgi+UBU/CnQADJXubNGlINUhd80e5WNXBxYna2QRpg pJwibL6/RXLsce8cc27gKVqMmhlDvF3i5GVw5rqPoLweNY8Who7GeIznch4wPipb/Zzf hzYZ1V8x4BzE9AoHQth3NVt+4antPg0HvvbRBMyyvSyQEO5PEtoof46i9iZUrv8vjQRX oywg== X-Gm-Message-State: AFqh2krKdEC5RYH0/uUMsAhrYeXsQJ7aR+lVHkn4PsuMYb8+4ZfabWXx a+zexmEMOm8QMhQgcgBN+WWHbCo3sZvuEcoYj0tVj+aWh5ZPf9iQNwp/yJska7fzi2COKNYcWcV nPO4DVsRZc5+msMl8HTSYqTp5cKik X-Received: by 2002:adf:a38d:0:b0:2bf:9527:ce62 with SMTP id l13-20020adfa38d000000b002bf9527ce62mr13001322wrb.60.1674638707870; Wed, 25 Jan 2023 01:25:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXvA3fpsEqb88MB1qU578so/hL+p+6J8snUbZz7AHyqAc1so8GvG1XEiL3HmPZITj9u0u/0ozg== X-Received: by 2002:adf:a38d:0:b0:2bf:9527:ce62 with SMTP id l13-20020adfa38d000000b002bf9527ce62mr13001312wrb.60.1674638707672; Wed, 25 Jan 2023 01:25:07 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id q8-20020adff788000000b002bfbda53b98sm534384wrp.35.2023.01.25.01.25.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 01:25:07 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 10:25:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 To: Thomas Zimmermann , airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org References: <20230124134010.30263-1-tzimmermann@suse.de> <20230124134010.30263-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20230124134010.30263-5-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v2 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 1/24/23 14:40, Thomas Zimmermann wrote: > Initialize the fb-helper structure immediately after its allocation > in drm_fbdev_generic_setup(). That will make it easier to fill it with > driver-specific values, such as the preferred BPP. > > Signed-off-by: Thomas Zimmermann > --- [...] > @@ -456,12 +454,12 @@ void drm_fbdev_generic_setup(struct drm_device *dev, > fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL); > if (!fb_helper) > return; Maybe add a new line here? > + drm_fb_helper_prepare(dev, fb_helper, &drm_fb_helper_generic_funcs); > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 256FBC27C76 for ; Wed, 25 Jan 2023 09:26:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235126AbjAYJ0A (ORCPT ); Wed, 25 Jan 2023 04:26:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234138AbjAYJ0A (ORCPT ); Wed, 25 Jan 2023 04:26:00 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B523474D8 for ; Wed, 25 Jan 2023 01:25:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674638710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MJl0EBn4HtiAr3IA7OgQLEz430pat4/3/h3H46oRT3g=; b=KO/F8P4vq8StqgMN5WTrUy+yBRODcTmvXLkNdiWJbBvY+PrQxM152TJ52cTrRMGmJgp3hd Mq418D+5UWJW/g7TONCkcO1TCMq3/FrAUDBt9CPrkiXfrSZDdhtjHIFV6w17aWUi8qd2gu XGMkU581WKYiDI4LD9T4aRRWm3FgGkI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-246-QaNP-zQhOMC1CaHl_73W0Q-1; Wed, 25 Jan 2023 04:25:09 -0500 X-MC-Unique: QaNP-zQhOMC1CaHl_73W0Q-1 Received: by mail-wr1-f69.google.com with SMTP id v20-20020adfc5d4000000b002bdfcdb4c51so3013221wrg.9 for ; Wed, 25 Jan 2023 01:25:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MJl0EBn4HtiAr3IA7OgQLEz430pat4/3/h3H46oRT3g=; b=EKTfRmRLBgQ9QaP5ITh+GBeYsmakUj42Gkq0fooOIKfOc5f6J0sGnzjNb0KSuXUQ9O egdkSAddJ+iI0B1y0anlvK/nipUQKa5uo9/PgGXaOvWghL9xUe9Xc2t8jrdG36jnr3xZ jkBOvmG4xdGQAp7idR2jArx10UhVw04fCt55oVxtaJ2lCySM1g7AVbE5PaXefjL908L3 AQTGYMK+5gXhBtf9sX6Yos9Hhs/9zOXZYEZB+bdox7uwaXt9rI8ZQIrbBXwzYbPKLNjg kiTCpX4HvzsuWnZWDe8lp/ttZMy+PRTg1INB4MiojvM+3PYdM9xL6Q8u2mRPIB5JjX99 NRRg== X-Gm-Message-State: AFqh2kpTY+ukNflOE+jNun74YitTcZh/GKHpcoAjk/oRWl0XWCiMJQR9 g/8aNKw3v+vcb2E59xhfn4tLIwkUW3HQj+2/neXP++NKjp9O+AGChgNCRbLqGsaDbR4EktofwFM hKnPcrRyJpDMRi4I8s71CSjc= X-Received: by 2002:adf:a38d:0:b0:2bf:9527:ce62 with SMTP id l13-20020adfa38d000000b002bf9527ce62mr13001325wrb.60.1674638707870; Wed, 25 Jan 2023 01:25:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXvA3fpsEqb88MB1qU578so/hL+p+6J8snUbZz7AHyqAc1so8GvG1XEiL3HmPZITj9u0u/0ozg== X-Received: by 2002:adf:a38d:0:b0:2bf:9527:ce62 with SMTP id l13-20020adfa38d000000b002bf9527ce62mr13001312wrb.60.1674638707672; Wed, 25 Jan 2023 01:25:07 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id q8-20020adff788000000b002bfbda53b98sm534384wrp.35.2023.01.25.01.25.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 01:25:07 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 10:25:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup Content-Language: en-US To: Thomas Zimmermann , airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org References: <20230124134010.30263-1-tzimmermann@suse.de> <20230124134010.30263-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20230124134010.30263-5-tzimmermann@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 1/24/23 14:40, Thomas Zimmermann wrote: > Initialize the fb-helper structure immediately after its allocation > in drm_fbdev_generic_setup(). That will make it easier to fill it with > driver-specific values, such as the preferred BPP. > > Signed-off-by: Thomas Zimmermann > --- [...] > @@ -456,12 +454,12 @@ void drm_fbdev_generic_setup(struct drm_device *dev, > fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL); > if (!fb_helper) > return; Maybe add a new line here? > + drm_fb_helper_prepare(dev, fb_helper, &drm_fb_helper_generic_funcs); > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4DA5C27C76 for ; Wed, 25 Jan 2023 09:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cp2o3ybZDpMc49nlDigJ75I2rTpG3NlSeBUWZ/ud37A=; b=gSPE96hPoR1+DB b/kkpA+BrACsflyDwTRdKyNZtkhh1jfoDrNhFFUPuVpubLzyVqwUI3IM015EDBjAncwx3b/10SDOm +zVKtGzYTwcH8IWZD79tic3USGYzFWNOelqoPzx4OTNwyCo70zclc3F6OooTDmt5wie+5VqH8ZnXX RD0DlixmD/AulaO8ASN2dllJAVXeJRJoEylSOWaugELHexuR26HNUi/umIvXNZpnxC/kClqP0GD3K 5pkFq3iInQRqOM/IgoegOanEdlkIUGevBabPoybpaR0OW3gvWpxAzYreuhhgkma1+VXym4pd8EVRf jboxIz7PuvAbFTBPpmgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKc1s-006bkT-O4; Wed, 25 Jan 2023 09:25:16 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKc1o-006bjK-CD for linux-arm-kernel@lists.infradead.org; Wed, 25 Jan 2023 09:25:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674638711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MJl0EBn4HtiAr3IA7OgQLEz430pat4/3/h3H46oRT3g=; b=WUZuu1CSOFd4tf3lu3bthp6rF/iiEFsZA8MyMZNHSFqyIqrQqg3aiok8r91D/G/BjXos63 zA5gmvEKI4X1/ff6hXb7I5WMFKWTh7iS1xy9TtvpBqGvDCfKwKim9OrenW2ZHFQYAVWTOq FjrQZX41zsbYZ6dzMpnLNBlpRjn4sOY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-630-pLc7XNVTOVeacki6ESih8A-1; Wed, 25 Jan 2023 04:25:09 -0500 X-MC-Unique: pLc7XNVTOVeacki6ESih8A-1 Received: by mail-wr1-f71.google.com with SMTP id i28-20020adfa51c000000b002ba26dfcd08so3042451wrb.18 for ; Wed, 25 Jan 2023 01:25:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MJl0EBn4HtiAr3IA7OgQLEz430pat4/3/h3H46oRT3g=; b=yqXqO+sskWH6Znhx9L0XAvfzsncvwTmVsqi1lliMqECiVT0Xm9JTRbA+BvP5odo3qe YpW2LLwT0eQsTgtdoYbCt6ExSjVM3/b6AvwX3j4KjGkZ/TAiHBsht0eNVTOVQmL5f3iX 4pS15kXBlNPPr2evzj26MqVHJoR+XWyYviKCN6W9f9yvdib+E0VDIMJ/n9JNl3FWdqhM EobGLRLnmcUWmyjt61Y6gbjF2kI1OZribPaTb8HqEiAsrcAaTbcL0czcKSLI4+xFkYyU mln67vGC5zYPA0uc8rf8azQCzdY81/JSARO1p/SwT46+A9Wbg9PakNgMLB2ILCk69mIH eWag== X-Gm-Message-State: AFqh2krFMsafiSL+f2S7Zz1gKe5zfQgnMlDq1VPKX3pyWBSerI929Btz ze8lR9XRS5nappNBo4m03CGdohJsQI0HoFwvFXRtksDAjgywevqEue9ZEjPRkOXBLunYcnFneqi 3WHMTYwjdnKab3opPoqE2tamZ7uUbf5N24kw= X-Received: by 2002:adf:a38d:0:b0:2bf:9527:ce62 with SMTP id l13-20020adfa38d000000b002bf9527ce62mr13001328wrb.60.1674638707871; Wed, 25 Jan 2023 01:25:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXvA3fpsEqb88MB1qU578so/hL+p+6J8snUbZz7AHyqAc1so8GvG1XEiL3HmPZITj9u0u/0ozg== X-Received: by 2002:adf:a38d:0:b0:2bf:9527:ce62 with SMTP id l13-20020adfa38d000000b002bf9527ce62mr13001312wrb.60.1674638707672; Wed, 25 Jan 2023 01:25:07 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id q8-20020adff788000000b002bfbda53b98sm534384wrp.35.2023.01.25.01.25.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 01:25:07 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 10:25:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup To: Thomas Zimmermann , airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org References: <20230124134010.30263-1-tzimmermann@suse.de> <20230124134010.30263-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20230124134010.30263-5-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_012512_520001_62EA494D X-CRM114-Status: GOOD ( 11.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/24/23 14:40, Thomas Zimmermann wrote: > Initialize the fb-helper structure immediately after its allocation > in drm_fbdev_generic_setup(). That will make it easier to fill it with > driver-specific values, such as the preferred BPP. > > Signed-off-by: Thomas Zimmermann > --- [...] > @@ -456,12 +454,12 @@ void drm_fbdev_generic_setup(struct drm_device *dev, > fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL); > if (!fb_helper) > return; Maybe add a new line here? > + drm_fb_helper_prepare(dev, fb_helper, &drm_fb_helper_generic_funcs); > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel