Re: [PATCH] Revert "Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT"

From: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
To: Johan Hovold <johan@kernel.org>
Cc: <patchwork-bot+bluetooth@kernel.org>,
	Johan Hovold <johan+linaro@kernel.org>, <luiz.dentz@gmail.com>,
	<marcel@holtmann.org>, <linux-bluetooth@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
	<quic_mohamull@quicinc.com>, <quic_hbandi@quicinc.com>
Subject: Re: [PATCH] Revert "Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT"
Date: Fri, 29 Mar 2024 12:55:40 +0530	[thread overview]
Message-ID: <c03abbbd-faa5-4fdc-b7c3-5554a90c3419@quicinc.com> (raw)
In-Reply-To: <ZgWLeo5KSLurLDhK@hovoldconsulting.com>

On 3/28/2024 8:53 PM, Johan Hovold wrote:
Hi Johan,
Thanks for the valuable inputs.
> [ Please wrap your emails at 72 columns or so. ]
>

Noted.

> On Thu, Mar 28, 2024 at 08:25:16PM +0530, Janaki Ramaiah Thota wrote:
>> We made this change to configure the device which supports persistent
>> memory for the BD-Address
> 
> Can you say something more about which devices support persistent
> storage for the address? Is that all or just some of the chip variants?
> 

Most of the devices support persistent storage, and bd-address storage
is chosen based on the OEM and Target.

>> So to make device functional in both scenarios we are adding a new
>> property in dts file to distinguish persistent and non-persistent
>> support of BD Address and set HCI_QUIRK_USE_BDADDR_PROPERTY bit
>> accordingly
> 
> Depending on the answer to my questions above, you may be able to infer
> this from the compatible string and/or you can read out the address from
> the device and only set the quirk if it's set to the default address.
> 
> You should not need to add a new property for this.
> 
> Johan

As per my understanding, altering the compatible string may cause duplicate
configuration, right ?

Thanks,
JanakiRam