From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD43C433ED for ; Tue, 20 Apr 2021 09:42:36 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 22D29610A1 for ; Tue, 20 Apr 2021 09:42:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22D29610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E744412B0; Tue, 20 Apr 2021 11:42:35 +0200 (CEST) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id AAD81411A5 for ; Tue, 20 Apr 2021 11:42:33 +0200 (CEST) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FPdw4065yzjZtk; Tue, 20 Apr 2021 17:40:36 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Tue, 20 Apr 2021 17:42:24 +0800 To: Andrew Rybchenko , CC: , , , , , , , References: <1618839289-33224-1-git-send-email-humin29@huawei.com> <1618839289-33224-3-git-send-email-humin29@huawei.com> <40269202-070e-c543-391e-42c2eaaa4166@oktetlabs.ru> From: "Min Hu (Connor)" Message-ID: Date: Tue, 20 Apr 2021 17:42:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <40269202-070e-c543-391e-42c2eaaa4166@oktetlabs.ru> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 02/10] common/sfc_efx/base: delete redundant handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/4/20 17:33, Andrew Rybchenko 写道: > On 4/19/21 4:34 PM, Min Hu (Connor) wrote: >> the default case in 'rhead_nic_get_bar_region' is unreachable. > > Why? May be it is true right now, but default case is required > to handle future changes in enum and missing update here. > Well, agreed, this patch can be abandoned. >> >> This patch fixed that. >> >> Fixes: 3c1c5cc4a786 ("common/sfc_efx/base: add Riverhead support to NIC module") >> Cc: stable@dpdk.org >> >> Signed-off-by: Min Hu (Connor) > > Nack > >> --- >> drivers/common/sfc_efx/base/rhead_nic.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/common/sfc_efx/base/rhead_nic.c b/drivers/common/sfc_efx/base/rhead_nic.c >> index f2c18c1..b9af348 100644 >> --- a/drivers/common/sfc_efx/base/rhead_nic.c >> +++ b/drivers/common/sfc_efx/base/rhead_nic.c >> @@ -483,8 +483,7 @@ rhead_nic_get_bar_region( >> break; >> >> default: >> - rc = EINVAL; >> - goto fail1; >> + break; >> } >> >> return (0); >> > > . >