From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 942D8C001DE for ; Fri, 7 Jul 2023 13:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232037AbjGGN6W (ORCPT ); Fri, 7 Jul 2023 09:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229743AbjGGN6T (ORCPT ); Fri, 7 Jul 2023 09:58:19 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AC221FE8 for ; Fri, 7 Jul 2023 06:58:18 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-31427ddd3fbso1974193f8f.0 for ; Fri, 07 Jul 2023 06:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1688738296; x=1691330296; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YRYKWLcICY/w12lNxMoJVR5s2kK0wW/mWDa5IrHhho0=; b=D8DASQjM8uOnq/Et1EL0DKBNOL395SX4Pd99z5tcVN2SjA4RkVZAjGu1Q+5rD7n3RT 1zSbc0cQfgXHjkzXIhBWwpaysopWq6WFJZWseTprmcFChioMdkcVs+GXWjFeBndn8BWv 7g+0qtRSOl2QKrQJqBB11GEx4jkTiORHX/kpWkOfeEZJ8w4MWIhlx5Fz8nNjRHbBFf8A fTkd06UJg4JkK/tOaeKgd6oik7Z7R/kXeX+EFe8N6LpG1aE7saTmdFlMnGE7m5ob7OcU W9L1tZYvSDs+UAOXk+CIxXOW+eUOeG0auIrUMx8inqhz8XETF6jYv2t/6Bpu0CzFtDyt /NhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688738296; x=1691330296; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YRYKWLcICY/w12lNxMoJVR5s2kK0wW/mWDa5IrHhho0=; b=j38ij6fkT4+Oekt6hXGxa6Cg1uiyLofAkvVTNdQQYboDQhOZzw/3xiOvT5+Eos3zEC 7ZpzJJUgopRNXR0nK1Wbolyhi3Ihkyxlu0Exrj+Uhvu7RYEd5mNjzWfnIwzlixl80Xhq swKy59yMk0l6F9F8cTctJrz7WmYOHeesyB/9qkA3mMKEGYZNu9m1+CcOzuh3ZbUOBzjQ 3RvGb5DPM2+MLGQk4mE6ooc/WkKtE05Qc5DcxNBlFyVC936UCixRWX13HD7p13blrycu XE/s2KEfeghkpOXHXUDmEVLCnSlMR0UcAigjohnBoji8dJMo49d7XWnmG2wMM2OX3nkn jOsQ== X-Gm-Message-State: ABy/qLZHF073oMvwSWYqLxK+hqdOkGqWTCNau0w8wFYyjdeS67nUa848 wpWunLW8r+4DLYa2i7pV2YYiZg== X-Google-Smtp-Source: APBJJlF/IJPwi2hekpbwYkjsQKScIRJcy/Nj82kQId+zt+KJoEcW2RTRZob/tUsy1Qycfvbvjj4riA== X-Received: by 2002:adf:ee4a:0:b0:30f:af19:81f3 with SMTP id w10-20020adfee4a000000b0030faf1981f3mr4239441wro.41.1688738296585; Fri, 07 Jul 2023 06:58:16 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id f3-20020a5d5683000000b0030ae499da59sm4520881wrv.111.2023.07.07.06.58.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 06:58:15 -0700 (PDT) Message-ID: Date: Fri, 7 Jul 2023 15:58:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 4/6] thermal/drivers/mediatek/lvts_thermal: Disable undesired interrupts Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Daniel Lezcano Cc: Alexandre Bailon , Balsam CHIHI , AngeloGioacchino Del Regno , Chen-Yu Tsai , kernel@collabora.com, Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20230706153823.201943-1-nfraprado@collabora.com> <20230706153823.201943-5-nfraprado@collabora.com> From: Alexandre Mergnat In-Reply-To: <20230706153823.201943-5-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2023 17:37, Nícolas F. R. A. Prado wrote: > Out of the many interrupts supported by the hardware, the only ones of > interest to the driver currently are: > * The temperature went over the high offset threshold, for any of the > sensors > * The temperature went below the low offset threshold, for any of the > sensors > * The temperature went over the stage3 threshold > > These are the only thresholds configured by the driver through the > OFFSETH, OFFSETL, and PROTTC registers, respectively. > > The current interrupt mask in LVTS_MONINT_CONF, enables many more > interrupts, including data ready on sensors for both filtered and > immediate mode. These are not only not handled by the driver, but they > are also triggered too often, causing unneeded overhead. Disable these > unnecessary interrupts. > > The meaning of each bit can be seen in the comment describing > LVTS_MONINTST in the IRQ handler. Reviewed-by: Alexandre Mergnat -- Regards, Alexandre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 460C3EB64DA for ; Fri, 7 Jul 2023 13:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0PV0AFOGAa3wI0JTDJeqkr4snhWJDyDN8Xy+aZQzQLk=; b=DSxn1tJngno1UL /AZm2zcLHOxRvLF94eQ1A1exgqsD4V9wDv0fEq0ChfdJwbMvY9KQaebVdSp4nQDJ5pjpp3m8HMMeJ KKicIa0cqfjpL35U/j8JpdMhcuU3WdDo5AQ/Ia1lAD0j3SsvJNQ8Wz3KbihDKD6c7iXSOm49Xy/7E RbuC7DIiXo3yH/0SSEEQ1a4Gw8kifFy486KpyCYwF3WfdjDN6o3oc49VOxDjlAIWuNDsHlmRIJwK4 RDmJtoPn/TR24gGI2UJ7aogGRGthq7zgpt2mcfOEf2pL9YClwpXwobhoR2Nn198T8XGvpQxt7nfPx sCSAXka6hTHvxHeg9J0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHlyZ-004nN7-1X; Fri, 07 Jul 2023 13:58:23 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHlyW-004nLy-0t for linux-arm-kernel@lists.infradead.org; Fri, 07 Jul 2023 13:58:21 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-314313f127fso1959186f8f.1 for ; Fri, 07 Jul 2023 06:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1688738296; x=1691330296; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YRYKWLcICY/w12lNxMoJVR5s2kK0wW/mWDa5IrHhho0=; b=D8DASQjM8uOnq/Et1EL0DKBNOL395SX4Pd99z5tcVN2SjA4RkVZAjGu1Q+5rD7n3RT 1zSbc0cQfgXHjkzXIhBWwpaysopWq6WFJZWseTprmcFChioMdkcVs+GXWjFeBndn8BWv 7g+0qtRSOl2QKrQJqBB11GEx4jkTiORHX/kpWkOfeEZJ8w4MWIhlx5Fz8nNjRHbBFf8A fTkd06UJg4JkK/tOaeKgd6oik7Z7R/kXeX+EFe8N6LpG1aE7saTmdFlMnGE7m5ob7OcU W9L1tZYvSDs+UAOXk+CIxXOW+eUOeG0auIrUMx8inqhz8XETF6jYv2t/6Bpu0CzFtDyt /NhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688738296; x=1691330296; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YRYKWLcICY/w12lNxMoJVR5s2kK0wW/mWDa5IrHhho0=; b=EL2fdFCGtzosstpXwRGWZiz+0ZL0l/NA5NOpNfdgi3dNKex+fZA3j2pXaBHKdr8qyL fK76lHPcO/M27P7nrq+m0oRUFmwReAURYgOrOgy1nZ9kuWe+Q1w9cPBtQt9RxYHekt0N HH7cyxlJ/7Enl+YgN/DlpwVpyNa3pJunYxrxynpO+7SqBrjdKZtDhrKRWjUrnFYVxAiP vxHsCLRdISkrbEcPXsjm73RQPkvXGRCrGEyVrQNCsvhByLQ1JNW7ziqAm2tHEPI0ulCX PAFZRp3nD5QLgL74dUX6XDF+Z1klVAHS0B6/IUEZL0vXK//h7HilZ2XZuSsxC6AgnPeg 55Vg== X-Gm-Message-State: ABy/qLYD4Fq07M3W8RhJ0XwKNX04EfVs7JhXOfPNY2LfDuIeOnYHMTBV hp0XNlwRQATN26AwcSa9hLOqRg== X-Google-Smtp-Source: APBJJlF/IJPwi2hekpbwYkjsQKScIRJcy/Nj82kQId+zt+KJoEcW2RTRZob/tUsy1Qycfvbvjj4riA== X-Received: by 2002:adf:ee4a:0:b0:30f:af19:81f3 with SMTP id w10-20020adfee4a000000b0030faf1981f3mr4239441wro.41.1688738296585; Fri, 07 Jul 2023 06:58:16 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id f3-20020a5d5683000000b0030ae499da59sm4520881wrv.111.2023.07.07.06.58.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 06:58:15 -0700 (PDT) Message-ID: Date: Fri, 7 Jul 2023 15:58:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 4/6] thermal/drivers/mediatek/lvts_thermal: Disable undesired interrupts Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Daniel Lezcano Cc: Alexandre Bailon , Balsam CHIHI , AngeloGioacchino Del Regno , Chen-Yu Tsai , kernel@collabora.com, Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20230706153823.201943-1-nfraprado@collabora.com> <20230706153823.201943-5-nfraprado@collabora.com> From: Alexandre Mergnat In-Reply-To: <20230706153823.201943-5-nfraprado@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230707_065820_321018_1CF99CCE X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAwNi8wNy8yMDIzIDE3OjM3LCBOw61jb2xhcyBGLiBSLiBBLiBQcmFkbyB3cm90ZToKPiBP dXQgb2YgdGhlIG1hbnkgaW50ZXJydXB0cyBzdXBwb3J0ZWQgYnkgdGhlIGhhcmR3YXJlLCB0aGUg b25seSBvbmVzIG9mCj4gaW50ZXJlc3QgdG8gdGhlIGRyaXZlciBjdXJyZW50bHkgYXJlOgo+ICog VGhlIHRlbXBlcmF0dXJlIHdlbnQgb3ZlciB0aGUgaGlnaCBvZmZzZXQgdGhyZXNob2xkLCBmb3Ig YW55IG9mIHRoZQo+ICAgIHNlbnNvcnMKPiAqIFRoZSB0ZW1wZXJhdHVyZSB3ZW50IGJlbG93IHRo ZSBsb3cgb2Zmc2V0IHRocmVzaG9sZCwgZm9yIGFueSBvZiB0aGUKPiAgICBzZW5zb3JzCj4gKiBU aGUgdGVtcGVyYXR1cmUgd2VudCBvdmVyIHRoZSBzdGFnZTMgdGhyZXNob2xkCj4gCj4gVGhlc2Ug YXJlIHRoZSBvbmx5IHRocmVzaG9sZHMgY29uZmlndXJlZCBieSB0aGUgZHJpdmVyIHRocm91Z2gg dGhlCj4gT0ZGU0VUSCwgT0ZGU0VUTCwgYW5kIFBST1RUQyByZWdpc3RlcnMsIHJlc3BlY3RpdmVs eS4KPiAKPiBUaGUgY3VycmVudCBpbnRlcnJ1cHQgbWFzayBpbiBMVlRTX01PTklOVF9DT05GLCBl bmFibGVzIG1hbnkgbW9yZQo+IGludGVycnVwdHMsIGluY2x1ZGluZyBkYXRhIHJlYWR5IG9uIHNl bnNvcnMgZm9yIGJvdGggZmlsdGVyZWQgYW5kCj4gaW1tZWRpYXRlIG1vZGUuIFRoZXNlIGFyZSBu b3Qgb25seSBub3QgaGFuZGxlZCBieSB0aGUgZHJpdmVyLCBidXQgdGhleQo+IGFyZSBhbHNvIHRy aWdnZXJlZCB0b28gb2Z0ZW4sIGNhdXNpbmcgdW5uZWVkZWQgb3ZlcmhlYWQuIERpc2FibGUgdGhl c2UKPiB1bm5lY2Vzc2FyeSBpbnRlcnJ1cHRzLgo+IAo+IFRoZSBtZWFuaW5nIG9mIGVhY2ggYml0 IGNhbiBiZSBzZWVuIGluIHRoZSBjb21tZW50IGRlc2NyaWJpbmcKPiBMVlRTX01PTklOVFNUIGlu IHRoZSBJUlEgaGFuZGxlci4KClJldmlld2VkLWJ5OiBBbGV4YW5kcmUgTWVyZ25hdCA8YW1lcmdu YXRAYmF5bGlicmUuY29tPgoKLS0gClJlZ2FyZHMsCkFsZXhhbmRyZQoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=