From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53349C433EF for ; Mon, 1 Nov 2021 22:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FCFC60E9C for ; Mon, 1 Nov 2021 22:36:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232339AbhKAWid (ORCPT ); Mon, 1 Nov 2021 18:38:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232260AbhKAWia (ORCPT ); Mon, 1 Nov 2021 18:38:30 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1497C061714 for ; Mon, 1 Nov 2021 15:35:56 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mhfuB-0001Jc-7E; Mon, 01 Nov 2021 23:35:51 +0100 From: Ahmad Fatoum Subject: Re: [PATCH] arm64: dts: imx8m: add syscon node for display_blk_ctrl module regs To: Tommaso Merciai Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Peng Fan , Alice Guo , Shawn Guo , Sascha Hauer , Joakim Zhang , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Adam Ford , Lucas Stach References: <20211101222857.6940-1-tomm.merciai@gmail.com> Message-ID: Date: Mon, 1 Nov 2021 23:35:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211101222857.6940-1-tomm.merciai@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Tommaso, On 01.11.21 23:28, Tommaso Merciai wrote: > Add system controller node for registers of module Display Block Control > (DISPLAY_BLK_CTRL, base address: 0x32e28000). > The DISPLAY_BLK_CTRL module contains general purpose registers (GPRs), > which control varied features of the associated peripherals. > Reference: IMX8MMRM Rev. 3, 11/2020, p 3897 > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index 2f632e8ca388..3e496b457e1a 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -961,6 +961,11 @@ aips4: bus@32c00000 { > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > > + dispmix_gpr: display-gpr@32e28000 { > + compatible = "fsl, imx8mm-iomuxc-gpr", "syscon"; Please read vendor patches before submitting them. The space is out-of-place in the compatible and the compatible is wrong: This doesn't look like a i.MX8MM pin controller. Cheers, Ahmad > + reg = <0x32e28000 0x100>; > + }; > + > usbotg1: usb@32e40000 { > compatible = "fsl,imx8mm-usb", "fsl,imx7d-usb"; > reg = <0x32e40000 0x200>; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48DCAC433F5 for ; Mon, 1 Nov 2021 22:37:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E6C26054F for ; Mon, 1 Nov 2021 22:37:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0E6C26054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:Cc:To:Subject:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=8eXXOGdjLM5nyfeTFqMzktnwefEWYtMntNiOenTuy5k=; b=3/9o2RzANc1eyoAqe6qOOGlJCy jAXFHDyfWhRtSxSZIbwRjFq95dpX8PlN6n0LzZYzBw/Lhz+EJD2y6oDresrwMI8C0u+w2RjBz2uHV 4eSiEAUmjaJ5/4zSeetzdzJPRgMBqO/Mr2rowZe2a5yS2dYzZgQhMrBjxypkjCvwjicueLg+OmjKd RGJ1BN656q/faAm9TfLTVfIpXHnePJb1TGplba+C10FHGA+A5mNoDtbly+R1UEQ3oZ8IN5Bqfm8pR S8DlPl65OHd8ohFJjobEtItixNSYHSYi6RX/+AATWkKrmELJG2fYLnkK+3LOMdtaPpoXWfRBNnhDm hAENlVPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhfuS-00HQFO-Ev; Mon, 01 Nov 2021 22:36:08 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhfuN-00HQER-0g for linux-arm-kernel@lists.infradead.org; Mon, 01 Nov 2021 22:36:06 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mhfuB-0001Jc-7E; Mon, 01 Nov 2021 23:35:51 +0100 From: Ahmad Fatoum Subject: Re: [PATCH] arm64: dts: imx8m: add syscon node for display_blk_ctrl module regs To: Tommaso Merciai Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Peng Fan , Alice Guo , Shawn Guo , Sascha Hauer , Joakim Zhang , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Adam Ford , Lucas Stach References: <20211101222857.6940-1-tomm.merciai@gmail.com> Message-ID: Date: Mon, 1 Nov 2021 23:35:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211101222857.6940-1-tomm.merciai@gmail.com> Content-Language: en-US X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_153603_100598_C819CE5F X-CRM114-Status: GOOD ( 21.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Tommaso, On 01.11.21 23:28, Tommaso Merciai wrote: > Add system controller node for registers of module Display Block Control > (DISPLAY_BLK_CTRL, base address: 0x32e28000). > The DISPLAY_BLK_CTRL module contains general purpose registers (GPRs), > which control varied features of the associated peripherals. > Reference: IMX8MMRM Rev. 3, 11/2020, p 3897 > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index 2f632e8ca388..3e496b457e1a 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -961,6 +961,11 @@ aips4: bus@32c00000 { > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > > + dispmix_gpr: display-gpr@32e28000 { > + compatible = "fsl, imx8mm-iomuxc-gpr", "syscon"; Please read vendor patches before submitting them. The space is out-of-place in the compatible and the compatible is wrong: This doesn't look like a i.MX8MM pin controller. Cheers, Ahmad > + reg = <0x32e28000 0x100>; > + }; > + > usbotg1: usb@32e40000 { > compatible = "fsl,imx8mm-usb", "fsl,imx7d-usb"; > reg = <0x32e40000 0x200>; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel