From: Alejandro Colomar <alx.manpages@gmail.com> To: Alexei Starovoitov <alexei.starovoitov@gmail.com>, Alex Colomar <alx@kernel.org>, Alexei Starovoitov <ast@kernel.org> Cc: linux-man <linux-man@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Daniel Borkmann <daniel@iogearbox.net>, Zack Weinberg <zackw@panix.com>, LKML <linux-kernel@vger.kernel.org>, glibc <libc-alpha@sourceware.org>, GCC <gcc-patches@gcc.gnu.org>, bpf <bpf@vger.kernel.org>, LTP List <ltp@lists.linux.it>, Linux API <linux-api@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, David Laight <David.Laight@aculab.com>, Joseph Myers <joseph@codesourcery.com>, Florian Weimer <fweimer@redhat.com>, Cyril Hrubis <chrubis@suse.cz>, David Howells <dhowells@redhat.com>, Arnd Bergmann <arnd@arndb.de>, Rich Felker <dalias@libc.org>, Adhemerval Zanella <adhemerval.zanella@linaro.org>, Michael Kerrisk <mtk.manpages@gmail.com>, Linus Torvalds <torvalds@linux-foundation.org> Subject: Re: [PATCH v3] Many pages: Document fixed-width types with ISO C naming Date: Thu, 25 Aug 2022 01:36:10 +0200 [thread overview] Message-ID: <c06008bc-0c13-12f1-df85-3814b74e47f9@gmail.com> (raw) In-Reply-To: <CAADnVQKiEVL9zRtN4WY2+cTD2b3b3buV8BQb83yQw13pWq4OGQ@mail.gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 3139 bytes --] Alexei, On 8/24/22 20:55, Alejandro Colomar wrote: > Link: <https://lore.kernel.org/linux-man/20210423230609.13519-1-alx.manpages@gmail.com/T/> > Link: <https://lore.kernel.org/lkml/YZvIlz7J6vOEY+Xu@yuki/T/> > Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> > Nacked-by: Alexei Starovoitov <ast@kernel.org> > Nacked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Nacked-by: Daniel Borkmann <daniel@iogearbox.net> > Acked-by: Zack Weinberg <zackw@panix.com> On 8/25/22 00:40, Alexei Starovoitov wrote: > On Wed, Aug 24, 2022 at 12:04 PM Alejandro Colomar > <alx.manpages@gmail.com> wrote: >> >> diff --git a/man2/bpf.2 b/man2/bpf.2 >> index d05b73ec2..84d1b62e5 100644 >> --- a/man2/bpf.2 >> +++ b/man2/bpf.2 [...] >> >> struct { /* Used by BPF_PROG_LOAD */ >> - __u32 prog_type; >> - __u32 insn_cnt; >> + uint32_t prog_type; >> + uint32_t insn_cnt; > > For the N-th time: > Nacked-by: Alexei Starovoitov <ast@kernel.org> > > Please stop sending this patch. Sorry, but no. First, this has only been v3, and v1 was a year and a half ago, don't make it like I'm constantly making you lose your precious time, because I'm actively trying not to. Second, I already made a big notice that you and a few more have strongly opposed to the patch, respectfully keeping all of your NAKs in my patch, as you can see above. I gave very detailed reasons of why this patch is reasonable and, back in the days of v1, Zack (from glibc) gave even better reasons of why the manual pages should document ISO C (libc) types, and not kernel ones, and why it shouldn't matter to user-space programmers. But from your side what do we have? Just direct NAKs without much explanation. The only one who gave some explanation was Greg, and he vaguely pointed to Linus's comments about it in the past, with no precise pointer to it. I investigated a lot before v2, and could not find anything strong enough to recommend using kernel types in user space, so I pushed v2, and the discussion was kept. I would like that if you still oppose to the patch, at least were able to provide some facts to this discussion. But the most fundamental thing that I ask is that you respect me. With this attitude, the only thing you're going to get is that I apply the patch right after, because: 1) The patch is right. Go talk to glibc and gcc maintainers, who know how types work by heart if you have doubts. 2) I'm the maintainer of this project, and under doubts, it's my decission. I'm trying to be nice, and ask for review to make sure I'm not making some big mistake by accident, and I get disrespect? No thanks. Patch applied. Now, if someone with a bit more respect still thinks this change is incorrect, and is wanting to share some facts to show me my mistake, I'll happily review it and revert the patch if necessary. For now, the patch is applied. Alex -- Alejandro Colomar Linux man-pages maintainer <http://www.alejandro-colomar.es/> [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Alejandro Colomar <alx.manpages@gmail.com> To: Alexei Starovoitov <alexei.starovoitov@gmail.com>, Alex Colomar <alx@kernel.org>, Alexei Starovoitov <ast@kernel.org> Cc: linux-man <linux-man@vger.kernel.org>, Rich Felker <dalias@libc.org>, Alexei Starovoitov <ast@kernel.org>, David Howells <dhowells@redhat.com>, Joseph Myers <joseph@codesourcery.com>, linux-arch <linux-arch@vger.kernel.org>, Zack Weinberg <zackw@panix.com>, Daniel Borkmann <daniel@iogearbox.net>, Michael Kerrisk <mtk.manpages@gmail.com>, Adhemerval Zanella <adhemerval.zanella@linaro.org>, Arnd Bergmann <arnd@arndb.de>, GCC <gcc-patches@gcc.gnu.org>, LTP List <ltp@lists.linux.it>, glibc <libc-alpha@sourceware.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, LKML <linux-kernel@vger.kernel.org>, David Laight <David.Laight@aculab.com>, Linux API <linux-api@vger.kernel.org>, bpf <bpf@vger.kernel.org>, Linus Torvalds <torvalds@linux-foundation.org> Subject: Re: [LTP] [PATCH v3] Many pages: Document fixed-width types with ISO C naming Date: Thu, 25 Aug 2022 01:36:10 +0200 [thread overview] Message-ID: <c06008bc-0c13-12f1-df85-3814b74e47f9@gmail.com> (raw) In-Reply-To: <CAADnVQKiEVL9zRtN4WY2+cTD2b3b3buV8BQb83yQw13pWq4OGQ@mail.gmail.com> [-- Attachment #1.1.1: Type: text/plain, Size: 3139 bytes --] Alexei, On 8/24/22 20:55, Alejandro Colomar wrote: > Link: <https://lore.kernel.org/linux-man/20210423230609.13519-1-alx.manpages@gmail.com/T/> > Link: <https://lore.kernel.org/lkml/YZvIlz7J6vOEY+Xu@yuki/T/> > Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> > Nacked-by: Alexei Starovoitov <ast@kernel.org> > Nacked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Nacked-by: Daniel Borkmann <daniel@iogearbox.net> > Acked-by: Zack Weinberg <zackw@panix.com> On 8/25/22 00:40, Alexei Starovoitov wrote: > On Wed, Aug 24, 2022 at 12:04 PM Alejandro Colomar > <alx.manpages@gmail.com> wrote: >> >> diff --git a/man2/bpf.2 b/man2/bpf.2 >> index d05b73ec2..84d1b62e5 100644 >> --- a/man2/bpf.2 >> +++ b/man2/bpf.2 [...] >> >> struct { /* Used by BPF_PROG_LOAD */ >> - __u32 prog_type; >> - __u32 insn_cnt; >> + uint32_t prog_type; >> + uint32_t insn_cnt; > > For the N-th time: > Nacked-by: Alexei Starovoitov <ast@kernel.org> > > Please stop sending this patch. Sorry, but no. First, this has only been v3, and v1 was a year and a half ago, don't make it like I'm constantly making you lose your precious time, because I'm actively trying not to. Second, I already made a big notice that you and a few more have strongly opposed to the patch, respectfully keeping all of your NAKs in my patch, as you can see above. I gave very detailed reasons of why this patch is reasonable and, back in the days of v1, Zack (from glibc) gave even better reasons of why the manual pages should document ISO C (libc) types, and not kernel ones, and why it shouldn't matter to user-space programmers. But from your side what do we have? Just direct NAKs without much explanation. The only one who gave some explanation was Greg, and he vaguely pointed to Linus's comments about it in the past, with no precise pointer to it. I investigated a lot before v2, and could not find anything strong enough to recommend using kernel types in user space, so I pushed v2, and the discussion was kept. I would like that if you still oppose to the patch, at least were able to provide some facts to this discussion. But the most fundamental thing that I ask is that you respect me. With this attitude, the only thing you're going to get is that I apply the patch right after, because: 1) The patch is right. Go talk to glibc and gcc maintainers, who know how types work by heart if you have doubts. 2) I'm the maintainer of this project, and under doubts, it's my decission. I'm trying to be nice, and ask for review to make sure I'm not making some big mistake by accident, and I get disrespect? No thanks. Patch applied. Now, if someone with a bit more respect still thinks this change is incorrect, and is wanting to share some facts to show me my mistake, I'll happily review it and revert the patch if necessary. For now, the patch is applied. Alex -- Alejandro Colomar Linux man-pages maintainer <http://www.alejandro-colomar.es/> [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 60 bytes --] -- Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-08-24 23:36 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-23 23:06 [RFC] bpf.2: Use standard types and attributes Alejandro Colomar 2021-04-23 23:20 ` Alexei Starovoitov 2021-04-24 17:56 ` Alejandro Colomar (man-pages) 2021-04-25 16:52 ` Alexei Starovoitov 2021-04-25 19:12 ` Zack Weinberg 2021-04-24 20:43 ` David Laight 2021-04-25 19:16 ` Zack Weinberg 2021-04-25 21:09 ` David Laight 2021-04-26 17:19 ` Joseph Myers 2021-04-26 17:46 ` Alejandro Colomar (man-pages) 2021-05-04 11:05 ` [RFC v2] " Alejandro Colomar 2021-05-04 14:12 ` Alexei Starovoitov 2021-05-04 14:24 ` Greg KH 2021-05-04 15:53 ` Alejandro Colomar (man-pages) 2021-05-04 16:06 ` Greg KH 2021-05-04 18:37 ` Zack Weinberg 2021-05-04 18:54 ` Alejandro Colomar (man-pages) 2021-05-04 19:45 ` Florian Weimer 2021-05-04 19:59 ` Alejandro Colomar (man-pages) 2021-05-05 8:23 ` David Laight 2021-05-05 22:22 ` Joseph Myers 2021-05-04 20:06 ` Daniel Borkmann 2021-05-04 20:16 ` Alejandro Colomar (man-pages) 2021-05-04 20:33 ` Zack Weinberg 2021-05-04 21:23 ` Alexei Starovoitov 2021-05-15 19:01 ` [PATCH v3] " Alejandro Colomar 2021-05-16 9:16 ` Alejandro Colomar (man-pages) 2021-05-17 18:56 ` Daniel Borkmann 2021-05-21 11:12 ` Alejandro Colomar 2021-05-04 16:08 ` [RFC v2] " Daniel Borkmann 2022-08-24 18:55 ` [PATCH v3] Many pages: Document fixed-width types with ISO C naming Alejandro Colomar 2022-08-24 18:55 ` [LTP] " Alejandro Colomar 2022-08-24 22:40 ` Alexei Starovoitov 2022-08-24 22:40 ` [LTP] " Alexei Starovoitov 2022-08-24 23:36 ` Alejandro Colomar [this message] 2022-08-24 23:36 ` Alejandro Colomar 2022-08-25 0:52 ` Linus Torvalds 2022-08-25 0:52 ` [LTP] " Linus Torvalds 2022-08-25 7:20 ` Alejandro Colomar 2022-08-25 7:20 ` [LTP] " Alejandro Colomar 2022-08-25 7:28 ` Xi Ruoyao 2022-08-25 7:28 ` [LTP] " Xi Ruoyao via ltp 2022-08-25 7:48 ` Alejandro Colomar 2022-08-25 7:48 ` [LTP] " Alejandro Colomar 2022-08-25 8:09 ` Xi Ruoyao 2022-08-25 8:09 ` [LTP] " Xi Ruoyao via ltp 2022-08-25 7:42 ` Linus Torvalds 2022-08-25 7:42 ` [LTP] " Linus Torvalds 2022-08-25 7:59 ` Alejandro Colomar 2022-08-25 7:59 ` [LTP] " Alejandro Colomar 2022-08-25 5:57 ` Greg Kroah-Hartman 2022-08-25 5:57 ` [LTP] " Greg Kroah-Hartman 2022-08-25 6:41 ` Florian Weimer 2022-08-25 6:41 ` [LTP] " Florian Weimer 2022-08-25 7:27 ` Linus Torvalds 2022-08-25 7:27 ` [LTP] " Linus Torvalds 2022-08-25 14:38 ` Joseph Myers 2022-08-25 14:38 ` [LTP] " Joseph Myers 2022-08-25 15:01 ` David Laight 2022-08-25 15:01 ` David Laight 2022-08-25 15:37 ` Joseph Myers 2022-08-25 15:37 ` [LTP] " Joseph Myers 2022-08-25 16:43 ` Linus Torvalds 2022-08-25 16:43 ` Linus Torvalds 2022-08-25 7:44 ` Alejandro Colomar 2022-08-25 7:44 ` [LTP] " Alejandro Colomar 2022-08-25 8:04 ` Alejandro Colomar 2022-08-25 8:04 ` [LTP] " Alejandro Colomar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c06008bc-0c13-12f1-df85-3814b74e47f9@gmail.com \ --to=alx.manpages@gmail.com \ --cc=David.Laight@aculab.com \ --cc=adhemerval.zanella@linaro.org \ --cc=alexei.starovoitov@gmail.com \ --cc=alx@kernel.org \ --cc=arnd@arndb.de \ --cc=ast@kernel.org \ --cc=bpf@vger.kernel.org \ --cc=chrubis@suse.cz \ --cc=dalias@libc.org \ --cc=daniel@iogearbox.net \ --cc=dhowells@redhat.com \ --cc=fweimer@redhat.com \ --cc=gcc-patches@gcc.gnu.org \ --cc=gregkh@linuxfoundation.org \ --cc=joseph@codesourcery.com \ --cc=libc-alpha@sourceware.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-man@vger.kernel.org \ --cc=ltp@lists.linux.it \ --cc=mtk.manpages@gmail.com \ --cc=torvalds@linux-foundation.org \ --cc=zackw@panix.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.