From: Alistair Francis <alistair.francis@xilinx.com>
To: qemu-devel@nongnu.org, edgar.iglesias@xilinx.com,
edgar.iglesias@gmail.com
Cc: alistair.francis@xilinx.com, alistair23@gmail.com,
frasse.iglesias@gmail.com, frederic.konrad@adacore.com
Subject: [Qemu-devel] [PATCH-2.12 v3 3/3] xilinx_spips: Use memset instead of a for loop to zero registers
Date: Tue, 12 Dec 2017 10:54:18 -0800 [thread overview]
Message-ID: <c076e907f355923864cb1afde31b938ffb677778.1513104804.git.alistair.francis@xilinx.com> (raw)
In-Reply-To: <cover.1513104804.git.alistair.francis@xilinx.com>
Use memset() instead of a for loop to zero all of the registers.
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
---
hw/ssi/xilinx_spips.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
index 42d9b04bd3..d8187fadd1 100644
--- a/hw/ssi/xilinx_spips.c
+++ b/hw/ssi/xilinx_spips.c
@@ -329,10 +329,7 @@ static void xilinx_spips_reset(DeviceState *d)
{
XilinxSPIPS *s = XILINX_SPIPS(d);
- int i;
- for (i = 0; i < XLNX_SPIPS_R_MAX; i++) {
- s->regs[i] = 0;
- }
+ memset(s->regs, 0, sizeof(s->regs));
fifo8_reset(&s->rx_fifo);
fifo8_reset(&s->rx_fifo);
@@ -357,13 +354,11 @@ static void xilinx_spips_reset(DeviceState *d)
static void xlnx_zynqmp_qspips_reset(DeviceState *d)
{
XlnxZynqMPQSPIPS *s = XLNX_ZYNQMP_QSPIPS(d);
- int i;
xilinx_spips_reset(d);
- for (i = 0; i < XLNX_ZYNQMP_SPIPS_R_MAX; i++) {
- s->regs[i] = 0;
- }
+ memset(s->regs, 0, sizeof(s->regs));
+
fifo8_reset(&s->rx_fifo_g);
fifo8_reset(&s->rx_fifo_g);
fifo32_reset(&s->fifo_g);
--
2.14.1
next prev parent reply other threads:[~2017-12-12 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 18:54 [Qemu-devel] [PATCH-2.12 v3 0/3] Update the reset values of the Xilinx ZynqMP QSPI Alistair Francis
2017-12-12 18:54 ` [Qemu-devel] [PATCH-2.12 v3 1/3] xilinx_spips: Update the QSPI Mod ID reset value Alistair Francis
2017-12-12 18:54 ` [Qemu-devel] [PATCH-2.12 v3 2/3] xilinx_spips: Set all of the reset values Alistair Francis
2017-12-12 18:54 ` Alistair Francis [this message]
2017-12-13 10:27 ` [Qemu-devel] [PATCH-2.12 v3 0/3] Update the reset values of the Xilinx ZynqMP QSPI Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c076e907f355923864cb1afde31b938ffb677778.1513104804.git.alistair.francis@xilinx.com \
--to=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=frasse.iglesias@gmail.com \
--cc=frederic.konrad@adacore.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.