From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34FE9FA3741 for ; Thu, 13 Sep 2018 17:35:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C21F321764 for ; Thu, 13 Sep 2018 17:03:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="c+iC1A15" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C21F321764 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728079AbeIMWN3 (ORCPT ); Thu, 13 Sep 2018 18:13:29 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:39242 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727194AbeIMWN3 (ORCPT ); Thu, 13 Sep 2018 18:13:29 -0400 Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id DE1CA5C08FA; Thu, 13 Sep 2018 19:03:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1536858185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qs6EwoQxE4uEtaTssWazrM/iPyDz2Vd2ED8zUwOJyt0=; b=c+iC1A15QxroK+WY/C3KshQQcIdlYeLcMRu94rMl2jEh1R1LvOxTJWTMJZbvJ6qftp794v nzv7ywwZJkoAtOyN/uC8Pjwem/rkFaywkQHFxY6QkFxIoDDIvy0eIXo2IaH5h0TvGjcNBH lO6RHcFrBfWb6iWFn7evC9h7y8BAk5I= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Thu, 13 Sep 2018 10:03:05 -0700 From: Stefan Agner To: Philipp Zabel Cc: linus.walleij@linaro.org, Laurent.pinchart@ideasonboard.com, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, fabio.estevam@nxp.com, linux-imx@nxp.com, architt@codeaurora.org, a.hajda@samsung.com, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, sean@poorly.run, marcel.ziswiler@toradex.com, max.krummenacher@toradex.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/8] drm/imx: support handling bridge timings bus flags In-Reply-To: <1536827930.3452.4.camel@pengutronix.de> References: <20180912183222.25414-1-stefan@agner.ch> <20180912183222.25414-7-stefan@agner.ch> <1536827930.3452.4.camel@pengutronix.de> Message-ID: X-Sender: stefan@agner.ch User-Agent: Roundcube Webmail/1.3.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13.09.2018 01:38, Philipp Zabel wrote: > On Wed, 2018-09-12 at 11:32 -0700, Stefan Agner wrote: >> A bridge might require specific settings for the pixel data on >> the bus. > > On which bus? The bridge has input and output. > >> Copy the bus flags from the bridge timings if a bridge >> is in use. >> >> Signed-off-by: Stefan Agner >> --- >> drivers/gpu/drm/imx/parallel-display.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c >> index aefd04e18f93..7798a0621df7 100644 >> --- a/drivers/gpu/drm/imx/parallel-display.c >> +++ b/drivers/gpu/drm/imx/parallel-display.c >> @@ -239,6 +239,9 @@ static int imx_pd_bind(struct device *dev, struct device *master, void *data) >> if (ret && ret != -ENODEV) >> return ret; >> >> + if (imxpd->bridge && imxpd->bridge->timings) >> + imxpd->bus_flags = imxpd->bridge->timings->input_bus_flags; > > Oh, ok. I'd also specify input bus in the commit message. > Good point, will change in v3 to: "A bridge might require specific settings for the pixel data on its input bus. Those are specified through optional bus timings. Copy the bridges input bus flags as to the imxpd bus flags." -- Stefan >> + >> imxpd->dev = dev; >> >> ret = imx_pd_register(drm, imxpd); > > regards > Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Subject: Re: [PATCH v2 6/8] drm/imx: support handling bridge timings bus flags Date: Thu, 13 Sep 2018 10:03:05 -0700 Message-ID: References: <20180912183222.25414-1-stefan@agner.ch> <20180912183222.25414-7-stefan@agner.ch> <1536827930.3452.4.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1536827930.3452.4.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, max.krummenacher@toradex.com, marcel.ziswiler@toradex.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, Laurent.pinchart@ideasonboard.com, kernel@pengutronix.de, fabio.estevam@nxp.com, sean@poorly.run, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com List-Id: devicetree@vger.kernel.org T24gMTMuMDkuMjAxOCAwMTozOCwgUGhpbGlwcCBaYWJlbCB3cm90ZToKPiBPbiBXZWQsIDIwMTgt MDktMTIgYXQgMTE6MzIgLTA3MDAsIFN0ZWZhbiBBZ25lciB3cm90ZToKPj4gQSBicmlkZ2UgbWln aHQgcmVxdWlyZSBzcGVjaWZpYyBzZXR0aW5ncyBmb3IgdGhlIHBpeGVsIGRhdGEgb24KPj4gdGhl IGJ1cy4KPiAKPiBPbiB3aGljaCBidXM/IFRoZSBicmlkZ2UgaGFzIGlucHV0IGFuZCBvdXRwdXQu Cj4gCj4+IENvcHkgdGhlIGJ1cyBmbGFncyBmcm9tIHRoZSBicmlkZ2UgdGltaW5ncyBpZiBhIGJy aWRnZQo+PiBpcyBpbiB1c2UuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbiBBZ25lciA8c3Rl ZmFuQGFnbmVyLmNoPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pbXgvcGFyYWxsZWwtZGlz cGxheS5jIHwgMyArKysKPj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKPj4KPj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pbXgvcGFyYWxsZWwtZGlzcGxheS5jIGIvZHJp dmVycy9ncHUvZHJtL2lteC9wYXJhbGxlbC1kaXNwbGF5LmMKPj4gaW5kZXggYWVmZDA0ZTE4Zjkz Li43Nzk4YTA2MjFkZjcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pbXgvcGFyYWxs ZWwtZGlzcGxheS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pbXgvcGFyYWxsZWwtZGlzcGxh eS5jCj4+IEBAIC0yMzksNiArMjM5LDkgQEAgc3RhdGljIGludCBpbXhfcGRfYmluZChzdHJ1Y3Qg ZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2UgKm1hc3Rlciwgdm9pZCAqZGF0YSkKPj4gIAlpZiAo cmV0ICYmIHJldCAhPSAtRU5PREVWKQo+PiAgCQlyZXR1cm4gcmV0Owo+Pgo+PiArCWlmIChpbXhw ZC0+YnJpZGdlICYmIGlteHBkLT5icmlkZ2UtPnRpbWluZ3MpCj4+ICsJCWlteHBkLT5idXNfZmxh Z3MgPSBpbXhwZC0+YnJpZGdlLT50aW1pbmdzLT5pbnB1dF9idXNfZmxhZ3M7Cj4gCj4gT2gsIG9r LiBJJ2QgYWxzbyBzcGVjaWZ5IGlucHV0IGJ1cyBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuCj4gCgpH b29kIHBvaW50LCB3aWxsIGNoYW5nZSBpbiB2MyB0bzoKCiJBIGJyaWRnZSBtaWdodCByZXF1aXJl IHNwZWNpZmljIHNldHRpbmdzIGZvciB0aGUgcGl4ZWwgZGF0YSBvbgppdHMgaW5wdXQgYnVzLiBU aG9zZSBhcmUgc3BlY2lmaWVkIHRocm91Z2ggb3B0aW9uYWwgYnVzIHRpbWluZ3MuCkNvcHkgdGhl IGJyaWRnZXMgaW5wdXQgYnVzIGZsYWdzIGFzIHRvIHRoZSBpbXhwZCBidXMgZmxhZ3MuIgoKLS0K U3RlZmFuCgo+PiArCj4+ICAJaW14cGQtPmRldiA9IGRldjsKPj4KPj4gIAlyZXQgPSBpbXhfcGRf cmVnaXN0ZXIoZHJtLCBpbXhwZCk7Cj4gCj4gcmVnYXJkcwo+IFBoaWxpcHAKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefan@agner.ch (Stefan Agner) Date: Thu, 13 Sep 2018 10:03:05 -0700 Subject: [PATCH v2 6/8] drm/imx: support handling bridge timings bus flags In-Reply-To: <1536827930.3452.4.camel@pengutronix.de> References: <20180912183222.25414-1-stefan@agner.ch> <20180912183222.25414-7-stefan@agner.ch> <1536827930.3452.4.camel@pengutronix.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 13.09.2018 01:38, Philipp Zabel wrote: > On Wed, 2018-09-12 at 11:32 -0700, Stefan Agner wrote: >> A bridge might require specific settings for the pixel data on >> the bus. > > On which bus? The bridge has input and output. > >> Copy the bus flags from the bridge timings if a bridge >> is in use. >> >> Signed-off-by: Stefan Agner >> --- >> drivers/gpu/drm/imx/parallel-display.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c >> index aefd04e18f93..7798a0621df7 100644 >> --- a/drivers/gpu/drm/imx/parallel-display.c >> +++ b/drivers/gpu/drm/imx/parallel-display.c >> @@ -239,6 +239,9 @@ static int imx_pd_bind(struct device *dev, struct device *master, void *data) >> if (ret && ret != -ENODEV) >> return ret; >> >> + if (imxpd->bridge && imxpd->bridge->timings) >> + imxpd->bus_flags = imxpd->bridge->timings->input_bus_flags; > > Oh, ok. I'd also specify input bus in the commit message. > Good point, will change in v3 to: "A bridge might require specific settings for the pixel data on its input bus. Those are specified through optional bus timings. Copy the bridges input bus flags as to the imxpd bus flags." -- Stefan >> + >> imxpd->dev = dev; >> >> ret = imx_pd_register(drm, imxpd); > > regards > Philipp