All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: LIU Zhiwei <zhiwei_liu@c-sky.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] configure: Support modules for Windows
Date: Fri, 5 Nov 2021 13:36:27 +0300	[thread overview]
Message-ID: <c082bdc1-f2d7-1943-31dd-629f28bb3b11@msgid.tls.msk.ru> (raw)
In-Reply-To: <20211105032002.83792-1-zhiwei_liu@c-sky.com>

05.11.2021 06:20, LIU Zhiwei wrote:
...
> diff --git a/meson.build b/meson.build
> index 47df10afc2..26195cb24f 100644
...
> @@ -2800,14 +2800,15 @@ common_ss.add(hwcore)
>   ###########
>   # Targets #
>   ###########
> -
> -foreach m : block_mods + softmmu_mods
> -  shared_module(m.name(),
> -                name_prefix: '',
> -                link_whole: m,
> -                install: true,
> -                install_dir: qemu_moddir)
> -endforeach
> +if targetos != 'windows'
> +  foreach m : block_mods + softmmu_mods
> +    shared_module(m.name(),
> +                  name_prefix: '',
> +                  link_whole: m,
> +                  install: true,
> +                  install_dir: qemu_moddir)
> +  endforeach
> +endif
>   
>   softmmu_ss.add(authz, blockdev, chardev, crypto, io, qmp)
>   common_ss.add(qom, qemuutil)
> @@ -2826,6 +2827,7 @@ common_all = static_library('common',
>   feature_to_c = find_program('scripts/feature_to_c.sh')
>   
>   emulators = {}
> +emulator = 0

mm...
...
> @@ -3023,6 +3026,17 @@ foreach target : target_dirs
>       endif
>     endforeach
>   endforeach
> +if (targetos == 'windows')
> +  foreach m : block_mods + softmmu_mods
> +    shared_module(m.name(),
> +	    name_prefix: '',
> +	    link_whole: m,
> +	    install: true,
> +	    dependencies: glib,
> +	    link_with: emulator,
> +	    install_dir: qemu_moddir)
> +  endforeach
> +endif

Now we have two almost-identical blocks in different places.
Can we either move them closer to each other or combine them into one?

Thanks!

/mjt


  parent reply	other threads:[~2021-11-05 10:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05  3:20 [PATCH] configure: Support modules for Windows LIU Zhiwei
2021-11-05  9:30 ` Daniel P. Berrangé
2021-11-05 12:14   ` LIU Zhiwei
2021-11-05 12:22     ` Daniel P. Berrangé
2021-11-05 12:33       ` LIU Zhiwei
2021-11-05 10:36 ` Michael Tokarev [this message]
2021-11-05 12:21   ` LIU Zhiwei
  -- strict thread matches above, loose matches on Subject: below --
2021-11-05  3:19 LIU Zhiwei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c082bdc1-f2d7-1943-31dd-629f28bb3b11@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=zhiwei_liu@c-sky.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.