From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Jason Wang <jasowang@redhat.com>,
Alistair Francis <alistair@alistair23.me>,
Jean-Christophe Dubois <jcd@tribudubois.net>,
Beniamino Galvani <b.galvani@gmail.com>,
Igor Mitsyanko <i.mitsyanko@gmail.com>,
qemu-arm@nongnu.org, Peter Chubb <peter.chubb@nicta.com.au>,
Antony Pavlov <antonynpavlov@gmail.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/6] hw/arm: Use object_initialize_child for correct reference counting
Date: Fri, 23 Aug 2019 10:21:45 -0700 [thread overview]
Message-ID: <c084a635-f043-06bf-6226-9832978ca003@linaro.org> (raw)
In-Reply-To: <20190823143249.8096-3-philmd@redhat.com>
On 8/23/19 7:32 AM, Philippe Mathieu-Daudé wrote:
> As explained in commit aff39be0ed97:
>
> Both functions, object_initialize() and object_property_add_child()
> increase the reference counter of the new object, so one of the
> references has to be dropped afterwards to get the reference
> counting right. Otherwise the child object will not be properly
> cleaned up when the parent gets destroyed.
> Thus let's use now object_initialize_child() instead to get the
> reference counting here right.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/arm/mcimx7d-sabre.c | 9 ++++-----
> hw/arm/mps2-tz.c | 15 +++++++--------
> hw/arm/musca.c | 9 +++++----
> 3 files changed, 16 insertions(+), 17 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-08-23 17:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 14:32 [Qemu-devel] [PATCH v2 0/6] hw/arm: Use ARM_CPU_TYPE_NAME() and object_initialize_child() Philippe Mathieu-Daudé
2019-08-23 14:32 ` [Qemu-devel] [PATCH v2 1/6] hw/arm: Use ARM_CPU_TYPE_NAME() macro when appropriate Philippe Mathieu-Daudé
2019-08-23 17:19 ` Richard Henderson
2019-08-23 14:32 ` [Qemu-devel] [PATCH v2 2/6] hw/arm: Use object_initialize_child for correct reference counting Philippe Mathieu-Daudé
2019-08-23 15:14 ` Thomas Huth
2019-08-23 17:21 ` Richard Henderson [this message]
2019-08-23 14:32 ` [Qemu-devel] [PATCH v2 3/6] hw/arm: Use sysbus_init_child_obj " Philippe Mathieu-Daudé
2019-08-23 15:26 ` Thomas Huth
2019-09-03 12:54 ` Peter Maydell
2019-08-23 17:24 ` Richard Henderson
2019-08-23 14:32 ` [Qemu-devel] [PATCH v2 4/6] hw/arm/fsl-imx: Add the cpu as child of the SoC object Philippe Mathieu-Daudé
2019-08-23 17:26 ` Richard Henderson
2019-08-23 14:32 ` [Qemu-devel] [PATCH v2 5/6] hw/dma/xilinx_axi: Use object_initialize_child for correct ref. counting Philippe Mathieu-Daudé
2019-08-23 17:29 ` Richard Henderson
2019-08-23 17:36 ` Thomas Huth
2019-08-23 14:32 ` [Qemu-devel] [PATCH v2 6/6] hw/net/xilinx_axi: " Philippe Mathieu-Daudé
2019-08-23 17:31 ` Richard Henderson
2019-08-23 17:34 ` Thomas Huth
2019-09-06 10:04 ` [Qemu-devel] [PATCH v2 0/6] hw/arm: Use ARM_CPU_TYPE_NAME() and object_initialize_child() Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c084a635-f043-06bf-6226-9832978ca003@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair@alistair23.me \
--cc=andrew.smirnov@gmail.com \
--cc=antonynpavlov@gmail.com \
--cc=b.galvani@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=i.mitsyanko@gmail.com \
--cc=jasowang@redhat.com \
--cc=jcd@tribudubois.net \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.