From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v2 1/6] ARM: tegra: Remove cpuidle drivers Date: Thu, 11 Jul 2019 10:26:13 +0100 Message-ID: References: <20190711031312.10038-1-digetx@gmail.com> <20190711031312.10038-2-digetx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190711031312.10038-2-digetx@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Osipenko , Thierry Reding , Peter De Schrijver , "Rafael J. Wysocki" , Daniel Lezcano Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On 11/07/2019 04:13, Dmitry Osipenko wrote: > Remove the old drivers to replace them cleanly with a new one later on. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/mach-tegra/Makefile | 13 -- > arch/arm/mach-tegra/cpuidle-tegra114.c | 89 ----------- > arch/arm/mach-tegra/cpuidle-tegra20.c | 212 ------------------------- > arch/arm/mach-tegra/cpuidle-tegra30.c | 132 --------------- > arch/arm/mach-tegra/cpuidle.c | 50 ------ > arch/arm/mach-tegra/cpuidle.h | 21 --- > arch/arm/mach-tegra/irq.c | 18 --- > arch/arm/mach-tegra/irq.h | 11 -- > arch/arm/mach-tegra/pm.c | 7 - > arch/arm/mach-tegra/pm.h | 1 - > arch/arm/mach-tegra/reset-handler.S | 11 -- > arch/arm/mach-tegra/reset.h | 9 +- > arch/arm/mach-tegra/sleep-tegra20.S | 190 +--------------------- > arch/arm/mach-tegra/sleep.h | 12 -- > arch/arm/mach-tegra/tegra.c | 3 - > drivers/soc/tegra/Kconfig | 1 - > include/soc/tegra/cpuidle.h | 4 - > 17 files changed, 5 insertions(+), 779 deletions(-) > delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra114.c > delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra20.c > delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra30.c > delete mode 100644 arch/arm/mach-tegra/cpuidle.c > delete mode 100644 arch/arm/mach-tegra/cpuidle.h > delete mode 100644 arch/arm/mach-tegra/irq.h By removing all the above, it is really hard to review the diff. Is there any way you could first consolidate the cpuidle drivers into say the existing arch/arm/mach-tegra/cpuidle-tegra20.c and then move to drivers/cpuidle? Jon -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F56AC74A52 for ; Thu, 11 Jul 2019 09:26:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D85E6208E4 for ; Thu, 11 Jul 2019 09:26:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="bbF0YZqR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728310AbfGKJ0T (ORCPT ); Thu, 11 Jul 2019 05:26:19 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:16056 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726088AbfGKJ0S (ORCPT ); Thu, 11 Jul 2019 05:26:18 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 11 Jul 2019 02:26:22 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 11 Jul 2019 02:26:17 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 11 Jul 2019 02:26:17 -0700 Received: from [10.21.132.148] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 11 Jul 2019 09:26:15 +0000 Subject: Re: [PATCH v2 1/6] ARM: tegra: Remove cpuidle drivers To: Dmitry Osipenko , Thierry Reding , Peter De Schrijver , "Rafael J. Wysocki" , Daniel Lezcano CC: , , , References: <20190711031312.10038-1-digetx@gmail.com> <20190711031312.10038-2-digetx@gmail.com> From: Jon Hunter Message-ID: Date: Thu, 11 Jul 2019 10:26:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190711031312.10038-2-digetx@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1562837182; bh=hqIKbaLc9u3UzCLBN+TeJmaoAdvZZzW+MJhMM3sW0uY=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=bbF0YZqRGy0UYIMDV+2nHio1AliAu0r+Pj2lye6MoUfl1nPCx6h3eIgTiVsMLPlNQ Br5tEJk3HRK62aXro7HboHWQQHR/oVb4IRR7Ra5OaiIF/0srCD6aen9R59wAW5UDXB hSIQoBLPYecQPq0mqcY8waaODaZ04MkZo9CuSoEwEOxvGbFO34ohFnXfk/s3B8xTcq +3VPzdC/1IDOmHbIqRR4PDPhj+9iAeaqoRxjXgACWMvIqw1mxmTo8hfJh5CQu5ya7k s7l5xpDZ8klmr83hfskwnKIMMC4w/qT/KG71NB3wrycPi8/yeCb6ph8Ek640Guq9dG 0WRkc6OdafrNw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2019 04:13, Dmitry Osipenko wrote: > Remove the old drivers to replace them cleanly with a new one later on. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/mach-tegra/Makefile | 13 -- > arch/arm/mach-tegra/cpuidle-tegra114.c | 89 ----------- > arch/arm/mach-tegra/cpuidle-tegra20.c | 212 ------------------------- > arch/arm/mach-tegra/cpuidle-tegra30.c | 132 --------------- > arch/arm/mach-tegra/cpuidle.c | 50 ------ > arch/arm/mach-tegra/cpuidle.h | 21 --- > arch/arm/mach-tegra/irq.c | 18 --- > arch/arm/mach-tegra/irq.h | 11 -- > arch/arm/mach-tegra/pm.c | 7 - > arch/arm/mach-tegra/pm.h | 1 - > arch/arm/mach-tegra/reset-handler.S | 11 -- > arch/arm/mach-tegra/reset.h | 9 +- > arch/arm/mach-tegra/sleep-tegra20.S | 190 +--------------------- > arch/arm/mach-tegra/sleep.h | 12 -- > arch/arm/mach-tegra/tegra.c | 3 - > drivers/soc/tegra/Kconfig | 1 - > include/soc/tegra/cpuidle.h | 4 - > 17 files changed, 5 insertions(+), 779 deletions(-) > delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra114.c > delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra20.c > delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra30.c > delete mode 100644 arch/arm/mach-tegra/cpuidle.c > delete mode 100644 arch/arm/mach-tegra/cpuidle.h > delete mode 100644 arch/arm/mach-tegra/irq.h By removing all the above, it is really hard to review the diff. Is there any way you could first consolidate the cpuidle drivers into say the existing arch/arm/mach-tegra/cpuidle-tegra20.c and then move to drivers/cpuidle? Jon -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53796C74A51 for ; Thu, 11 Jul 2019 09:26:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25702208E4 for ; Thu, 11 Jul 2019 09:26:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V6TkcA3J"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="bbF0YZqR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25702208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z+sy/+8foC22qlgk0TCTk8qYttoL2QmyWaTiOy078X0=; b=V6TkcA3J3IRdN3 pNEVHkd9NyI+nhIBt57fpg6Ek9nuPE+9Wv4CWBoh4Lvcsw0QT3YOhXEQdObhoNyxffNUOVcOxw/P/ cpNn0UG1OAzoY1eJ8QERrFn3vvgDQnTEzQAB7upjQjZPXoG+zqFutY4ovNtYlMY+ts/PdyFbRoedu wNwy/g5HeQCnPgcpdqjEVe+SjIEcnD4FV6pblsX7XECk53DqpACkkUUc9EunEJSs5RBGg/+63d+1u ZVJ0bfuESHMBQNoBqR5xDm3vJ5GyzC6s8BeFTf+4FPkkE6vLztEIqlilfwceTIWFgvPj4/DqtDNWV 8pUW4IZ0EkVDNOR2wyiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hlVLK-0005RU-Tc; Thu, 11 Jul 2019 09:26:22 +0000 Received: from hqemgate15.nvidia.com ([216.228.121.64]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hlVLI-0005Qh-DJ for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2019 09:26:21 +0000 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 11 Jul 2019 02:26:22 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 11 Jul 2019 02:26:17 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 11 Jul 2019 02:26:17 -0700 Received: from [10.21.132.148] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 11 Jul 2019 09:26:15 +0000 Subject: Re: [PATCH v2 1/6] ARM: tegra: Remove cpuidle drivers To: Dmitry Osipenko , Thierry Reding , Peter De Schrijver , "Rafael J. Wysocki" , Daniel Lezcano References: <20190711031312.10038-1-digetx@gmail.com> <20190711031312.10038-2-digetx@gmail.com> From: Jon Hunter Message-ID: Date: Thu, 11 Jul 2019 10:26:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190711031312.10038-2-digetx@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1562837182; bh=hqIKbaLc9u3UzCLBN+TeJmaoAdvZZzW+MJhMM3sW0uY=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=bbF0YZqRGy0UYIMDV+2nHio1AliAu0r+Pj2lye6MoUfl1nPCx6h3eIgTiVsMLPlNQ Br5tEJk3HRK62aXro7HboHWQQHR/oVb4IRR7Ra5OaiIF/0srCD6aen9R59wAW5UDXB hSIQoBLPYecQPq0mqcY8waaODaZ04MkZo9CuSoEwEOxvGbFO34ohFnXfk/s3B8xTcq +3VPzdC/1IDOmHbIqRR4PDPhj+9iAeaqoRxjXgACWMvIqw1mxmTo8hfJh5CQu5ya7k s7l5xpDZ8klmr83hfskwnKIMMC4w/qT/KG71NB3wrycPi8/yeCb6ph8Ek640Guq9dG 0WRkc6OdafrNw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190711_022620_464629_6FB97AE0 X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/07/2019 04:13, Dmitry Osipenko wrote: > Remove the old drivers to replace them cleanly with a new one later on. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/mach-tegra/Makefile | 13 -- > arch/arm/mach-tegra/cpuidle-tegra114.c | 89 ----------- > arch/arm/mach-tegra/cpuidle-tegra20.c | 212 ------------------------- > arch/arm/mach-tegra/cpuidle-tegra30.c | 132 --------------- > arch/arm/mach-tegra/cpuidle.c | 50 ------ > arch/arm/mach-tegra/cpuidle.h | 21 --- > arch/arm/mach-tegra/irq.c | 18 --- > arch/arm/mach-tegra/irq.h | 11 -- > arch/arm/mach-tegra/pm.c | 7 - > arch/arm/mach-tegra/pm.h | 1 - > arch/arm/mach-tegra/reset-handler.S | 11 -- > arch/arm/mach-tegra/reset.h | 9 +- > arch/arm/mach-tegra/sleep-tegra20.S | 190 +--------------------- > arch/arm/mach-tegra/sleep.h | 12 -- > arch/arm/mach-tegra/tegra.c | 3 - > drivers/soc/tegra/Kconfig | 1 - > include/soc/tegra/cpuidle.h | 4 - > 17 files changed, 5 insertions(+), 779 deletions(-) > delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra114.c > delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra20.c > delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra30.c > delete mode 100644 arch/arm/mach-tegra/cpuidle.c > delete mode 100644 arch/arm/mach-tegra/cpuidle.h > delete mode 100644 arch/arm/mach-tegra/irq.h By removing all the above, it is really hard to review the diff. Is there any way you could first consolidate the cpuidle drivers into say the existing arch/arm/mach-tegra/cpuidle-tegra20.c and then move to drivers/cpuidle? Jon -- nvpublic _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel