On Tuesday, March 12, 2019 at 5:14:30 AM UTC-7, Ju= lia Lawall wrote:

A better log message would explain why the message is not necessary. = =C2=A0I
guess that if you unfold this, you will end up at kmalloc, which provid= es
a backtrace on failure, so the message is not very useful. =C2=A0But yo= u should
trace thrugh the definition to see that this is actually what happens.= =C2=A0

I traced down the memory alloc f= unction to=C2=A0alloc_skb (network buffer alloc), all the way down to kmem_= cache_alloc, which had a=C2=A0trace_kmem_cache_alloc function to provide a = skb alloc trace.

I understand that "out of memory" mess= age can be found in the stack dump done by the memory subsystem. Thus this = "out of memory" error is unnecessary. But I don't know how to= present this in log message.

Is "Delete=C2=A0netdev_err=C2=A0since generic message can be found in stac= k dump" good for this?

Wentao

=C2= =A0=C2=A0=C2=A0

=C2=A0

julia

>
> Signed-off-by: Wentao Cai <etsa...@gmail.com>
> ---
> =C2=A0drivers/staging/netlogic/xlr_net.c | 4 +---
> =C2=A01 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/sta= ging/netlogic/xlr_net.c
> index 8554fcf4321b..10f14a5cf490 100644
> --- a/drivers/staging/netlogic/xlr_net.c
> +++ b/drivers/staging/netlogic/xlr_net.c
> @@ -185,10 +185,8 @@ static int xlr_net_fill_rx_ring(struct net_de= vice *ndev)
>
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0for (i =3D 0= ; i < MAX_FRIN_SPILL / 4; i++) {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0skb_data =3D xlr_alloc_skb();
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (!skb_data) {
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0netdev_err(ndev, "SKB allocation failed\n");
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (!skb_data)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0return -ENOMEM;
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0}
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0send_to_rfr_fifo(priv, skb_data);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0}
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0netdev_info(= ndev, "Rx ring setup done\n");
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google= Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, = send an email to outreachy-kern...@googlegroups.com.
> To post to this group, send email to outreach...@googlegroups.com<= /a>.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy= -kernel/20190312093511.3789-1-etsai042%40gmail.com.
> For more options, visit https://groups.go= ogle.com/d/optout.
>