From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752713AbdFTAkr (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Jun 2017 20:40:47 -0400
Received: from mail-pf0-f180.google.com ([209.85.192.180]:32823 "EHLO
        mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751963AbdFTAkq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Jun 2017 20:40:46 -0400
Subject: Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio
To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        "open list:LOCKING PRIMITIVES" <linux-kernel@vger.kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
        Sebastian Siewior <bigeasy@linutronix.de>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Juri Lelli <juri.lelli@arm.com>, Thomas Gleixner <tglx@linutronix.de>,
        fengguang.wu@intel.com
References: <1495689995-29849-1-git-send-email-alex.shi@linaro.org>
 <1495689995-29849-3-git-send-email-alex.shi@linaro.org>
From: Alex Shi <alex.shi@linaro.org>
Message-ID: <c0985762-1b38-a0e5-9f57-4968f9435d1d@linaro.org>
Date: Tue, 20 Jun 2017 08:40:13 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <1495689995-29849-3-git-send-email-alex.shi@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

CC fengguang.

This patch survived in Fengguang's 0day testing on
https://github.com/alexshi/power-scheduling.git rtmutex-doc :)

Regards
Alex

On 05/25/2017 01:26 PM, Alex Shi wrote:
> We don't need to adjust prio before new pi_waiter adding. The prio
> only need update after pi_waiter change or task priority change.
> 
> Signed-off-by: Alex Shi <alex.shi@linaro.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Sebastian Siewior <bigeasy@linutronix.de>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Juri Lelli <juri.lelli@arm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> To: linux-kernel@vger.kernel.org
> To: Ingo Molnar <mingo@redhat.com>
> To: Peter Zijlstra <peterz@infradead.org>
> ---
>  kernel/locking/rtmutex.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
> index b955094..b659ba0 100644
> --- a/kernel/locking/rtmutex.c
> +++ b/kernel/locking/rtmutex.c
> @@ -963,7 +963,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock,
>  		return -EDEADLK;
>  
>  	raw_spin_lock(&task->pi_lock);
> -	rt_mutex_adjust_prio(task);
>  	waiter->task = task;
>  	waiter->lock = lock;
>  	waiter->prio = task->prio;
>