From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E13DC4363D for ; Fri, 2 Oct 2020 13:18:10 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A231206E3 for ; Fri, 2 Oct 2020 13:18:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="V0+tjxSV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A231206E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.2104.6238 (Exim 4.92) (envelope-from ) id 1kOKwa-0007zk-Ae; Fri, 02 Oct 2020 13:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 2104.6238; Fri, 02 Oct 2020 13:17:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kOKwa-0007zd-7T; Fri, 02 Oct 2020 13:17:52 +0000 Received: by outflank-mailman (input) for mailman id 2104; Fri, 02 Oct 2020 13:17:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kOKwY-0007zY-QM for xen-devel@lists.xenproject.org; Fri, 02 Oct 2020 13:17:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e54f8b33-d105-456f-b109-3305d53996be; Fri, 02 Oct 2020 13:17:49 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 524BBB1AD; Fri, 2 Oct 2020 13:17:48 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kOKwY-0007zY-QM for xen-devel@lists.xenproject.org; Fri, 02 Oct 2020 13:17:50 +0000 X-Inumbo-ID: e54f8b33-d105-456f-b109-3305d53996be Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e54f8b33-d105-456f-b109-3305d53996be; Fri, 02 Oct 2020 13:17:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1601644668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PX4dwCD9Cc3WL0Wjr7dU6lXpu5u9Qb4TT68DJnkaZbc=; b=V0+tjxSVIVqqoAj7wBjEwYP5sN4T/KmyWwNn84xihdfYaoB6TN8T0VEY3VokpwTzN3PI/O NnGwlQtTaOGfDkyYEBpDY3W04WMlrSYCdLq9zdxgYT//bbR1etVC1eyfdMGkA6FesvH0Tz O3Cm9C+/DrcQ0HHRNK5jCFo9NGre6iU= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 524BBB1AD; Fri, 2 Oct 2020 13:17:48 +0000 (UTC) Subject: Re: [PATCH] build: always use BASEDIR for xen sub-directory To: Bertrand Marquis Cc: "open list:X86" References: <556f6327acea2d0343c93da28f1fc17591afd402.1601564274.git.bertrand.marquis@arm.com> <706afc44-a414-33ff-da94-b92f7a96f1fc@suse.com> <31FC9BB1-F4C4-4203-94C1-1134607E49C2@arm.com> <547D8B47-C521-4F43-976F-D1723470AD3C@arm.com> From: Jan Beulich Message-ID: Date: Fri, 2 Oct 2020 15:17:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <547D8B47-C521-4F43-976F-D1723470AD3C@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02.10.2020 14:44, Bertrand Marquis wrote: > > >> On 2 Oct 2020, at 13:38, Jan Beulich wrote: >> >> On 02.10.2020 14:34, Bertrand Marquis wrote: >>>> On 2 Oct 2020, at 13:12, Jan Beulich wrote: >>>> >>>> On 02.10.2020 12:42, Bertrand Marquis wrote: >>>>> Modify Makefiles using $(XEN_ROOT)/xen to use $(BASEDIR) instead. >>>>> >>>>> This is removing the dependency to xen subdirectory preventing using a >>>>> wrong configuration file when xen subdirectory is duplicated for >>>>> compilation tests. >>>>> >>>>> Signed-off-by: Bertrand Marquis >>>> >>>> Acked-by: Jan Beulich >>> >>> Thanks :-) >>> >>>> >>>> (but more for the slight tidying than the purpose you name) >>> >>> Feel free to remove the justification from the commit message if >>> you think it is not usefull. >> >> Oh, no, it's not like I consider it not useful. It shows how you >> arrived at making the change. It's just that I didn't consider >> making copies of xen/ something we mean to be supported. I wouldn't >> be surprised if it got broken again ... > > basically i do this a “cp -rs” of xen subdirectory so that i can have directories > in which xen is compiled for x86, arm32 and arm64 and recompile all of them > quickly without having to go through distclean, config, make each time or modify > the original tree. But then you must have adjustments also in the top level makefile, such that besides "make xen", "make xen-xyz" also works. Jan