All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Cc: Gilles Talis <gilles.talis@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/tesseract-ocr: override neon check
Date: Tue, 1 Feb 2022 23:00:23 +0100	[thread overview]
Message-ID: <c09f71ec-7a87-a692-14b6-e493be611ed7@mind.be> (raw)
In-Reply-To: <20220125223454.444515-1-fontaine.fabrice@gmail.com>



On 25/01/2022 23:34, Fabrice Fontaine wrote:
> Override neon check to avoid the following build failure with uclibc-ng
> raised since bump to version 5.0.1 in commit
> df3f0c226fccd8d6143b09a1e05a0f5f23587136:
> 
> src/arch/simddetect.cpp:61:14: fatal error: sys/auxv.h: No such file or directory
>     61 | #    include <sys/auxv.h>
>        |              ^~~~~~~~~~~~
> 
> It should be noted that a patch to properly fix this build failure was
> rejected by upstream as "ARM support without NEON would result in a very
> slow Tesseract": https://github.com/tesseract-ocr/tesseract/pull/3717
> 
> So, a follow-up patch adding a dependency on !BR2_TOOLCHAIN_USES_UCLIBC
> for all CPU architectures or only for ARM without NEON could be
> approriate.
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/0bac6491188b6681df2ca13eb230706e83cbb130
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/tesseract-ocr/tesseract-ocr.mk | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/package/tesseract-ocr/tesseract-ocr.mk b/package/tesseract-ocr/tesseract-ocr.mk
> index 7e23e64136..a7498931fb 100644
> --- a/package/tesseract-ocr/tesseract-ocr.mk
> +++ b/package/tesseract-ocr/tesseract-ocr.mk
> @@ -24,6 +24,12 @@ TESSERACT_OCR_CONF_ENV = \
>   TESSERACT_OCR_CONF_OPTS = \
>   	--disable-opencl
>   
> +ifeq ($(BR2_ARM_CPU_HAS_NEON),y)
> +TESSERACT_OCR_CONF_ENV += ax_cv_check_cxxflags__mfpu_neon=yes
> +else
> +TESSERACT_OCR_CONF_ENV += ax_cv_check_cxxflags__mfpu_neon=no
> +endif
> +
>   # Language data files download
>   ifeq ($(BR2_PACKAGE_TESSERACT_OCR_LANG_ENG),y)
>   TESSERACT_OCR_DATA_FILES += eng.traineddata
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-02-01 22:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 22:34 [Buildroot] [PATCH 1/1] package/tesseract-ocr: override neon check Fabrice Fontaine
2022-02-01 22:00 ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c09f71ec-7a87-a692-14b6-e493be611ed7@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=gilles.talis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.